Re: [PATCH weston] compositor-wayland: Call set_window_geometry when using zxdg_shell_v6

2017-03-24 Thread Quentin Glidic
On 3/24/17 11:45 PM, Sergi Granell wrote: This way Wayland compositors will be aware of Weston's "visible bounds" (and ignore its shadows). Signed-off-by: Sergi Granell Looks good, added my Rb and pushed: 88353dda..ed016bff master -> master Thanks, --- libweston/compositor-wayland.c | 1

[PATCH weston] compositor-wayland: Call set_window_geometry when using zxdg_shell_v6

2017-03-24 Thread Sergi Granell
This way Wayland compositors will be aware of Weston's "visible bounds" (and ignore its shadows). Signed-off-by: Sergi Granell --- libweston/compositor-wayland.c | 16 1 file changed, 16 insertions(+) diff --git a/libweston/compositor-wayland.c b/libweston/compositor-wayland.c

Re: [PATCH wayland] server: document wl_event_loop and wl_event_source

2017-03-24 Thread Yong Bakos
Hi Pekka, > On Mar 3, 2017, at 7:54 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > This documents all the public API related to wl_event_loop and > wl_event_source objects. > > Signed-off-by: Pekka Paalanen I did not find any issues with the descriptions of these methods, and while

Re: [PATCH weston v2] weston-terminal: Fix race at startup

2017-03-24 Thread Quentin Glidic
On 3/24/17 10:29 PM, Derek Foreman wrote: If anything is printed for the terminal window to display before the window has been initially sized we end up with a segfault. This defers the exec() of the shell child process until after the window is sized so this can't happen anymore. Signed-off-by

[PATCH weston v2] weston-terminal: Fix race at startup

2017-03-24 Thread Derek Foreman
If anything is printed for the terminal window to display before the window has been initially sized we end up with a segfault. This defers the exec() of the shell child process until after the window is sized so this can't happen anymore. Signed-off-by: Derek Foreman Reviewed-by: Quentin Glidic

Re: [PATCH weston 3/3] weston-terminal: Fix race at startup

2017-03-24 Thread Quentin Glidic
On 3/24/17 3:41 PM, Derek Foreman wrote: If anything is printed for the terminal window to display before the window has been initially sized we end up with a segfault. This defers the exec() of the shell child process until after the window is sized so this can't happen anymore. Signed-off-by:

Re: [PATCH weston 1/2] os: Check for EINTR on posix_fallocate()

2017-03-24 Thread Quentin Glidic
On 3/23/17 6:42 PM, Eric Engestrom wrote: On Thursday, 2017-03-23 11:59:22 -0500, Derek Foreman wrote: posix_fallocate() can return EINTR and need to be restarted - I've hit this when running weston-terminal under gdb. Signed-off-by: Derek Foreman Both patches are: Reviewed-by: Eric Engestro

Re: [PATCH weston v2 1/2] compositor-wayland: Refactor struct wayland_output::name usage

2017-03-24 Thread Quentin Glidic
On 3/24/17 8:48 PM, Sergi Granell wrote: struct wayland_output::name was used but never initialized. Also zxdg_toplevel_v6_set_title was only called for windowed outputs, and some compositors let you see the client's name even when it is fullscreen (GNOME Shell's Activities menu for example). So

[PATCH weston v2 1/2] compositor-wayland: Refactor struct wayland_output::name usage

2017-03-24 Thread Sergi Granell
struct wayland_output::name was used but never initialized. Also zxdg_toplevel_v6_set_title was only called for windowed outputs, and some compositors let you see the client's name even when it is fullscreen (GNOME Shell's Activities menu for example). So rename struct wayland_output::name to stru

[PATCH weston v2 2/2] compositor-wayland: Check the return value of wayland_output_create_common

2017-03-24 Thread Sergi Granell
If wayland_output_create_common returns NULL, it means that the output creation failed. Signed-off-by: Sergi Granell --- libweston/compositor-wayland.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libweston/compositor-wayland.c b/libweston/compositor-wayla

Re: [PATCH weston 1/2] compositor-wayland: Refactor struct wayland_output::name usage

2017-03-24 Thread Quentin Glidic
On 3/24/17 7:53 PM, Sergi Granell wrote: struct wayland_output::name was used but never initialized. Also zxdg_toplevel_v6_set_title was only called for windowed outputs, and some compositors let you see the client's name even when it is fullscreen (GNOME Shell's Activities menu for example). So

Re: [PATCH weston 2/2] compositor-wayland: Check the return value of wayland_output_create_common

2017-03-24 Thread Armin Krezović
On 24.03.2017 19:53, Sergi Granell wrote: If wayland_output_create_common returns NULL, it means that the output creation failed. Signed-off-by: Sergi Granell While I think that splitting the definition and initialization wasn't necessary, the fix is still correct. I did wish that it was sent

Re: [PATCH weston 1/2] compositor-wayland: Refactor struct wayland_output::name usage

2017-03-24 Thread Armin Krezović
On 24.03.2017 19:53, Sergi Granell wrote: struct wayland_output::name was used but never initialized. Also zxdg_toplevel_v6_set_title was only called for windowed outputs, and some compositors let you see the client's name even when it is fullscreen (GNOME Shell's Activities menu for example). S

[PATCH weston 2/2] compositor-wayland: Check the return value of wayland_output_create_common

2017-03-24 Thread Sergi Granell
If wayland_output_create_common returns NULL, it means that the output creation failed. Signed-off-by: Sergi Granell --- libweston/compositor-wayland.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libweston/compositor-wayland.c b/libweston/compositor-wayla

[PATCH weston 1/2] compositor-wayland: Refactor struct wayland_output::name usage

2017-03-24 Thread Sergi Granell
struct wayland_output::name was used but never initialized. Also zxdg_toplevel_v6_set_title was only called for windowed outputs, and some compositors let you see the client's name even when it is fullscreen (GNOME Shell's Activities menu for example). So rename struct wayland_output::name to stru

Re: [PATCH weston] weston-resizor: Don't add new frame callbacks every click

2017-03-24 Thread Derek Foreman
Sorry, I forgot about this for a while. On 17/02/17 10:31 PM, Jonas Ådahl wrote: On Wed, Feb 08, 2017 at 03:05:54PM -0600, Derek Foreman wrote: The frame callback added on button click re-adds itself when done, so adding a new one every click resulted in an ever increasing number of callbacks.

[PATCH weston 1/3] weston: Set CLOEXEC on stdin

2017-03-24 Thread Derek Foreman
We don't want to leak this into apps launched from the panel. stdout and stderr are left for now because some things launched by weston - such as weston-keyboard - share weston's log by printing to those fds. I'm singling out stdin because it's never needed by a child process and because it's val

[PATCH weston 2/3] desktop-shell: launch clients in their own process group.

2017-03-24 Thread Derek Foreman
Client applications shouldn't be in the same process group as the display server. Signed-off-by: Derek Foreman --- clients/desktop-shell.c | 4 1 file changed, 4 insertions(+) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index b133d86e..2667e9bb 100644 --- a/clients/deskt

[PATCH weston 0/3] Small bug fix series

2017-03-24 Thread Derek Foreman
Some tangentially related bug fixes I stumbled on while fixing a startup race in weston-terminal. I think in the long term I think we should consider setting CLOEXEC on stdin, stderr, and stdout - but I don't do that here because it would break logging for weston-keyboard et al. Those should prob

[PATCH weston 3/3] weston-terminal: Fix race at startup

2017-03-24 Thread Derek Foreman
If anything is printed for the terminal window to display before the window has been initially sized we end up with a segfault. This defers the exec() of the shell child process until after the window is sized so this can't happen anymore. Signed-off-by: Derek Foreman --- clients/terminal.c | 3

Re: [PATCH weston v9 14/62] compositor-drm: Introduce fb_last member

2017-03-24 Thread Pekka Paalanen
On Thu, 23 Mar 2017 15:56:55 + Daniel Stone wrote: > Hi, > > On 22 March 2017 at 14:35, Pekka Paalanen wrote: > > On Fri, 3 Mar 2017 23:05:25 + > > Daniel Stone wrote: > >> Clean up some ambiguity around current/next: current could previously > >> have referred to a buffer which was

[Video] ILM support for waylandsink query

2017-03-24 Thread Vikas Patil
Dear All, I am trying to add support for wayland-ivi-extension 1.11.0 to waylandsink [1] (video sink plug-in from gstreamer1.0-plugins-bad package) for Jacinto6 SoC using following two methods. 1. Using ivi-application protocol similar to simple-egl.c (test from weston) - This works. - Here is vi

Re: [RFC] Interface for injection of input events

2017-03-24 Thread Pekka Paalanen
Hi Peter, more questions but not necessarily for you to answer - people who want to make use of the proposed interface should ideally answer most of these. On Fri, 24 Mar 2017 15:04:57 +1000 Peter Hutterer wrote: > On Wed, Mar 22, 2017 at 01:59:43PM +0200, Pekka Paalanen wrote: > > On Wed, 22 M