Re: [PATCH wayland] cursor: Use shm_open() instead of XDG_RUNTIME_DIR files

2017-10-18 Thread Pekka Paalanen
On Wed, 18 Oct 2017 22:53:04 -0700 Thiago Macieira wrote: > On Wednesday, 18 October 2017 07:05:46 PDT Matt Hoosier wrote: > > On Wed, Oct 18, 2017 at 4:23 AM, Quentin Glidic > > > > wrote: > > > + fd = shm_open("/wayland-cursor-shared", O_CREAT | O_RDWR, 0); > > > + shm_unlink("/

Re: [PATCH wayland] cursor: Use shm_open() instead of XDG_RUNTIME_DIR files

2017-10-18 Thread Thiago Macieira
On Wednesday, 18 October 2017 07:05:46 PDT Matt Hoosier wrote: > On Wed, Oct 18, 2017 at 4:23 AM, Quentin Glidic > > wrote: > > + fd = shm_open("/wayland-cursor-shared", O_CREAT | O_RDWR, 0); > > + shm_unlink("/wayland-cursor-shared"); > > This seems to be a departure from the anonym

[ANNOUNCE] libinput 1.9.0

2017-10-18 Thread Peter Hutterer
libinput 1.9 is now available. As expected, not a lot of changes since the rc2: a few test fixes, a fix to stop excessive logging and an extra assert so we fail early in case of a bug. The rest of this email is a copy/paste from the rc1 announcements, all the features were described there: The au

Re: [PATCH libinput 1/2] test: unref the litest device *after* removing it from the path interface

2017-10-18 Thread Jonas Ådahl
On Thu, Oct 19, 2017 at 08:39:02AM +1000, Peter Hutterer wrote: > Our own reference may be the last one that's still alive if the context is > currently suspended (litest_suspend()). If we unref before removing it from > the path interface, we access already freed memory. > > Signed-off-by: Peter

[PATCH libinput 1/2] test: unref the litest device *after* removing it from the path interface

2017-10-18 Thread Peter Hutterer
Our own reference may be the last one that's still alive if the context is currently suspended (litest_suspend()). If we unref before removing it from the path interface, we access already freed memory. Signed-off-by: Peter Hutterer --- test/litest.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH libinput 2/2] util: add an extra assert for list_insert()

2017-10-18 Thread Peter Hutterer
If we're adding an element that's not null or not a freshly initialized list, chances are we haven't removed it from a previous list. Signed-off-by: Peter Hutterer --- src/libinput-util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libinput-util.c b/src/libinput-util.c index 48cb71

Re: [PATCH wayland] cursor: Use shm_open() instead of XDG_RUNTIME_DIR files

2017-10-18 Thread Matt Hoosier
On Wed, Oct 18, 2017 at 4:23 AM, Quentin Glidic wrote: > + fd = shm_open("/wayland-cursor-shared", O_CREAT | O_RDWR, 0); > + shm_unlink("/wayland-cursor-shared"); This seems to be a departure from the anonymous behavior that mkstemp() previously offered. shm_open() says that it will o

[PATCH wayland] cursor: Use shm_open() instead of XDG_RUNTIME_DIR files

2017-10-18 Thread Quentin Glidic
From: Quentin Glidic Using XDG_RUNTIME_DIR to create anonymous files is problematic when XDG_RUNTIME_DIR is not a tmpfs. OTOH, shm_open is in POSIX.1-2001, so it should be available on all platforms we care about. As a bonus, the created fd is already CLOEXEC. Signed-off-by: Quentin Glidic ---

Re: [PATCH weston v2] libweston-desktop/xdg-shell-v6: Actually send same-as-current configure if needed

2017-10-18 Thread Quentin Glidic
On 10/18/17 11:01 AM, Jonas Ådahl wrote: On Wed, Oct 18, 2017 at 10:58:44AM +0200, Quentin Glidic wrote: From: Quentin Glidic If a surface is in state A, and we just sent a configure for state B, setting back state A would be ignored, because state B has not been committed yet. Now, we check a

Re: [PATCH weston v2] libweston-desktop/xdg-shell-v6: Actually send same-as-current configure if needed

2017-10-18 Thread Jonas Ådahl
On Wed, Oct 18, 2017 at 10:58:44AM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > If a surface is in state A, and we just sent a configure for state B, > setting back state A would be ignored, because state B has not been > committed yet. > Now, we check against the latest configured sta

[PATCH weston v2] libweston-desktop/xdg-shell-v6: Actually send same-as-current configure if needed

2017-10-18 Thread Quentin Glidic
From: Quentin Glidic If a surface is in state A, and we just sent a configure for state B, setting back state A would be ignored, because state B has not been committed yet. Now, we check against the latest configured state (which is current state if configure list is empty). Reported on wlroots