Re: [PATCH wayland v3 06/10] util: Pass flags to map iterators

2017-12-27 Thread Daniel Stone
Hi, On 6 December 2017 at 17:22, Derek Foreman wrote: > static enum wl_iterator_result > -destroy_resource(void *element, void *data) > +_destroy_resource(void *element, void *data, uint32_t flags) > { > struct wl_resource *resource = element; > - struct wl_client *client = resour

Re: [PATCH wayland v3 03/10] connection: Refactor out closure allocation

2017-12-27 Thread Daniel Stone
Hi, On 27 December 2017 at 14:08, Daniel Stone wrote: > On 6 December 2017 at 17:22, Derek Foreman wrote: >> Moves the common/similar bits into one place. >> >> This has a minor functional change - count and message are now initialized >> immediately, previously they'd only be set if (de)marshal

Re: [PATCH wayland v3 04/10] connection: Clear fds we shouldn't close to -1

2017-12-27 Thread Daniel Stone
Hi Derek, On 6 December 2017 at 17:22, Derek Foreman wrote: > This initializes all the fd arguments in closures to -1 and clears > them back to -1 when they've been dispatched or serialized. > > This means that any valid fd in a closure is currently libwayland's > responsibility to close in the c

Re: [PATCH wayland v3 03/10] connection: Refactor out closure allocation

2017-12-27 Thread Daniel Stone
Hi Derek, On 6 December 2017 at 17:22, Derek Foreman wrote: > Moves the common/similar bits into one place. > > This has a minor functional change - count and message are now initialized > immediately, previously they'd only be set if (de)marshal was successful. I've reviewed this does what it s