Re: [PATCH v5 5/7] libweston: fbdev: Attempt to detect the first framebuffer device in the seat. instead of defaulting to /dev/fb0

2018-01-22 Thread Pekka Paalanen
On Tue, 23 Jan 2018 00:06:36 -0500 nerdopolis wrote: > On Monday, January 22, 2018 4:50:35 AM EST Pekka Paalanen wrote: > > On Fri, 29 Dec 2017 13:31:51 -0500 > > nerdopolis wrote: > > > > > This adds a function to detect the first framebuffer device in the > > > current seat. Instead of hard

Re: [PATCH v5 5/7] libweston: fbdev: Attempt to detect the first framebuffer device in the seat. instead of defaulting to /dev/fb0

2018-01-22 Thread nerdopolis
On Monday, January 22, 2018 4:50:35 AM EST Pekka Paalanen wrote: > On Fri, 29 Dec 2017 13:31:51 -0500 > nerdopolis wrote: > > > This adds a function to detect the first framebuffer device in the > > current seat. Instead of hardcoding /dev/fb0, use udev to find the > > first framebuffer device in

[PATCH weston 2/3] file-util: allow specifying path separately in file_create_dated()

2018-01-22 Thread Aleksander Morgado
Instead of assuming the file prefix contains the path and filename prefix, give these two items separately. A NULL or empty string path may still be given to refer to the current directory. Signed-off-by: Aleksander Morgado diff --git a/libweston/timeline.c b/libweston/timeline.c index 8234c27c

[PATCH weston 3/3] screenshot: save screenshot files in XDG_PICTURES_DIR

2018-01-22 Thread Aleksander Morgado
If XDG_PICTURES_DIR not given, it will use the current directory, as it was before. Signed-off-by: Aleksander Morgado diff --git a/clients/screenshot.c b/clients/screenshot.c index be8d9fe6..78a5d424 100644 --- a/clients/screenshot.c +++ b/clients/screenshot.c @@ -217,7 +217,8 @@ write_png(int w

[PATCH weston 0/3] screenshooter improvements

2018-01-22 Thread Aleksander Morgado
Hey, These patches try to improve a bit the behavior of the screenshooter, by making it easier to take multiple screenshots and allowing to store them in a location different than the current directory. Comments? Cheers! Aleksander Morgado (3): screenshot: save each new screenshot in a differ

[PATCH weston 1/3] screenshot: save each new screenshot in a different file

2018-01-22 Thread Aleksander Morgado
Instead of overwriting the 'wayland-screenshot.png' file over and over, store each requested screenshot in a filename based on timestamp and sequence number. Signed-off-by: Aleksander Morgado diff --git a/clients/screenshot.c b/clients/screenshot.c index 6e43d5ce..be8d9fe6 100644 --- a/clients/s

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-22 Thread Adam Jackson
On Thu, 2018-01-18 at 11:41 +0100, Olivier Fourdan wrote: > This is a rare occurrence of a crash in Xwayland for which I don't have > the reproducing steps, just a core file. > > The backtrace looks as follow: > > #0 raise () from /usr/lib64/libc.so.6 > #1 abort () from /usr/lib64/libc.so.6

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-22 Thread Emil Velikov
On 22 January 2018 at 15:09, Pekka Paalanen wrote: > On Mon, 22 Jan 2018 14:46:15 + > Emil Velikov wrote: > >> On 19 January 2018 at 15:49, Derek Foreman wrote: >> > On 2018-01-19 01:22 AM, Jonas Ådahl wrote: >> >> >> >> On Thu, Jan 18, 2018 at 10:48:14AM +0200, Pekka Paalanen wrote: >> >>>

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-22 Thread Emil Velikov
On 22 August 2017 at 14:02, Emil Velikov wrote: > On 18 August 2017 at 13:05, Pekka Paalanen wrote: > >>> > >>> > The exported configuration would then be: >>> > LOCAL_INTERFACE_DECL=extern >>> > EXTERN_INTERFACE_DECL=extern >>> > LOCAL_INTERFACE_DEF=WL_EXPORT >>> > >>> > That would be far too fl

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-22 Thread Pekka Paalanen
On Mon, 22 Jan 2018 14:46:15 + Emil Velikov wrote: > On 19 January 2018 at 15:49, Derek Foreman wrote: > > On 2018-01-19 01:22 AM, Jonas Ådahl wrote: > >> > >> On Thu, Jan 18, 2018 at 10:48:14AM +0200, Pekka Paalanen wrote: > >>> > >>> > >>> the original proposal was to prefix ABI symbo

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-22 Thread Emil Velikov
On 19 January 2018 at 15:49, Derek Foreman wrote: > On 2018-01-19 01:22 AM, Jonas Ådahl wrote: >> >> On Thu, Jan 18, 2018 at 10:48:14AM +0200, Pekka Paalanen wrote: >>> >>> On Wed, 17 Jan 2018 15:43:07 -0600 >>> Derek Foreman wrote: >>> On 2017-08-18 07:41 AM, Pekka Paalanen wrote: > >>>

Re: [PATCH] gl-renderer: Create a high priority context

2018-01-22 Thread Daniel Stone
Hi Chris, wayland-devel@ rather than weston[sic]-dev[sic]@ ... On Sat, 2018-01-20 at 00:39 +, Chris Wilson wrote: > EGL_IMG_context_priority allows the client to request that their > rendering be considered high priority. For ourselves, this is important > as we are interactive and any delay i

Re: [systemd-devel] [PATCH weston] doc/systemd: system service example

2018-01-22 Thread Pekka Paalanen
On Fri, 29 Dec 2017 15:09:28 -0600 Matt Hoosier wrote: > Hi Lennart, > > On Mon, Dec 4, 2017 at 9:11 AM, Pekka Paalanen wrote: > > On Fri, 1 Dec 2017 18:25:35 +0100 > > Lennart Poettering wrote: > > > >> So, as long as weston runs from a PAM enabled service (and its PAM > >> snippet pulls i

Re: [PATCH wayland 2/2] server: Send differentiated errors on wl_registry.bind

2018-01-22 Thread Pekka Paalanen
On Mon, 22 Jan 2018 13:32:31 +0100 Philipp Kerling wrote: > This now uses the new error codes introduced to wl_registry instead > of abusing WL_DISPLAY_ERROR_INVALID_OBJECT. > --- > src/wayland-server.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Hi, both patches are: A

[PATCH wayland 2/2] server: Send differentiated errors on wl_registry.bind

2018-01-22 Thread Philipp Kerling
This now uses the new error codes introduced to wl_registry instead of abusing WL_DISPLAY_ERROR_INVALID_OBJECT. --- src/wayland-server.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 7225b4e..e33af62 100644 --- a/src/w

[PATCH wayland 1/2] protocol: Add error enum to wl_registry

2018-01-22 Thread Philipp Kerling
As an oversight, wl_registry did not define any errors. At least error 0 is already being sent by libwayland-server although it is - strictly speaking - undefined. Define error 0 to be an invalid global which is also a sort of catch-all error code. Errors 1 (invalid version) and 2 (incompatible ve

Re: [PATCH weston 6/6] ivi-shell: remove ivi_shell_setting

2018-01-22 Thread Pekka Paalanen
On Wed, 3 Jan 2018 16:09:21 +0100 Emre Ucan wrote: > it has only developermode option parameter. > The parameter is only used in init_ivi_shell. > Therefore, we can basically remove the struct, > and check the option locally in the function. > > Signed-off-by: Emre Ucan > --- > ivi-shell/ivi-s

Re: [PATCH weston 5/6] ivi-shell: don't load controller modules

2018-01-22 Thread Pekka Paalanen
On Wed, 3 Jan 2018 16:09:20 +0100 Emre Ucan wrote: > controller modules can be loaded as weston modules > from the main function of weston. > > Signed-off-by: Emre Ucan > --- > ivi-shell/ivi-layout.c | 40 > ivi-shell/ivi-shell.c | 28 -

Re: [PATCH weston 4/6] tests: load ivi-shell test plugins as weston module

2018-01-22 Thread Pekka Paalanen
On Wed, 3 Jan 2018 16:09:19 +0100 Emre Ucan wrote: > Signed-off-by: Emre Ucan > --- > tests/ivi_layout-internal-test.c | 21 - > tests/ivi_layout-test-plugin.c | 20 +++- > 2 files changed, 15 insertions(+), 26 deletions(-) > > diff --git a/tests/ivi_layou

Re: [PATCH weston 3/6] hmi-controller: load as weston module

2018-01-22 Thread Pekka Paalanen
On Wed, 3 Jan 2018 16:09:18 +0100 Emre Ucan wrote: > weston loads hmi-controller as a weston module. > IVI-shell does not need to load it explicitly. > > Signed-off-by: Emre Ucan > --- > ivi-shell/hmi-controller.c | 33 ++--- > ivi-shell/weston.ini.in| 2 +- >

Re: [PATCH weston 1/6] ivi-shell: register ivi_layout_interface

2018-01-22 Thread Pekka Paalanen
On Wed, 3 Jan 2018 16:09:16 +0100 Emre Ucan wrote: > controller modules can be loaded from the main function of weston. > They will get the ivi_layout_interface via weston plugin registry. > > Signed-off-by: Emre Ucan > --- > ivi-shell/ivi-layout-export.h | 13 + > ivi-shell/ivi-la

Re: [PATCH weston 2/6] hmi-controller: remove ivi_layout_interface global

2018-01-22 Thread Pekka Paalanen
On Wed, 3 Jan 2018 16:09:17 +0100 Emre Ucan wrote: > Put the interface into hmi_controller struct. > It is better to have it in an object. > > Signed-off-by: Emre Ucan > --- > ivi-shell/hmi-controller.c | 194 > +++-- > 1 file changed, 100 insertions(+)

Re: [PATCH v5 7/7] libweston: fbdev: Follow the same logic as compositor-drm, and favor the boot_vga device

2018-01-22 Thread Pekka Paalanen
On Fri, 29 Dec 2017 13:31:53 -0500 nerdopolis wrote: > virtual framebuffer devices that are created by a modesetting driver have the > same parent > as the drm card devices. Hi, is this also true for legacy fbdev drivers that are not DRM drivers? I suppose if not, they would just use the fallb

Re: [PATCH v5 6/7] main: don't configure /dev/fb0 by default

2018-01-22 Thread Pekka Paalanen
On Fri, 29 Dec 2017 13:31:52 -0500 nerdopolis wrote: > --- > compositor/main.c | 3 --- > 1 file changed, 3 deletions(-) Hi, the commit message is missing the answer to the question "Why is it bad to configure /dev/fb0 by default?" Thanks, pq > diff --git a/compositor/main.c b/compositor/ma

Re: [PATCH v5 5/7] libweston: fbdev: Attempt to detect the first framebuffer device in the seat. instead of defaulting to /dev/fb0

2018-01-22 Thread Pekka Paalanen
On Fri, 29 Dec 2017 13:31:51 -0500 nerdopolis wrote: > This adds a function to detect the first framebuffer device in the > current seat. Instead of hardcoding /dev/fb0, use udev to find the > first framebuffer device in the seat. > --- > libweston/compositor-fbdev.c | 45 >

Re: [PATCH wayland] connection: Clear correct args when clearing fds to -1

2018-01-22 Thread Daniel Stone
On 22 January 2018 at 08:07, Pekka Paalanen wrote: > On Fri, 19 Jan 2018 15:20:31 -0600 > Derek Foreman wrote: >> commit 52609ddf79a96fee0465006e2c6339a3a5d23a87 was intended to >> set fds to -1 in the arg list, however it failed to account for >> version information at the start of signatures. >

Re: [PATCH wayland] connection: Clear correct args when clearing fds to -1

2018-01-22 Thread Pekka Paalanen
On Fri, 19 Jan 2018 15:20:31 -0600 Derek Foreman wrote: > commit 52609ddf79a96fee0465006e2c6339a3a5d23a87 was intended to > set fds to -1 in the arg list, however it failed to account for > version information at the start of signatures. Heh, yeah, I too was completely baffled why that commit wo