[PATCH v6 2/6] libweston: fbdev: support the --seat option, (and XDG_SEAT variable)

2018-01-23 Thread nerdopolis
This allows the fbdev backend to run on, and use devices from the specified seat, similar to the drm backend. --- compositor/main.c| 2 ++ libweston/compositor-fbdev.c | 10 +- libweston/compositor-fbdev.h | 1 + 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/

[PATCH v6 3/6] launcher-logind: only get a VT on seat0, as only seat0 supports VTs

2018-01-23 Thread nerdopolis
As only seat0 supports TTYs, this changes the logind launcher where it detects a TTY, only if the seat is seat0. This has only been tested for logind --- libweston/launcher-logind.c | 22 -- libweston/launcher-util.c | 4 2 files changed, 16 insertions(+), 10 deletions(

[PATCH v6 6/6] main: don't configure /dev/fb0 by default

2018-01-23 Thread nerdopolis
The framebuffer backend now detects the framebuffer device dynamically. Don't assume that the framebuffer device is /dev/fb0 --- compositor/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/compositor/main.c b/compositor/main.c index ecd034b9..02de108b 100644 --- a/compositor/main.c +++

[PATCH v6 1/6] libweston: set the seat automatically based on the XDG_SEAT environment variable

2018-01-23 Thread nerdopolis
This will allow the seat to be set by the environment as pam_systemd typically sets the XDG_SEAT variable --- compositor/main.c | 2 +- libweston/compositor-drm.c | 5 + man/weston-drm.man | 7 +-- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/compositor/

[PATCH v6 4/6] libweston: fbdev: set fb device info upon the first run.

2018-01-23 Thread nerdopolis
This attempts to wake up secondary framebuffer devices (/dev/fb1 and up) as usually these devices start powered off, and the FBIOPUT_VSCREENINFO ioctl turns it on. This was tested on a qemu system with the options: -vga none -device VGA,id=video0 -device secondary-vga,id=video1 \ -device secondary

[PATCH v6 0/6] Make Weston multiseat aware

2018-01-23 Thread nerdopolis
These patches make Weston handle multiple seats. Fixes from the last attempt include updating fbdev_set_screen_info , updating some fuzz, and making the selection of the framebuffer device similar to compositor-drm.c by favoring the boot_vga device, and making requested changes nerdopolis (6):

[PATCH v6 5/6] libweston: fbdev: Attempt to detect the first framebuffer device in the seat. instead of defaulting to /dev/fb0

2018-01-23 Thread nerdopolis
This adds a function to detect the first framebuffer device in the current seat. Instead of hardcoding /dev/fb0, detect the device with udev, favoring the boot_vga device, and falling back to the first framebuffer device in the seat if there is none. This is very similar to what compositor-drm does

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-23 Thread Adam Jackson
On Tue, 2018-01-23 at 10:15 +, Daniel Stone wrote: > Ooh. serialNumber == 1 means it's the root pixmap, which will actually > be uselessly empty. It would be interesting to see how we've ended up > here: it would have to be a top-level window which a) was manually > redirected by the WM when i

Re: [PATCH v14 19/41] compositor-drm: Extract buffer->plane co-ord translation

2018-01-23 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:36 + Daniel Stone wrote: > Pull this into a helper function, so we can use it everywhere. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 157 > + > 1 file changed, 88 insertions(+), 69 deletions(-)

Re: [PATCH v14 18/41] compositor-drm: Make alpha-to-opaque handling common

2018-01-23 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:35 + Daniel Stone wrote: > Rather than a hardcoded ARGB -> XRGB translation inside a > GBM-specific helper, just determine whether or not the view is opaque, > and use the generic helpers to implement the format translation. > > Signed-off-by: Daniel Stone

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-23 Thread Olivier Fourdan
Hi Daniel, On Tue, Jan 23, 2018 at 11:15 AM, Daniel Stone wrote: > Ooh. serialNumber == 1 means it's the root pixmap, which will actually > be uselessly empty. It would be interesting to see how we've ended up > here: it would have to be a top-level window which a) was manually > redirected by t

Re: [PATCH v14 17/41] compositor-drm: Atomic modesetting support

2018-01-23 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:34 + Daniel Stone wrote: > Add support for using the atomic-modesetting API to apply output state. > Unlike previous series, this commit does not unflip sprites_are_broken, > until further work has been done with assign_planes to make it reliable. > > Signed-off-by:

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-23 Thread Daniel Stone
Hi, On 23 January 2018 at 09:42, Olivier Fourdan wrote: > On 22 January 2018 at 19:57, Adam Jackson wrote: >> That can't really be the problem. X drawables are never 0x0. > > Yeap, I don't know how we end with a pximap of size 0×0: > > [...] > (gdb) f 7 > #7 xwl_glamor_pixmap_get_wl_buffer (pix

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-23 Thread Olivier Fourdan
Hey Adam, On 22 January 2018 at 19:57, Adam Jackson wrote: > On Thu, 2018-01-18 at 11:41 +0100, Olivier Fourdan wrote: > > This is a rare occurrence of a crash in Xwayland for which I don't have > > the reproducing steps, just a core file. > > > > The backtrace looks as follow: > > > > [...] >