[PATCH] xdg-shell: remove constraint on popup parents

2018-03-14 Thread Drew DeVault
It seems that this was partially done in a3cf97ff982638bf7ed23b4303eba280c521b54d; this patch just corrects an oversight. --- stable/xdg-shell/xdg-shell.xml | 3 --- 1 file changed, 3 deletions(-) diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg-shell.xml index d524ea9..2255d77

Re: Proposal: use of xdg-shell popups outside of xdg-shell

2018-03-14 Thread Jonas Ådahl
On Tue, Mar 13, 2018 at 09:29:30AM -0400, Drew DeVault wrote: > Hi there! Over at the wlroots project we're thinking about repurposing > xdg-shell popups for use in another protocol that needs popups. The > popup interface is somewhat complex and duplicating it for each protocol > that might want t

Re: wl_buffer is not released for long time.

2018-03-14 Thread Sichem Zhou
Dear Pekka, Thanks for your idea on this, I inserted a callback in the `surface_commit` function in libweston. From the log I can see that the `surface commit` was blocked on the server side until some other events happen. On the client side it was clear that I committed two buffers then sleeped b

Re: [PATCH weston] libweston-desktop/xdg-shell-v6: Fix crash when surface has buffer at creation

2018-03-14 Thread Derek Foreman
On 2018-03-13 01:18 PM, Quentin Glidic wrote: On 3/13/18 5:34 PM, Derek Foreman wrote: When a surface has a buffer at creation time we send an error, which results in a disconnection and all resources being destroyed. Since we send that error and return before performing the configure_list in

Re: [PATCH libinput] tools: libinput-debug-events stop variable needs volatile

2018-03-14 Thread Peter Hutterer
On Tue, Mar 13, 2018 at 09:28:22PM +0100, Peter Seiderer wrote: > The stop variable set in the signal handler needs > volatile (and use the defined sig_atomic_t instead > of unsigned int). > > Signed-off-by: Peter Seiderer > --- > tools/libinput-debug-events.c | 2 +- > 1 file changed, 1 inserti

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Drew DeVault
On 2018-03-14 3:16 PM, Simon Ser wrote: > However, the situation we'd like to avoid is clients wanting decorations not > implementing CSD at all and relying on this protocol to show them via SSD. > What > about rewording this sentence to: I understand where you're coming from, but this is not so

Re: weston-launch: libEGL: no configs with appropriate attributes

2018-03-14 Thread Král Gergely
2018-03-14 12:36 időpontban Pekka Paalanen ezt írta: [ 13.090647] [drm] Loading R100 Microcode Does this card actually support any kind of shaders? Maybe the Weston build guide is mistaken there. As Emil clarified: this must be the case. Weston's GL renderer supports only GL ES 2.0, whic

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Simon Ser
On March 14, 2018 7:33 PM, Drew DeVault wrote: > On 2018-03-14 6:41 AM, Simon Ser wrote: > > > Since we assume CSD by default, this implies that any client must be able > > > to > > > do CSD, which should be explicitly stated here. > > > > It's already stated in the protocol description ("Note

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Drew DeVault
On 2018-03-14 6:41 AM, Simon Ser wrote: > > Since we assume CSD by default, this implies that any client must be able to > > do CSD, which should be explicitly stated here. > > It's already stated in the protocol description ("Note that even if > the server supports server-side window decorations

[PATCH weston] configure.ac: fixup systemd/systemd-login detection

2018-03-14 Thread Emil Velikov
From: Emil Velikov Current systemd/systemd-login integration requires dbus. Although that is far from clear the way current checks are handled. Be explicit and clear, effectively fixing cases where the systemd auto detection will trip when dbus is explicitly disabled. Using git show -w will mak

Re: weston-launch: libEGL: no configs with appropriate attributes

2018-03-14 Thread Emil Velikov
On 14 March 2018 at 11:36, Pekka Paalanen wrote: > On Wed, 14 Mar 2018 11:55:54 +0100 > Král Gergely wrote: > >> Hi, >> >> >> On my old notebook I would like to set up a test environment by running >> weston and let clients to connect to it. I am stuck in the very >> beginning and after almost a

[PATCH libinput] tools: libinput-debug-events stop variable needs volatile

2018-03-14 Thread Peter Seiderer
The stop variable set in the signal handler needs volatile (and use the defined sig_atomic_t instead of unsigned int). Signed-off-by: Peter Seiderer --- tools/libinput-debug-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libinput-debug-events.c b/tools/libinpu

Re: Proposal: use of xdg-shell popups outside of xdg-shell

2018-03-14 Thread Pekka Paalanen
On Wed, 14 Mar 2018 09:13:48 -0400 Drew DeVault wrote: > >just checking, how did you design your own protocol extension to take > >advantage of xdg_popup? I mean, mechanically, what does the protocol > >request sequence look like when you create an xdp_popup for your own > >purpose? > > > >I'm as

Re: weston-launch: libEGL: no configs with appropriate attributes

2018-03-14 Thread Pekka Paalanen
On Wed, 14 Mar 2018 11:55:54 +0100 Král Gergely wrote: > Hi, > > > On my old notebook I would like to set up a test environment by running > weston and let clients to connect to it. I am stuck in the very > beginning and after almost a day of googling and trying to understand > documentation

weston-launch: libEGL: no configs with appropriate attributes

2018-03-14 Thread Král Gergely
Hi, On my old notebook I would like to set up a test environment by running weston and let clients to connect to it. I am stuck in the very beginning and after almost a day of googling and trying to understand documentation that are over my expertise I am asking your help. According to the

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Simon Ser
On March 14, 2018 10:22 AM, Peter Hutterer wrote: > sorry about the delay, but better late than too late ;) No problem, thanks for your review! > On Sun, Mar 11, 2018 at 05:53:42PM -0400, Simon Ser wrote: > > This adds a new protocol to negotiate server- and client-side rendering of > > window d

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Peter Hutterer
sorry about the delay, but better late than too late ;) On Sun, Mar 11, 2018 at 05:53:42PM -0400, Simon Ser wrote: > This adds a new protocol to negotiate server- and client-side rendering of > window decorations for xdg-toplevels. This allows compositors that want > to draw decorations themselves

[PATCH] configure.ac: fix have_dbus if dbus support is disabled

2018-03-14 Thread Michael Tretter
If dbus support is explicitly disabled, $have_dbus should be no, but was empty. systemd-login support depends on dbus, but the check does not trigger correctly, if $have_dbus is empty. Signed-off-by: Michael Tretter --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.a

compositor: do not free output region twice in weston_output_set_transform()

2018-03-14 Thread Ilia Bozhinov
This is already done when weston_output_init_geometry() is called. Actually this is a fix for 8564a0d, because without this patch, the compositor sometimes crashes when setting output transform Signed-off-by: Ilia Bozhinov --- libweston/compositor.c | 3 --- 1 file changed, 3 deletions(-) diff

Re: [PATCH wayland] configure.ac: don't install the static libraries

2018-03-14 Thread Peter Hutterer
On Tue, Mar 13, 2018 at 01:43:37PM +, Emil Velikov wrote: > From: Emil Velikov > > One should always be using the shared libraries. > > Spotted while going through the Debian packaing. > > Signed-off-by: Emil Velikov > --- > Can we have this in the 1.5 release, please? Reviewed-by: Peter

Re: wl_buffer is not released for long time.

2018-03-14 Thread Pekka Paalanen
On Tue, 13 Mar 2018 14:11:29 + Sichem Zhou wrote: > Dear Matt, > > I just checked my compiled version, indeed I was using a version without > this patch. I patched my local weston but it didn't seem that my problem is > gone. So I guess there could be other problems with my code, but thanks

Re: Proposal: use of xdg-shell popups outside of xdg-shell

2018-03-14 Thread Pekka Paalanen
On Tue, 13 Mar 2018 09:29:30 -0400 Drew DeVault wrote: > Hi there! Over at the wlroots project we're thinking about repurposing > xdg-shell popups for use in another protocol that needs popups. The > popup interface is somewhat complex and duplicating it for each protocol > that might want to sup