Re: [PATCH weston 21/25] protocol: add weston_touch_calibration

On Wed, Apr 11, 2018 at 02:00:49PM +0300, Pekka Paalanen wrote: > On Wed, 11 Apr 2018 10:16:46 +1000 > Peter Hutterer wrote: > > > > > + An event carries the touch device identification and the > > > > > associated > > > > > + output or head (display connector)

Re: [PATCHv2] text-input: Add v3 of the text-input protocol

On Thu, 12 Apr 2018 21:26:08 +0200 Silvan Jegen wrote: > Hi Dorota > > On Wed, Apr 11, 2018 at 03:03:58PM +0200, Dorota Czaplejewicz wrote: > > This new protocol description is a simplification over v2. > > > > - All pre-edit text styling is gone. > > - No events regarding

Re: [PATCHv2] text-input: Add v3 of the text-input protocol

Hi Dorota On Wed, Apr 11, 2018 at 03:03:58PM +0200, Dorota Czaplejewicz wrote: > This new protocol description is a simplification over v2. > > - All pre-edit text styling is gone. > - No events regarding input panel (OSK) state nor covered rectangle. > Compositors are still free to handle

Re: [PATCH weston v6 65/73] compositor-drm: no need to clear inherited_mode

Hi Pekka, On 16 February 2018 at 15:57, Pekka Paalanen wrote: > The head was just zalloc()'d, there is no need to memset it to zero. > > If a function fails, it is preferable it leaves the output arguments > untouched. Everything to this point is: Reviewed-by: Daniel Stone

Re: [PATCH weston v6 56/73] compositor-drm: remove unused_connectors array

On 12 April 2018 at 14:48, Pekka Paalanen wrote: > On Thu, 12 Apr 2018 14:38:01 +0200 Daniel Stone wrote: >> > + wl_list_for_each(head_base, >> > +>compositor->head_list, >> > compositor_link) { >> >>

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

On Thu, 12 Apr 2018 15:37:43 +0300 Pekka Paalanen wrote: > On Thu, 12 Apr 2018 14:03:32 +0200 > Daniel Stone wrote: > > > Hi Pekka, > > I've reviewed up to this point (the first half as discussed before, > > second half from this submission), and it

Re: [PATCH weston v6 56/73] compositor-drm: remove unused_connectors array

On Thu, 12 Apr 2018 14:38:01 +0200 Daniel Stone wrote: > Hi Pekka, > > On 16 February 2018 at 15:57, Pekka Paalanen wrote: > > Replace the unused_connectors array by iterating through the head list > > instead. A head that is not enabled (attached to

Re: [PATCH weston v6 57/73] compositor-drm: drm_output_apply_state_legacy heads

On 16 February 2018 at 15:57, Pekka Paalanen wrote: > @@ -1863,7 +1869,7 @@ drm_output_apply_state_legacy(struct drm_output_state > *state) > } > > ret = drmModeSetCrtc(backend->drm.fd, output->crtc_id, 0, 0, > 0, > -

Re: [PATCH weston v6 56/73] compositor-drm: remove unused_connectors array

Hi Pekka, On 16 February 2018 at 15:57, Pekka Paalanen wrote: > Replace the unused_connectors array by iterating through the head list > instead. A head that is not enabled (attached to an enabled output) is > basically an unused connector. > > All connectors regardless of

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

On Thu, 12 Apr 2018 14:03:32 +0200 Daniel Stone wrote: > Hi Pekka, > I've reviewed up to this point (the first half as discussed before, > second half from this submission), and it all looks good so far. One > question: > > On 16 February 2018 at 15:57, Pekka Paalanen

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

Hi Pekka, I've reviewed up to this point (the first half as discussed before, second half from this submission), and it all looks good so far. One question: On 16 February 2018 at 15:57, Pekka Paalanen wrote: > +/** Replace connector data and monitor information > + * > + *

Re: [PATCH weston v6 00/73] Head-based output configuration API a.k.a clone mode infrastructure

Hi Pekka, On 16 February 2018 at 15:56, Pekka Paalanen wrote: > here is the v6 of the shared-CRTC clone mode series. Since v5, quite > many patches have been extracted from this series, sent out and merged > upstream. However, now the series is bigger than ever, because here

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

On Thu, 12 Apr 2018 10:35:04 +0200 Jonas Ådahl wrote: > On Thu, Apr 12, 2018 at 12:13:49AM +0200, Carlos Garnacho wrote: > > Hi!, > > > > On Wed, Apr 11, 2018 at 8:52 PM, Weng Xuetian wrote: > > > (forgot to reply to the list) > > > > > > On Wednesday, 11

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

On Thu, Apr 12, 2018 at 12:13:49AM +0200, Carlos Garnacho wrote: > Hi!, > > On Wed, Apr 11, 2018 at 8:52 PM, Weng Xuetian wrote: > > (forgot to reply to the list) > > > > On Wednesday, 11 April 2018 11:35:58 PDT Dorota Czaplejewicz wrote: > >> On Wed, 11 Apr 2018 11:26:22 -0700

[PATCH libinput 17/23] filter: drop the ntrackers argument from init_trackers

Reduces the duplication, everyone uses the same value anyway Signed-off-by: Peter Hutterer --- src/filter-low-dpi.c | 3 +-- src/filter-private.h | 3 +-- src/filter-touchpad-x230.c | 7 +-- src/filter-touchpad.c | 7 +-- src/filter.c

[PATCH libinput 21/23] util: add a helper function to split a key-value pair string

Signed-off-by: Peter Hutterer --- src/libinput-util.h | 63 + test/test-misc.c| 53 2 files changed, 116 insertions(+) diff --git a/src/libinput-util.h

[PATCH libinput 18/23] filter: split the mouse acceleration out into a separate file

Signed-off-by: Peter Hutterer --- meson.build| 1 + src/filter-mouse.c | 326 + src/filter.c | 297 +--- 3 files changed, 329 insertions(+), 295 deletions(-)

[PATCH libinput 22/23] Expose a custom acceleration profile

This adds a third profile to the available profiles to map device-specific speed to an acceleration factor, fully defined by the caller. There has been a consistent call for different acceleration profiles in libinput, but very little specifics in what actually needs to be changed. "faster

[PATCH libinput 23/23] touchpad: allow custom profiles on touchpads

Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 29 - 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index bdc41a64..5b1ac476 100644 --- a/src/evdev-mt-touchpad.c

[PATCH libinput 19/23] filter: namespace the various trackers_* functions

Signed-off-by: Peter Hutterer --- src/filter-low-dpi.c | 10 +- src/filter-mouse.c | 10 +- src/filter-private.h | 12 ++-- src/filter-touchpad-x230.c | 14 +++--- src/filter-touchpad.c | 10 +-

[PATCH libinput 16/23] filter: tidy up the touchpad filter

Signed-off-by: Peter Hutterer --- src/filter-touchpad.c | 39 +-- 1 file changed, 9 insertions(+), 30 deletions(-) diff --git a/src/filter-touchpad.c b/src/filter-touchpad.c index 717b6803..9217137c 100644 --- a/src/filter-touchpad.c

[PATCH libinput 20/23] filter: duplicate the pointer_accelerator struct into the bits that use it

Yeah, it's duplication. But this way it's also separation and we can't accidentally use the wrong struct. Signed-off-by: Peter Hutterer --- src/filter-low-dpi.c | 49 + src/filter-mouse.c| 17 +

[PATCH libinput 13/23] filter: move the velocity diff to the only function we use it in

Signed-off-by: Peter Hutterer --- src/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/filter.c b/src/filter.c index fef2c835..ed90af70 100644 --- a/src/filter.c +++ b/src/filter.c @@ -101,7 +101,6 @@ filter_get_type(struct motion_filter

[PATCH libinput 15/23] filter: split the low-dpi acceleration into a separate file

Plenty of duplication there from the normal filter.c, but that also makes it less likely to break if we adjust the other one. Signed-off-by: Peter Hutterer --- meson.build | 1 + src/filter-low-dpi.c | 253 +++

[PATCH libinput 11/23] filter: make the simpsons accel calculation available through the header

This is the standard approach for mice and touchpads to calculate the acceleration based on the last two deltas, let's make that code shareable. Signed-off-by: Peter Hutterer --- src/filter-private.h | 8 src/filter.c | 52

[PATCH libinput 14/23] filter: move the flat filter into a separate file

This also fixes a bug with the _noop function, because we casted to the wrong struct the dpi value was garbage. Signed-off-by: Peter Hutterer --- meson.build | 1 + src/filter-flat.c | 124 ++ src/filter.c

[PATCH libinput 08/23] filter: split the tablet accel code into a separate file

Signed-off-by: Peter Hutterer --- meson.build | 1 + src/filter-tablet.c | 197 src/filter.c| 146 -- 3 files changed, 198 insertions(+), 146 deletions(-) create

[PATCH libinput 10/23] filter: move the pointer_accelerator struct into the header

Signed-off-by: Peter Hutterer --- src/filter-private.h | 17 + src/filter.c | 17 - 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/filter-private.h b/src/filter-private.h index 10be823b..4779e8f2 100644 ---

[PATCH libinput 12/23] filter: split the touchpad acceleration code into a separate file

Signed-off-by: Peter Hutterer --- meson.build | 1 + src/filter-touchpad.c | 332 ++ src/filter.c | 177 --- 3 files changed, 333 insertions(+), 177 deletions(-) create mode

[PATCH libinput 07/23] filter: move the x230 filter into a separate file

There's a fair bit of duplication of code from filter.c but it's not worth disecting this and optimising it. The device is 5 years old now, we don't want to touch this accel method so duplication is good here. Signed-off-by: Peter Hutterer --- meson.build

[PATCH libinput 09/23] filter: split trackpoint acceleration code into a separate file

Signed-off-by: Peter Hutterer --- meson.build | 1 + src/filter-trackpoint.c | 309 src/filter.c| 263 - 3 files changed, 310 insertions(+), 263

[PATCH libinput 03/23] filter: move some functions to the shared header

Prep work for splitting things up better Signed-off-by: Peter Hutterer --- src/filter-private.h | 53 src/filter.c | 49 +++- 2 files changed, 56 insertions(+), 46

[PATCH libinput 02/23] filter: factor out the pointer trackers from the accel filter

No functional changes, just refactoring Signed-off-by: Peter Hutterer --- src/filter.c | 79 +++- 1 file changed, 46 insertions(+), 33 deletions(-) diff --git a/src/filter.c b/src/filter.c index

[PATCH libinput 01/23] meson: re-use the filter source list

Signed-off-by: Peter Hutterer --- meson.build | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index aeb734d8..05a45659 100644 --- a/meson.build +++ b/meson.build @@ -161,7 +161,7 @@ dep_libfilter =

[PATCH libinput 06/23] filter: add helper function to reset and free trackers

Signed-off-by: Peter Hutterer --- src/filter-private.h | 5 + src/filter.c | 43 +-- 2 files changed, 34 insertions(+), 14 deletions(-) diff --git a/src/filter-private.h b/src/filter-private.h index

[PATCH libinput 05/23] filter: pass trackers to calculate_velocity

So the function to calculate the velocity is easier to call from other sites. Signed-off-by: Peter Hutterer --- src/filter-private.h | 3 +++ src/filter.c | 11 +-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/filter-private.h

[PATCH libinput 00/23] pointer acceleration custom profile support

This patch series adds the ability to set a custom pointer acceleration profile. The profile maps speed (in device units) to an acceleration factor which is applied to the current delta, i.e. the same that the current accel curves do. The big difference here is that the user can control the

[PATCH libinput 04/23] filter: move the smoothing values to the trackers

This way we can pass them around easier without needing the whole pointer_accelerator struct (which in theory is device-type specific). The values relate to the calculation of the delta between trackers anyway, so logically this is where they belong. Signed-off-by: Peter Hutterer