[PATCH libinput] touchpad: fix tapping that happens after a moving thumb

When finger movement exceeded the motion threshold before the finger was recognized as a thumb, it would never be regarded as a thumb by the tap system. This prohibited tapping until the thumb was lifted. This is fixed by moving the check for the thumb state up such that it happens before the moti

Re: [PATCH libinput] touchpad: fix tapping that happens after a moving thumb

I have attached an evemu recording that illustrates the issue. In the recording a thumb touches the touchpad, gets state THUMB_STATE_MAYBE, then THUMB_STATE_YES. After that, a tap is performed, but it is ignored without the patch. Best, Friedrich On 05.05.2018 03:49, Friedrich Schöller wrote:

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota Czaplejewicz wrote: > On Thu, 3 May 2018 21:55:40 +0200 > Silvan Jegen wrote: > > > On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota Czaplejewicz wrote: > > > On Thu, 3 May 2018 20:47:27 +0200 > > > Silvan Jegen wrote: > > > > > > > Hi Dorota >

Re: libweston program segfaults on weston_compositor_load_backend

On Fri, 2018-05-04 at 10:13 +0300, Pekka Paalanen wrote: > > Is that perhaps the very first call to weston_log()? > > You need to initialize the logging mechanism before anything can call > weston_log(). Yeah, it's awkward, could probably be improved, but > OTOH > one would always want all log me

What is wesron_plane?

Hi all, Many data structure in libweston is straightforward, but I don't really know what does weston_plane do in the compositor. As it seems I don't need to deal with it alot. It seems that it's a abstract place to stack `weston_output` and `weston_views`. Like a virtual plane to draw all the out

Re: libweston program segfaults on weston_compositor_load_backend

On Fri, May 4, 2018 at 8:46 AM, Pekka Paalanen wrote: > On Fri, 4 May 2018 07:55:10 -0500 > Matt Hoosier wrote: > > > On Fri, May 4, 2018 at 2:13 AM, Pekka Paalanen > wrote: > > > > > The crucial call to make is weston_log_set_handler() with non-NULL > > > arguments before any other libweston c

[PATCH] log: improve handling of use-before-init

Rather than segfaulting by attempting to traverse an initially null log handler pointer, explicitly print a message and abort. Signed-off-by: Matt Hoosier --- libweston/log.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/libweston/log.c b/libweston/l

Re: libweston program segfaults on weston_compositor_load_backend

On Fri, 4 May 2018 07:55:10 -0500 Matt Hoosier wrote: > On Fri, May 4, 2018 at 2:13 AM, Pekka Paalanen wrote: > > > The crucial call to make is weston_log_set_handler() with non-NULL > > arguments before any other libweston calls. > > > > I wonder if this could be made clearer by adding an a

Re: [PATCH weston] libweston: don't accumulate damage from transparent views

On Fri, 4 May 2018 12:09:55 + "Ucan, Emre (ADITG/ESB)" wrote: > Hi Pekka, > > Sorry for late response. Hi Emre, no worries! > > -Original Message- > > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > > Sent: Donnerstag, 19. April 2018 12:36 > > To: Ucan, Emre (ADITG/ESB) > > Cc

Re: libweston program segfaults on weston_compositor_load_backend

On Fri, May 4, 2018 at 2:13 AM, Pekka Paalanen wrote: > On Thu, 03 May 2018 23:38:55 +0100 > adlo wrote: > > > On Thu, 2018-05-03 at 14:12 +0300, Pekka Paalanen wrote: > > > > > > what's the backtrace from gdb for that? > > > > > > > Is this any help? > > > > #0 0x in () > > #1

RE: [PATCH weston] libweston: don't accumulate damage from transparent views

Hi Pekka, Sorry for late response. > -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Donnerstag, 19. April 2018 12:36 > To: Ucan, Emre (ADITG/ESB) > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston] libweston: don't accumulate damage from

[PATCH weston 0/2] xwm: Dump properties.

This series adds code to help debug by dumping properties of type CARDINAL and WINDOW. Pekka Paalanen (2): xwm: dump properties of type CARDINAL xwm: dump properties of type WINDOW xwayland/window-manager.c | 70 ++- 1 file changed, 69 insertions(+

[PATCH weston 1/2] xwm: dump properties of type CARDINAL

From: Pekka Paalanen Add code to dump CARDINAL arrays from properties. Useful for debugging. Signed-off-by: Pekka Paalanen Signed-off-by: Fabien Lahoudere --- xwayland/window-manager.c | 66 ++- 1 file changed, 65 insertions(+), 1 deletion(-) diff

[PATCH weston 2/2] xwm: dump properties of type WINDOW

From: Pekka Paalanen Very useful for TRANSIENT_FOR property debugging. Signed-off-by: Pekka Paalanen Signed-off-by: Fabien Lahoudere --- xwayland/window-manager.c | 4 1 file changed, 4 insertions(+) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index 061ce17..2b3de

[PATCH weston 0/1] Improve override-redirect debug messages

This patch is an addition to https://patchwork.freedesktop.org/patch/211161/. Pekka Paalanen (1): xwm: improve override-redirect debug messages xwayland/window-manager.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) -- 1.8.3.1 _

[PATCH weston 1/1] xwm: improve override-redirect debug messages

From: Pekka Paalanen Explicitly say if O-R is yes or no, to not have to remember which messages possibly printed it. Signed-off-by: Pekka Paalanen Signed-off-by: Fabien Lahoudere Conflicts: xwayland/window-manager.c --- xwayland/window-manager.c | 29 - 1

Re: libweston program segfaults on weston_compositor_load_backend

On Thu, 03 May 2018 23:38:55 +0100 adlo wrote: > On Thu, 2018-05-03 at 14:12 +0300, Pekka Paalanen wrote: > > > > what's the backtrace from gdb for that? > > > > Is this any help? > > #0 0x in () > #1 0x7799c88c in weston_log (fmt=fmt@entry=0x779b6a7e > "Loadi