Re: [PATCH weston v5 12/14] compositor: Add scene-graph debug scope

2018-08-06 Thread Pekka Paalanen
On Fri, 20 Jul 2018 20:03:33 +0100 Daniel Stone wrote: > Add a 'scene-graph' debug scope which will dump out the current set of > outputs, layers, and views and as much information as possible about how > they are rendered and composited. > > Signed-off-by: Daniel Stone > --- >

Re: [PATCH weston v5 11/14] compositor: Add weston_layer_mask_is_infinite

2018-08-06 Thread Pekka Paalanen
On Fri, 20 Jul 2018 20:03:32 +0100 Daniel Stone wrote: > As a counterpart to weston_layer_set_mask_infinite(), returning if the > mask is the same as what is set. > > Signed-off-by: Daniel Stone > --- > libweston/compositor.c | 9 + > libweston/compositor.h | 3 +++ > 2 files changed,

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-06 Thread Pekka Paalanen
On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone wrote: > From: Pekka Paalanen > > weston_debug is both a libweston API for relaying debugging messages, > and the compositor-debug wayland protocol implementation for accessing those > debug messages from a Wayland client. > >

Re: [PATCH weston v5 10/14] compositor: protocol logger

2018-08-06 Thread Pekka Paalanen
On Mon, 30 Jul 2018 09:17:27 + "Ucan, Emre (ADITG/ESB)" wrote: > Hi Daniel, > > We found an issue with this patch. I am adding a patch to this email to fix > this issue. Please check: > > Subject: [PATCH] main: copy va_list for second use > > we are using va_list once for debug protocol

[RFC wayland-protocols] input-method: Add zwp-input-method-v2

2018-08-06 Thread Dorota Czaplejewicz
This protocol is based on v1, and current text-input-v3. The pieces passing data relevant to the application on the other side of the compositor are a mirror copy of text-input-v3 events and requests. Compared to input-method-v1: - assumes that once preedit is displayed, no selection can be

Re: [PATCH weston v5 06/14] compositor: offer logs via weston-debug

2018-08-06 Thread Pekka Paalanen
On Fri, 20 Jul 2018 20:03:27 +0100 Daniel Stone wrote: > From: Pekka Paalanen > > This registers a new weston-debug scope "log" through which one can get > live log output interspersed with possible other debugging prints. > > Signed-off-by: Pekka Paalanen > > pass the log_scope to

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-06 Thread Pekka Paalanen
On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone wrote: > From: Pekka Paalanen > > weston_debug is both a libweston API for relaying debugging messages, > and the compositor-debug wayland protocol implementation for accessing those > debug messages from a Wayland client. > >

[PATCH weston 2/5] doc: Update CONTRIBUTING for Weston

2018-08-06 Thread Daniel Stone
Change some Wayland-specific references to instead refer to Weston. Signed-off-by: Daniel Stone Reviewed-by: Quentin Glidic Reviewed-by: Pekka Paalanen --- CONTRIBUTING.md | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index

[PATCH weston 4/5] doc: Use GitLab MRs for patches, not the list

2018-08-06 Thread Daniel Stone
Though Wayland and the protocols still use mail-based patch review, Weston can now move to GitLab MRs with review through that system. Add some documentation on how to submit patches through GitLab, specifically targeted at people who may be familiar with GitLab review, but not familiar with our

[PATCH wayland 5/5] contributing: Weston now uses GitLab MRs

2018-08-06 Thread Daniel Stone
Note that Weston uses GitLab MRs for review, not mail. Signed-off-by: Daniel Stone --- CONTRIBUTING.md | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4273d99d..686ed63f 100644 --- a/CONTRIBUTING.md +++

[PATCH weston 1/5] Add CONTRIBUTING.md document

2018-08-06 Thread Daniel Stone
From: Pekka Paalanen Taken from Pekka's wayland/wayland@630c25f4c160 and follow-ups, use Wayland's CONTRIBUTING document as a basis for Weston. Signed-off-by: Daniel Stone Reviewed-by: Quentin Glidic Reviewed-by: Pekka Paalanen --- CONTRIBUTING.md | 343

[PATCH 0/5] Weston contributing doc, GitLab MRs

2018-08-06 Thread Daniel Stone
Hi, Thanks to Pekka and Quentin for the review: this fixes some errors in the original README/CONTRIBUTING doc submission for Weston, retaining the GitLab MR move. It also adds a patch to Wayland's CONTRIBUTING.md, severing the two sets of instructions. Cheers, Daniel

Re: [PATCH weston 4/4] doc: Use GitLab MRs for patches, not the list

2018-08-06 Thread Daniel Stone
Hi Pekka, On Fri, 3 Aug 2018 at 12:05, Pekka Paalanen wrote: > I'm happy to move to MR-based work flow immediately. \o/ > From the above link, I found this: > http://www.bitsnbites.eu/git-history-work-log-vs-recipe/ > which explain the below in more words. Maybe include this link as well? > >

Re: [PATCH weston v5 05/14] clients: add weston-debug

2018-08-06 Thread Pekka Paalanen
On Fri, 20 Jul 2018 20:03:26 +0100 Daniel Stone wrote: > From: Pekka Paalanen > > A tool for accessing the zcompositor_debug_v1 interface features. > > Installed along weston-info, because it should be potentially useful for > people running libweston-based compositors. > > Signed-off-by:

Re: How to release the weston_buffer after weston_view is destroyed.

2018-08-06 Thread Pekka Paalanen
On Fri, 3 Aug 2018 18:04:36 -0400 Sichem Zhou wrote: > Hi Pekka, > > Thanks for your reply. Yes, preferably if I can hide the map and unmap from > client, in this case I cannot because it is part of a desktop shell. After > I unmap it and remap the view next time, it is not expected the shell