Busy loop in the wl_priv_signal_final_emit

2018-08-29 Thread Matteo Valdina
Hi, I'm moving my compositor to latest libweston 5.0 /wayland 1.16 library and I noticed a regression when I terminate my compositor. The compositor will never exit because is stuck in a busy loop. The busy loop is in the "wl_priv_signal_final_emit" that was added in the latest wayland. And preci

[Patch v4][weston] gl-renderer.c: Use gr->egl_config to create pbuffer surface

2018-08-29 Thread Madhurkiran Harikrishnan
The original implementation always chose first egl config for pbuffer surface type, however the returned configs are implementation specific and egl config may not always match between ctx and surface. Hence, use gr->egl_config which already has the matching config but ensure that windows and pbuff

Re: [PATCH wayland v4 1/5] build/doc: Ensure destination dir exists despite VPATH

2018-08-29 Thread Emil Velikov
Hi Dan, On 28 August 2018 at 23:19, Daniel Stone wrote: > Make considers a variable called VPATH when trying to satisfy > dependencies, e.g. for a target 'foo', it will consider the target > extant if VPATH is '../../bar' and '../../bar/foo' exists. > > Part of the doc build, the '$(alldirs)' tar

Re: [PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 07:17, Daniel Stone wrote: > There are far better ways to detect memory leaks, such as either > valgrind or ASan. Having Meson makes it really easy to use these tools > in our tests, and we can do that in CI as well. > > Having these local wrappers actually completely broke AS

Re: [PATCH wayland 5/6] tests: Overly elaborate compiler warning workaround

2018-08-29 Thread Emil Velikov
Hi Dan, On 29 August 2018 at 07:17, Daniel Stone wrote: > Clang will rightly point out that example_sockaddr_un in socket-test > will get discarded from the compilation unit as it is completely unused. > Put in a couple of lines which of no value other than stopping Clang > from complaining. > >

Re: [PATCH wayland v4 3/5] Add Meson build to Wayland

2018-08-29 Thread Pekka Paalanen
On Tue, 28 Aug 2018 23:19:17 +0100 Daniel Stone wrote: > From: Emmanuele Bassi > > Meson is a next generation build system, simpler than Autotools and, > more importantly, faster and more portable. While the latter > consideration is of lesser importance for Wayland, being easier to > understan

[PATCH wayland-protocols v4] unstable/drm-lease: DRM lease protocol support

2018-08-29 Thread Marius Vlad
Simple protocol extension to manage DRM lease. Based on the work by Keith Packard in [1], respectively [2]. [1] https://cgit.freedesktop.org/mesa/drm/commit/?id=c4171535389d72e9135c9615cecd07b346fd6d7e [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.15-rc9&id=

Re: [PATCH wayland v4 2/5] Support running tests from different build directories

2018-08-29 Thread Pekka Paalanen
On Tue, 28 Aug 2018 23:19:16 +0100 Daniel Stone wrote: > From: Emmanuele Bassi > > The tests that run exec-fd-leak-checker expect the binary to be located > in the current directory. This is not always the case; for instance, the > binaries could be built under `tests`, but be invoked under the

Re: [PATCH wayland 0/6] Minor test/scanner fixes

2018-08-29 Thread Daniel Stone
On Wed, 29 Aug 2018 at 09:51, Pekka Paalanen wrote: > On Wed, 29 Aug 2018 07:17:09 +0100 Daniel Stone wrote: > > These first 5 patches fix some issues I found by running the test suite > > under an expanded set of toolchains, including the ASan address > > sanitiser and Clang's static analyser. >

Re: [PATCH wayland v4 1/5] build/doc: Ensure destination dir exists despite VPATH

2018-08-29 Thread Pekka Paalanen
On Tue, 28 Aug 2018 23:19:15 +0100 Daniel Stone wrote: > Make considers a variable called VPATH when trying to satisfy > dependencies, e.g. for a target 'foo', it will consider the target > extant if VPATH is '../../bar' and '../../bar/foo' exists. > > Part of the doc build, the '$(alldirs)' tar

Re: [PATCH wayland 0/6] Minor test/scanner fixes

2018-08-29 Thread Pekka Paalanen
On Wed, 29 Aug 2018 07:17:09 +0100 Daniel Stone wrote: > Hi, > These first 5 patches fix some issues I found by running the test suite > under an expanded set of toolchains, including the ASan address > sanitiser and Clang's static analyser. > > Patch 6 removes the leak checking from the test su