Re: [PATCH v2] protocol: Extend wl_touch with touchpoint shape event

Hi, Some questions below.. On Wed, Apr 6, 2016 at 11:52 PM, Peter Hutterer wrote: > On Wed, Apr 06, 2016 at 10:17:35AM -0700, Dennis Kempin wrote: > > On Tue, Apr 5, 2016 at 5:26 PM, Peter Hutterer > wrote: > > > On Tue, Apr 05, 2016 at

Re: [RFC libinput] Add dial input device support

se devices usually have a bunch of further buttons.. so buttonset sounds like a good generalization for those too. regards Andreas Pokorny ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [libinput] How I get extra touch events using libinput?

Hi, On Wed, Jan 6, 2016 at 8:30 AM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > CC-ing Andreas this time, forgot about it in my original reply, sorry about > that. > > On Wed, Jan 06, 2016 at 03:35:49PM +0900, 강정현 wrote: > > In Andreas Pokorny patch, only suppor

Re: [PATCH libinput v9 0/2] add orientation, size and pressure of touch

Hi, On Tue, Nov 24, 2015 at 1:41 AM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Nov 23, 2015 at 07:58:28PM +0100, Andreas Pokorny wrote: > [...] > > measured values on the e4.5 jumped a lot further. I need a more accurate > > method for that. In the seco

Re: [PATCH libinput v9 0/2] add orientation, size and pressure of touch

method for that. In the second round I will probably try to verify the result with a finger-paint application. On Mon, Nov 23, 2015 at 5:19 AM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Nov 13, 2015 at 08:46:42AM +0100, Andreas Pokorny wrote: > > Hi, > >

Re: [PATCH libinput v9 0/2] add orientation, size and pressure of touch

Hi, one more thing.. On Mon, Nov 23, 2015 at 7:58 PM, Andreas Pokorny < andreas.poko...@canonical.com> wrote: > [...] > > On Mon, Nov 23, 2015 at 5:19 AM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: > >> On Fri, Nov 13, 2015 at 08:46:42AM +010

[PATCH libinput v9 1/2] libinput: add orientation and size of touch point and pressure to the API

. Signed-off-by: Andreas Pokorny <andreas.poko...@canonical.com> --- doc/Makefile.am| 2 + doc/page-hierarchy.dox | 1 + doc/svg/touchscreen-touch-event-properties.svg | 347 + doc/touch-event-properti

[PATCH libinput v9 0/2] add orientation, size and pressure of touch

Hi, This version contains several rewordings and documentation additions from Peter that I missed in the last update, within the first patch of the series, while the second patch contains no changes compared to v8. regards Andreas Andreas Pokorny (2): libinput: add orientation and size

[PATCH libinput v9 2/2] extend tools to print and display touch event properties

event-gui draws the touch contact as two concentric ellipses that indicate contact pressure through oppacity. Signed-off-by: Andreas Pokorny <andreas.poko...@canonical.com> --- tools/event-debug.c | 29 - tools/event-gui.c

[PATCH libinput 1/2] libinput: add orientation and size of touch point and pressure to the API

. Signed-off-by: Andreas Pokorny <andreas.poko...@canonical.com> --- doc/Makefile.am| 2 + doc/page-hierarchy.dox | 1 + doc/svg/touchscreen-touch-event-properties.svg | 347 + doc/touch-event-properti

[PATCH libinput 2/2] extend tools to print and display touch event properties

event-gui draws the touch contact as two concentric ellipses that indicate contact pressure through oppacity. Signed-off-by: Andreas Pokorny <andreas.poko...@canonical.com> --- tools/event-debug.c | 29 - tools/event-gui.c

[PATCH libinput v8 0/2] add orientation, size and and pressure of touch

Hi, This version of the series deals released or not yet pressed touch contacts in event-gui. Additionally the code that was supposed to scale diameters on devices when horizontal and vertical axes have a different resolution was revised. regards Andreas Andreas Pokorny (2): libinput: add

Re: Weston 1.8.0: touch input using evdev not working

Hi, Could you send the contents of the files /sys/devices/virtual/input/input0/event0/{capabilities/*,properties}? Those show the information interpreted by the builtin rules in udevadm. But Benjamin might be right, upgrading to systemd-221 might fix your problem already. regards Andreas ​

Re: [PATCH] libinput device capability modification regarding combo input devices

do use a few additional masks to also indicate whether the device, i.e. it might be interesting to know whether the device is a full keyboard or just offers a few buttons.. So yes I aggree with that. Right now we do the evdev based device detection in parallel to what udevd and libinput do.. rega

Re: [PATCH libinput] Fix premature flushing of evdev event on mx4 touchscreen

Hi, On Mon, Sep 7, 2015 at 3:51 AM, Peter Hutterer wrote: > [...] > > + { {0}, EV_KEY, BTN_TOUCH, 0}, > > + { {0}, EV_KEY, BTN_TOOL_FINGER, 0}, > > + { {0}, EV_SYN, SYN_REPORT, 0} > > + }; > > I'm wondering - wouldn't it be

[PATCH v2 libinput] Fix premature flushing of evdev event on mx4 touchscreen

The mx4 touchscreen driver emits BTN_TOUCH and BTN_TOOL_FINGER key events on a new contact. Prior to this patch only the BTN_TOUCH event was filtered out. Now the whole range of BTN_ events for tool types and certain builtin multi finger gestures are marked as non-key type. Signed-off-by: Andreas

[PATCH libinput] Fix premature flushing of evdev event on mx4 touchscreen

on v5 of the touch property extenion patches. Signed-off-by: Andreas Pokorny <andreas.poko...@canonical.com> --- src/evdev.c | 10 ++--- test/touch.c | 125 +++ 2 files changed, 130 insertions(+), 5 deletions(-) diff --git a/src/evd

[PATCH libinput 1/2] libinput: add orientation and size of touch point and pressure to the API

. Signed-off-by: Andreas Pokorny <andreas.poko...@canonical.com> --- doc/Makefile.am| 2 + doc/page-hierarchy.dox | 1 + doc/svg/touchscreen-touch-event-properties.svg | 347 + doc/touch-event-properti

[PATCH libinput 2/2] extend tools to print and display touch event properties

event-gui draws the touch contact as two concentric ellipses that indicate contact pressure through oppacity. Signed-off-by: Andreas Pokorny <andreas.poko...@canonical.com> --- tools/event-debug.c | 30 -- tools/event-gui.c | 30 +++

[PATCH libinput v7 0/2] add orientation, size and pressure of touch

for those properties we might want to change that. Andreas Pokorny (2): libinput: add orientation and size of touch point and pressure to the API extend tools to print and display touch event properties doc/Makefile.am| 2 + doc/page-hierarchy.dox

[PATCH libinput] fix gcc warning on unused return value

Signed-off-by: Andreas Pokorny <andreas.poko...@canonical.com> --- test/litest.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/litest.c b/test/litest.c index 29e764b..38e313e 100644 --- a/test/litest.c +++ b/test/litest.c @@ -932,13 +932,15 @@ merge_

Re: [PATCH libinput] Note that libinput_unref() really destroys everything

Hi, To some degree this does not sound like a bug. At least for resources that are not presented to the user as being ref counted. But I would have expected that libinput_path_add_device would increase the ref count of the libinput_context and similar for seats. So as long as the device is not

Re: [PATCH libinput] libinput: add orientation and size of touch point and pressure to the API

Hi, On Tue, Sep 1, 2015 at 8:30 AM, Peter Hutterer wrote: > [...] > but first up, I have to ask: how did you test this, do you have an > implementation higher up in the stack that makes use of this? The API looks > generally ok now, but once I started testing it it

Re: [PATCH libinput 2/2] enable -Wall -Werror for CFLAGS

12:51:38 +0200 Andreas Pokorny andreas.poko...@canonical.com wrote: Just a small change in test is necessary to enable -Wall -Werror. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- configure.ac | 4 ++-- test/litest.c | 8 ++-- 2 files changed, 8

[PATCH libinput] libinput: add orientation and size of touch point and pressure to the API

. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- doc/Makefile.am| 2 + doc/page-hierarchy.dox | 1 + doc/svg/touchscreen-touch-event-properties.svg | 347 + doc/touch-event-properties.dox

[PATCH libinput] quirk for mtk kernels

Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- src/evdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 29303f8..1373e6f 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1886,6 +1886,16 @@ evdev_check_min_max(struct evdev_device

[PATCH libinput] RFC on quirk handling in libinput

of broken drivers (next to fixing the kernel vendor)? If adding an entry to the hwdb would help - how do I get to the strings that identify the device? regards, Andreas Andreas Pokorny (1): quirk for mtk kernels src/evdev.c | 10 ++ 1 file changed, 10 insertions(+) -- 2.1.4

[PATCH libinput] doc: inverse event type restriction of x and y accessors

Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- src/libinput.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/libinput.h b/src/libinput.h index f2b77b3..88b3c05 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -894,7 +894,8

[PATCH libinput] doc: ellipse instead of ellipsis

Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- doc/touchpads.dox | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/touchpads.dox b/doc/touchpads.dox index fa509bc..401f16a 100644 --- a/doc/touchpads.dox +++ b/doc/touchpads.dox @@ -71,7 +71,7 @@ touches

[PATCH libinput 2/2] enable -Wall -Werror for CFLAGS

Just a small change in test is necessary to enable -Wall -Werror. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- configure.ac | 4 ++-- test/litest.c | 8 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 885cb39..b7597f0

[PATCH libinput 1/2] test: fix gcc warning about missing prototypes

Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- test/litest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/litest.c b/test/litest.c index 8fc7bca..29e764b 100644 --- a/test/litest.c +++ b/test/litest.c @@ -44,6 +44,8 @@ #include sys/sendfile.h #include sys

[PATCH libinput] libinput: litest shall only emit auto assign events when replaced

With this change auto assign events will be skipped if no replacement value is provided. This behavior is practical when emitting mt events, as those only contain the axis values that changed. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- test/litest.c | 8 1 file

Re: [PATCH libinput v5 5/5] libinput: add orientation and size of touch point and pressure to the API

Hi, On Wed, Jul 8, 2015 at 1:03 AM, Peter Hutterer peter.hutte...@who-t.net wrote: +double +evdev_device_transform_touch_point_to_mm(struct evdev_device *device, + int32_t axis_value, + double axis_angle) oh

[PATCH libinput v5 5/5] libinput: add orientation and size of touch point and pressure to the API

supported by multi-touch drivers, so zero as a default value is used if the information is missing. This change also correctly bumps the ABI version to 0.20.0 and adds the new libinput symbols there. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- src/evdev.c| 192

[PATCH libinput 3/5] litest: add nexus4 style touch screen without orientation

This device provides a circular touch point size and and hence lacks orientation. It will be used to test default value handling. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- test/Makefile.am | 1 + test/litest-nexus4-touch-screen.c | 99

[PATCH libinput 2/5] litest: add a generic multitouch screen

Adds a device with various touch related axes and respective device features to litest. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- test/Makefile.am | 1 + test/litest-touch-screen.c | 105 + test/litest.c

[PATCH libinput v4 0/5] add touch pointer properties

' - behavior. So I could remove some now unnecessary parts like the tracking of available slot properties. Andreas Pokorny (5): litest: add axis_replacement from tablet branch litest: add a generic multitouch screen litest: add nexus4 style touch screen without orientation litest: floating point

[PATCH libinput 5/5] libinput: add orientation and size of touch point and pressure to the API

supported by multi-touch drivers, so zero as a default value is used if the information is missing. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- src/evdev.c| 192 +--- src/evdev.h| 24 ++ src/libinput-private.h

Re: [PATCH libinput v3 5/5] libinput: add orientation and size of touch point and pressure to the API

Hi, On Thu, Jun 25, 2015 at 8:03 AM, Peter Hutterer peter.hutte...@who-t.net wrote: [...] - break; - case ABS_MT_TRACKING_ID: + } else if(e-code == ABS_MT_TRACKING_ID) { if (device-pending_event != EVDEV_NONE device-pending_event !=

[PATCH libinput v3 5/5] libinput: add orientation and size of touch point and pressure to the API

supported by multi touch drivers, hence default values are provided if the information is missing. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- src/evdev.c| 243 +++-- src/evdev.h| 37 src/libinput

[PATCH libinput v3 2/5] litest: add a generic multitouch screen

Adds a device with various touch related axes and respective device features to litest. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- test/Makefile.am | 1 + test/litest-touch-screen.c | 135 + test/litest.c

[PATCH libinput v3 1/5] litest: add axis_replacement from tablet branch

This change adds strict axis_replacemnt and litest_touch_move_extended and litest_touch_down_extended to simulate changes to other axes during touch down and move events. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- test/litest.c | 95

Re: [PATCH libinput v2 5/5] libinput: add orientation and size of touch point and pressure to the API

Hi, On Mon, Jun 22, 2015 at 3:37 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Jun 19, 2015 at 03:24:38PM +0200, Andreas Pokorny wrote: + * */ + if (orientation_info) { + if (orientation_info-maximum == 1 + orientation_info-maximum

[PATCH libinput v2 5/5] libinput: add orientation and size of touch point and pressure to the API

supported by multi touch drivers, hence default values are provided if the information is missing. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- src/evdev.c| 158 ++-- src/evdev.h| 37 ++ src/libinput-private.h | 12

[PATCH libinput v2 2/5] litest: add a generic multitouch screen

Adds a device with various touch related axes and respective device features to litest. And additional routines to simulate pressure orientation and touch major/minor changes. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- test/Makefile.am | 1 + test/litest-touch

[PATCH libinput v2 0/5] add touch point properties to libinput_event_touch

/InputReader.cpp Andreas Pokorny (5): add axis_replacement from tablet branch litest: add a generic multitouch screen litest: add mako style touch screen without orientation litest: floating point comparison macros libinput: add orientation and size of touch point and pressure

[PATCH libinput v2 4/5] litest: floating point comparison macros

Adds the macros ck_assert_double_{eq,ne,lt,gt,le,ge} to compare double values using a fixed tolerance value. The tolerance value is picked based on the range of values to be expected by the libinput API. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- test/litest-selftest.c | 66

[PATCH libinput v2 3/5] litest: add mako style touch screen without orientation

This device provides a circular touch point size and and hence lacks orientation. It will be used to test default value handling. --- test/Makefile.am | 1 + test/litest-nexus4-touch-screen.c | 98 +++ test/litest.c | 2 +

[PATCH libinput v2 1/5] add axis_replacement from tablet branch

The optional axis_replacement provides additional replacement values for touch down and touch move litest functions. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- test/litest.c | 59 --- test/litest.h | 16

Re: [PATCH 1/7] litest: add a generic multitouch screen

Hi, On Thu, Jun 11, 2015 at 8:04 AM, Peter Hutterer peter.hutte...@who-t.net wrote: [...] +static struct input_absinfo absinfo[] = { + { ABS_X, 0, 1500, 0, 0, 0 }, + { ABS_Y, 0, 2500, 0, 0, 0 }, out of interest: is his from a real touchscreen? no resolution? Yes and not an

[PATCH 0/7] libinput: add touch point properties to libinput_event_touch

] respectively. I am not entirely shure whether touch major/minor need transformation or scaling in some sense based on the calibration matrix? In the current version those two are just provided the way they were read from the device. regards, Andreas Andreas Pokorny (7): litest: add a generic

[PATCH 3/7] evdev: move scale_axis to evdev.h header

To be used inside pressure and orientation access functions of libinput.c --- src/evdev.c | 11 ++- src/evdev.h | 7 +++ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index af507d6..6f68554 100644 --- a/src/evdev.c +++ b/src/evdev.c @@

[PATCH 1/7] litest: add a generic multitouch screen

Adds a device with various touch related axes and respective device features to litest. And additional routines to simulate pressure orientation and touch major/minor changes. --- test/Makefile.am | 1 + test/litest-touch-screen.c | 100 +

[PATCH 5/7] evdev: Normalize orientation and pressure values

Pressure values will be mapped into the range [0;1] while orientation will be mapped to [-1;1] (or ]-1;1] or [0;1] depending on the how the underlying device configures the axis value ranges). --- src/evdev.c| 6 ++ src/evdev.h| 1 + src/libinput.c | 14 --

[PATCH 7/7] evdev: track which touch point properties are available

This change adds flags to track which property of a touch point is set. With that reasonable default values can be provided when an information is not available. --- src/evdev.c| 29 - src/evdev.h| 10 ++ src/libinput.c | 4 test/touch.c | 42

[PATCH 6/7] litest: add mako style touch screen without orientation

This device provides a circular touch point size and and hence lacks orientation. It will be used to test default value handling. --- test/Makefile.am| 1 + test/litest-mako-touch-screen.c | 93 + test/litest.c | 2 +

[PATCH 2/7] libinput: add orientation and size of touch point and pressure to the API

This change adds four new properties to touch events. These properties are directly forwarded from the evdev interface. --- src/evdev.c| 81 -- src/evdev.h| 4 +++ src/libinput-private.h | 12 ++-- src/libinput.c

[PATCH 4/7] litest: float comparision

--- test/litest.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/test/litest.h b/test/litest.h index 3a08b6a..0d39dd3 100644 --- a/test/litest.h +++ b/test/litest.h @@ -428,4 +428,11 @@ void litest_semi_mt_touch_up(struct litest_device *d, #define ck_assert_notnull(ptr)

Re: [PATCH weston 0/6] ivi-shell proposal

Hi, Overall I like that genivi is now a lot more accessible/visible from the outside. I understand the necessity of dealing with layers on a lower level to make use of the efficient blending of display controllers. But that logic should be only implemented within the compositor. Clients should not

Re: surface buffer cardinality and outputs

from video frames. [1]: http://www.valvesoftware.com/publications/2007/SIGGRAPH2007_AlphaTestedMagnification.pdf Then wayland would still be raster protocol, and would not need resize (or transformation caused) round trips to get perfect glyph display. regards Andreas Pokorny

Re: surface buffer cardinality and outputs

Hi, 2013/3/23 Jerome Glisse j.gli...@gmail.com: How would you transmit transformations that are not representable by a matrix? Nothing says we are limited to matrices, that is also just a special case. Or would you introduce that limitation in the protocol? What kind of transformation are