Re: [PATCH libinput] CI: Hook up GitLab CI

Hi Peter, On Fri, Jun 15, 2018 at 8:59 AM Peter Hutterer wrote: > > From: Benjamin Tissoires > > The main tasks it does is build on a few different distros as well as build > with the various build options to make sure they work.It doesn't (yet) run the > test suite runne

Re: [PATCH libinput] evdev: disable ABS_MT_TOOL_PALM on the Lenovo X1 Carbon 6th gen

labels a touch as palm > has reasons to do so, let's unassume this for this device by disabling that > axis altogether and relying on the touch pressure only. > > https://bugzilla.redhat.com/show_bug.cgi?id=1565692 > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net

[PATCH libinput] udev: drop the version field in device groups

The version field is a per device information. We have no guarantees a touchscreen and a tablet device will share the same version of the firmware (especially if both firmwares are from different vendors). Fixes the touch arbitration for the Dell Canvas 27 Signed-off-by: Benjamin Tissoires

Re: [PATCH libinput] timer: flush the timer funcs if our events come in late

equent input event first. In that case we > can > erroneously trigger or miss out on taps, see wrong palm detection, etc. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > Looks good to me: Reviewed-by: Benjamin Tissoires <benja

Re: [PATCH libinput] tablet: always enable the no-proximity-out quirk on HUION tablets

On Wed, Sep 20, 2017 at 3:40 AM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > And instead disable it when we do get a proximity out. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > --- > This looks good to me: Reviewed-by: Benjamin Tissoires &l

Re: [PATCH libinput 2/2] tablet: support tablet devices without BTN_TOOL_PEN

before going into the users hands. So I think the libinput only fix is the correct one (IMHO). Yay-by: Benjamin Tissoires <benjamin.tissoi...@gmail.com> Cheers, Benjamin > meson.build | 1 + > src/evdev-tablet.c

Re: [PATCH libinput 3/3] touchpad: detect and warn about kernel tracking pointer jumps

nel fix, so add an explanatory page to the docs. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > --- The patch looks good to me: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@gmail.com> (this applies for 2/3 and 1/3 if you expand the commit message of 1/3).

Re: [PATCH libinput 1/3] Make a link to the html docs available as a #define

On Wed, Apr 27, 2016 at 12:36 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > configure.ac | 4 > src/libinput-private.h | 8 > 2 files changed, 12 insertions(+) > > diff --git a/configure.ac

Re: [RFC v3 libinput 1/2] buttonset: Add a "buttonset" interface for button-only devices

Hi Peter, On Tue, Jan 19, 2016 at 5:46 AM, Peter Hutterer wrote: > A generic interface for devices that provide buttons and axes, but don't > control the pointer. This caters for the Pad part of Wacom graphics tablets > but could eventually also deal with remote

Re: [PATCH libinput] touchpad: disable MT for all semi-mt devices

On Tue, Jan 19, 2016 at 1:01 AM, Peter Hutterer wrote: > Synaptics, Elantech and Alps semi-mt devices all have issues with reporting > correct MT data, even the bounding box which semi-mt devices are supposed to > report is wrong. > > Synaptics devices have massive jumps

Re: Weston 1.8.0: touch input using evdev not working

On Fri, Sep 25, 2015 at 2:22 AM, Vikas Patil wrote: > Dear Members, > > I am trying Weston 1.8.0 on i.MX6 with Freescale linux 3.14.28 and seems > that touch input is not working for me. Weston.log show the following > messages. I am not using llibinput backend yet. That's

Re: Weston 1.8.0: touch input using evdev not working

king. Cheers, Benjamin > > Thanks & Regards, > Vikash > > On Fri, Sep 25, 2015 at 4:48 PM, Benjamin Tissoires > <benjamin.tissoi...@gmail.com> wrote: >> >> On Fri, Sep 25, 2015 at 2:22 AM, Vikas Patil <vikasmpa...@gmail.com> >> wrote: >&

Re: [PATCH libinput 4/4] touchpad: reset the motion history during/after a slots-nfake crossover

a massive cursor jump. https://bugs.freedesktop.org/show_bug.cgi?id=91352 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- The series looks good to me: Hallelujah-expressed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com You can also add Reviewed-with-one-eye-only, but I think

Re: [PATCH v3 weston] Introduce wl_relative_pointer interface

On Thu, Jul 16, 2015 at 3:37 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Jul 16, 2015 at 03:23:20PM +0800, Jonas Ådahl wrote: On Thu, Jul 16, 2015 at 03:37:30PM +0900, x414e54 wrote: On Wed, Jul 15, 2015 at 11:55 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed,

Re: [PATCH libinput] touchpad: disable 2fg scrolling on semi-mt touchpads

: https://bugs.freedesktop.org/show_bug.cgi?id=91081 For Synaptics: https://bugs.freedesktop.org/show_bug.cgi?id=91135 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- This patch is Acked-by: Benjamin Tissoires benjamin.tissoi...@gmail.com FWIW, here is the list of semi-mt devices

Re: [PATCH libinput] COYPING: Update boilerplate from MIT X11 to MIT Expat license

-June/022552.html Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Based on: http://lists.freedesktop.org/archives/wayland-devel/2015-June/022467.html it seems ok to do this, so this is: Reviewed-by: Hans de Goede hdego...@redhat.com Yep, same for me: Acked-by: Benjamin Tissoires

[PATCH v2 libinput 2/2] evdev: remove direct checks for INPUT_PROP_POINTING_STICK

was not set. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- Changes in v2: - moved device-dpi to be sure the device is tagged first - thanks to 1/2, now we are sure to have the device tagged before the 2 uses below. src/evdev.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH v2 libinput 1/2] evdev: remove tag_device from evdev_dispatch_interface

when we call each evdev_tag_*, we can also get rid of the device-seat_caps tests. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- new in v2 src/evdev-mt-touchpad.c | 7 +++ src/evdev.c | 32 +--- src/evdev.h | 8 3

Re: [PATCH libinput] evdev: use the udev ID_INPUT_POINTINGSTICK property

On Mon, Jun 1, 2015 at 12:08 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sat, May 30, 2015 at 12:10:28PM +0200, Hans de Goede wrote: Hi, On 29-05-15 17:06, Benjamin Tissoires wrote: On 05/29/2015 03:31 AM, Hans de Goede wrote: Hi, On 29-05-15 03:28, Peter Hutterer wrote

Re: [PATCH libinput] evdev: use the udev ID_INPUT_POINTINGSTICK property

to me (it's already push, so that does not matter that much). However, for completeness, if we want to be able to override the INPUT_PROP_POINTING_STICK property, we also need the following patch: From 9573bfb574a74e2eea89a9227aaf67c1c9403983 Mon Sep 17 00:00:00 2001 From: Benjamin Tissoires

Re: [PATCH libinput 04/11] touchpad: only check keyboards for disable-while-typing

the Pixel was not able to get the disable while typing feature and this was because one of the power button input node was catching the dwt feature before the keyboard. The whole series is Tested-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin src/evdev-mt-touchpad.c | 22

Re: [PATCH libinput 7/7] touchpad: sync the initial touch state

jumps from 0/y or x/0 to the real coordinates. For touchpads with distance support this is a real issue since the default value for a touch distance is 0. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- The series is: Tested-by: Benjamin Tissoires benjamin.tissoi...@gmail.com

[PATCH v2] touchpad: add support for per-finger hovering information

When the device supports true hovering, it reports this information through ABS_MT_DISTANCE. When this axis is available, we should rely on it to (un)hover the touches as BTN_TOUCH is most of the time unreliable (generated by the mouse emulation in the kernel). Signed-off-by: Benjamin Tissoires

Re: [PATCH libinput 3/3] touchpad: add support for per-finger hovering information

On Wed, May 6, 2015 at 5:33 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, May 06, 2015 at 10:45:20AM -0400, Benjamin Tissoires wrote: On Wed, May 6, 2015 at 1:08 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Apr 30, 2015 at 04:30:25PM -0400, Benjamin Tissoires wrote

[PATCH libinput 0/3] Support of true hovering

hovering finger of the session is seen as a touch (annoying but it disapears as soon as it touches once the sensor). I am sending this series now because the 2 previous points are not mandatory for current users. Cheers, Benjamin Benjamin Tissoires (3): test: bcm5974: down should be marked

[PATCH libinput 1/3] test: bcm5974: down should be marked as static

From: Benjamin Tissoires benjamin.tissoi...@redhat.com Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- test/litest-bcm5974.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/litest-bcm5974.c b/test/litest-bcm5974.c index 035bed2..ddff038 100644

[PATCH libinput v5] evdev: use a different filter for low resolution touchpad on the Lenovo X230

a factor to minimize those jumps at low speed, and try keeping the same feeling as regular touchpads at high speed. It still feels slower but it is usable at least Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- Hi, So this will hopefully be validated and pulled upstream

Re: [PATCH libinput] evdev: add support for LIBINPUT_MODEL_* udev tags

-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH libinput v4 1/2] evdev: use a different filter for low resolution touchpad on the Lenovo X230

a three segments acceleration profile to sort this out: - slow down a lot when speed is below 0.8 + threshold - use a somewhat half acceleration when speed is in ]0.8 + threshold .. 2.0] - use the same acceleration than regular touchpads if the speed is greater than 2.0 Signed-off-by: Benjamin

[PATCH libinput v4 0/2] Fix Lenovo X230 series touchpad

. Nevertheless, I feel that these settings should be OK. Cheers, Benjamin Benjamin Tissoires (2): evdev: use a different filter for low resolution touchpad on the Lenovo X230 udev: add a custom udev rule for X230 touchpads doc/device-configuration-via-udev.dox |9 +++ src/evdev-mt

[PATCH libinput v4 2/2] udev: add a custom udev rule for X230 touchpads

X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to apply a different acceleration profile. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- changes in v4: - renamed the file as 90-libinput-model

Re: [PATCH v3 0/4] Fix Lenovo X230 series touchpad

Hi Vasily, On Fri, Apr 17, 2015 at 2:47 AM, Vasily Khoruzhick anars...@gmail.com wrote: Hi Benjamin, On Thu, Apr 16, 2015 at 9:41 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: So here is a v2 (well v3 to keep things incrementing) of the x230 touchpad series. The touchpad

[PATCH v3 4/4] evdev: Fix reported resolution of Lenovo X230 touchpads

The Lenovo X230 advertise a vertical resolution of 136, which gives a size of 31 mm. The actual size of the touchpad is 40mm, so override the resolution to 100. /!\ This is a temporary fix. The proper fix should go in hwdb. /!\ Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com

[PATCH v3 2/4] evdev: use a different filter for low resolution touchpad on the Lenovo X230

a factor to minimize those jumps at low speed and try keeping the same feeling as regular touchpads at high speed. It still feels slower but it is usable at least Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to v1

[PATCH v3 1/4] filter: break out accel_profile_linear from pointer_accel_profile_linear

No functional code. Allows to reuse the linear filtering in other acceleration profiles. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- no changes since v1 src/filter.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/filter.c

[PATCH v3 0/4] Fix Lenovo X230 series touchpad

it. Maybe other users would be more picky and prefer to have it. Cheers, Benjamin Benjamin Tissoires (4): filter: break out accel_profile_linear from pointer_accel_profile_linear evdev: use a different filter for low resolution touchpad on the Lenovo X230 udev: add a custom udev rule

Re: [PATCH v3 0/4] Fix Lenovo X230 series touchpad

Grmbl... this series is for libinput, sorry for the missing subject prefix Benjamin On Thu, Apr 16, 2015 at 2:41 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: So here is a v2 (well v3 to keep things incrementing) of the x230 touchpad series. The touchpad seems almost as fast

[PATCH v3 3/4] udev: add a custom udev rule for X230 touchpads

X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to apply a different acceleration profile. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- Changes to v1: - more generic rule (in the file name and the way it is handled) No changes to v2. udev/99-libinput

Re: [PATCH libinput 0/3] Fix Lenovo X230 series touchpad

to send the various parameters you set, and we will see if we can include them (after comparison with other touchpads :-P). Cheers, Benjamin -- Giulio 2015-04-09 20:30 GMT+03:00 Benjamin Tissoires benjamin.tissoi...@gmail.com: Hi, Here is a series to try making the touchpad found

Re: [PATCH libinput 3/3] udev: add a custom udev rule for X230 touchpads

On Thu, Apr 9, 2015 at 11:45 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Apr 09, 2015 at 01:30:39PM -0400, Benjamin Tissoires wrote: X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to apply a different acceleration profile. Signed-off-by: Benjamin

[PATCH libinput 2/3] evdev: use a different filter for low resolution touchpad on the Lenovo X230

a factor to minimize those jumps at low speed and try keeping the same feeling as regular touchpads at high speed. It still feels slower but it is usable at least Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- doc/device-configuration-via-udev.dox |9 + src/evdev-mt

Re: [PATCH libinput 0/3] Fix Lenovo X230 series touchpad

On Thu, Apr 9, 2015 at 2:17 PM, Giulio Camuffo giuliocamu...@gmail.com wrote: 2015-04-09 20:30 GMT+03:00 Benjamin Tissoires benjamin.tissoi...@gmail.com: Hi, Here is a series to try making the touchpad found on the Lenovo X230 working. This touchpad has a very bad hardware resolution

[PATCH libinput 1/3] filter: break out accel_profile_linear from pointer_accel_profile_linear

No functional change. Allows to reuse the linear filtering in other acceleration profiles. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- src/filter.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/filter.c b/src/filter.c

[PATCH libinput 3/3] udev: add a custom udev rule for X230 touchpads

X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to apply a different acceleration profile. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- udev/99-x230.rules | 14 ++ udev/Makefile.am |4 +++- 2 files changed, 17 insertions(+), 1

[PATCH libinput 4/3] evdev: Fix reported resolution of Lenovo X230 touchpads

The Lenovo X230 advertise a vertical resolution of 136, which gives a size of 31 mm. The actual size of the touchpad is 40mm, so override the resolution to 100. /!\ This is a temporary fix. The proper fix should go in hwdb. /!\ Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com

[PATCH libinput 0/3] Fix Lenovo X230 series touchpad

better, but that's maybe just me. It's up to the libinput maintainer to decide to take it or not (thus the 4/3). Final note. I tested it on a X230t (t for tablet). I'd like to get some feedbacks from the non-tablet users too. Cheers, Benjamin Benjamin Tissoires (4): filter: break out

Re: [PATCH libinput] evdev: Do not mark tablet touchscreens as tablets

--- Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin For Peter's tablet-support branch. src/evdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 19226fe..c57ac4f 100644 --- a/src/evdev.c +++ b/src

Re: [PATCH libinput 1/2] tablet: rely on libwacom for the list of axis capabilities

, - LIBINPUT_TABLET_AXIS_REL_WHEEL); We are missing the REL_WHEEL axis with this change. But this should be addressed in libwacom. For the series, Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin - break; - default: - break

Re: [PATCH libinput 1/2] tablet: copy distance axis for the mouse/lens cursor devices

On Wed, Mar 4, 2015 at 11:25 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- For the series: Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com src/evdev-tablet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src

Re: [PATCH v2 libinput] tablet: sync tools already in proximity at startup

On Mon, Mar 2, 2015 at 10:29 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Mon, Mar 2, 2015 at 7:59 PM, Peter Hutterer peter.hutte...@who-t.net wrote: If a tool is in proximity when we init, send a proximity event immediately. This is only partially reliable due

Re: [PATCH v2 libinput] tablet: sync tools already in proximity at startup

On Mon, Mar 2, 2015 at 7:59 PM, Peter Hutterer peter.hutte...@who-t.net wrote: If a tool is in proximity when we init, send a proximity event immediately. This is only partially reliable due to the current kernel behavior: * if the tool comes into proximity when there is no evdev client, the

Re: [PATCH libinput 19/26] tablet: support z-rotation for the mouse/lens tool

On Mon, Mar 2, 2015 at 1:53 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Feb 26, 2015 at 04:20:49PM -0500, Benjamin Tissoires wrote: On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Needs to be calculated from the x/y tilt values, the mouse has

Re: [PATCH v2 libinput 25/26] tablet: add libinput_tablet_get_axis_delta()

On Wed, Feb 25, 2015 at 11:33 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to v2: - delta was stored in tablet-axes[a], causing a wrong axis_value and a wrong axis_delta. which the test didn' catch because it didn't

Re: [PATCH libinput] evdev: ignore tablet pad devices explicitly

-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Yep, Reviewed-and-tested-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin ___ wayland-devel mailing list wayland-devel

Re: [PATCH libinput 19/26] tablet: support z-rotation for the mouse/lens tool

On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Needs to be calculated from the x/y tilt values, the mouse has a fixed offset of 175 degrees counterclockwise. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 88

Re: [PATCH libinput] tablet: ignore tools already in proximity at startup

On Thu, Feb 26, 2015 at 12:05 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Require a tool to be moved into proximity before we handle any events from it. This requires the user to lift the tool for first use but a tool that's already on the tablet on init is likely to send garbage anyway

Re: [PATCH libinput 03/26] test: fix double comparison macros

On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: args needs to be within () to ensure correct calculation Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [PATCH libinput 11/26] tablet: use libwacom to identify tablets for left-handedness

On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: A tablet hotplug event is rare and not a time-critical event, so we load the database on tablet init and throw it away again. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- configure.ac

Re: [PATCH libinput 18/26] tablet: rely on libwacom to give us the right tablet axes

On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 50 +- 1 file changed, 33 insertions(+), 17 deletions(-) diff --git

Re: [PATCH libinput 08/26] tablet: document what the tool type means

On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: It's a rough guide only, but still precise enough to make some decisions. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 32 +++- 1 file changed, 23

Re: [PATCH libinput 15/26] tablet: expand the button mask to allow for BTN_LEFT, RIGHT, MIDDLE

On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Expand the mask to fit KEY_CNT buttons, the mouse has LMR buttons and a few more, trying to squash the range is more error-prone than having the full key range instead. Signed-off-by: Peter Hutterer

Re: [PATCH libinput 16/26] tablet: add support for libinput_tool_has_button

On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: libwacom can tell us how many buttons we have per stylus, so we map those into BTN_STYLUS and BTN_STYLUS2. BTN_TOUCH is set on all styli. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---

Re: [PATCH libinput 23/26] tools: only print the tablet axes we have on the tool

On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: This doesn't really have an effect, since we don't set the per-tool axes correctly yet. Actually we do now. :) Cheers, Benjamin Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c |

Re: [PATCH v2 libinput 00/26] tablet: support the remaining tools

On Tue, Feb 24, 2015 at 11:16 AM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi Peter, On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer peter.hutte...@who-t.net wrote: This is a v2 of the patchset here [snipped] Again, I'll try to review the patches one by one. So, I am starving

Re: [PATCH libinput 00/15] tablet: support the remaining tools

Hi Peter, On Wed, Feb 18, 2015 at 12:45 AM, Peter Hutterer peter.hutte...@who-t.net wrote: This patchset adds the remaining tools to the tablet branch (at least for Wacom tools). The notable additions are: * rotation support for mouse/lens cursor * rotation support for the artpen * 'wheel'

Re: [PATCH libinput] evdev: check the first parent of the event node for ID_INPUT tags

-off-by: Peter Hutterer peter.hutte...@who-t.net --- Thanks for the patch. Tested-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin src/evdev.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 11fa89b

Re: [PATCH libinput 1/3] tools: print the device group in event-debug

On Tue, Feb 10, 2015 at 1:50 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com tools/event-debug.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions

Re: [PATCH v2 libinput 2/3] Add a udev bits to assign LIBINPUT_DEVICE_GROUP

On Tue, Feb 10, 2015 at 8:31 PM, Peter Hutterer peter.hutte...@who-t.net wrote: The easiest way to get a device group is by looking at the phys path of the input device (which looks like usb-:00:14.0-1/input1) and dropping the /inputX bit. The rest is the same for devices that belong

Re: [PATCH libinput 3/3] Use LIBINPUT_DEVICE_GROUP from udev as group identifier

On Tue, Feb 10, 2015 at 1:50 AM, Peter Hutterer peter.hutte...@who-t.net wrote: From: Benjamin Tissoires benjamin.tissoi...@gmail.com Store it as identifier in the device group, any two devices that have a the same non-NULL identifier share the group. Signed-off-by: Peter Hutterer

Re: [PATCH libinput] tablet: drop LIBINPUT_TABLET_AXIS_NONE from the API

(or FIRST/LAST), there is not much we can do. With or without this, the patch is still Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin This one is for the tablet-support branch. src/evdev-tablet.c | 8 +--- src/evdev-tablet.h | 8 +--- src/libinput

Re: [PATCH libinput 2/3] Add a rules file to assign LIBINPUT_DEVICE_GROUP

Hi Peter, On Tue, Feb 10, 2015 at 1:50 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Ideally we could just take ATTRS{phys} but we can't select substrings to drop into ENV so we re-assemble it manually. Eventually this will likely end up in a RUN callout, but for now this will do.

Re: [PATCH libinput 2/2] evdev: switch to using udev's device tagging system

patches are Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin src/evdev.c | 116 ++-- 1 file changed, 34 insertions(+), 82 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 1fcda58..057b543 100644

Re: [PATCH libinput 0/24] Tablet support

On Thu, May 22, 2014 at 1:17 AM, Chandler Paul thatsly...@gmail.com wrote: Hi! Sorry this took so long to write, I've been spending a lot of my time recently trying to understand the libinput code and all of that good stuff, and I wanted to make sure I had a decent understanding of it before I

Re: [PATCH libinput 0/24] Tablet support

Hi Carlos, [Adding a few people to the conversation] I am working a little bit on the wacom.ko kernel driver and I can give you some hints on the oddness around the events. On Mon, Apr 21, 2014 at 1:11 PM, Carlos Garnacho carl...@gnome.org wrote: Hey there!, Here's a few patches to have

[PATCH libinput] evdev: fix device_transform_ functions

which is 7 times bigger than li_fixed_t max. To keep the precision of the sensor, first compute the uniformized coordinate (in range 0 .. 1.0) of the touch point, then multiply it by the screen dimension, and revert it to a li_fixed_t. Signed-off-by: Benjamin Tissoires benjamin.tissoi

Re: [PATCH]: mtdev could be disabled at configuration

On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 7 Jun 2013 12:11:14 +0200 Marc Chalain marc.chal...@gmail.com wrote: mtdev is not necessary on some device (desktop or set-top-box). For embedded solution the minimum of dependencies is required. configure

Re: [PATCH]: mtdev could be disabled at configuration

On Tue, Jun 11, 2013 at 9:41 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Tue, 11 Jun 2013 09:01:48 +0200 Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 7 Jun 2013 12:11:14 +0200 Marc Chalain

Re: [PATCH]: mtdev could be disabled at configuration

On Tue, Jun 11, 2013 at 12:40 PM, Pekka Paalanen ppaala...@gmail.com wrote: On Tue, 11 Jun 2013 12:10:05 +0200 Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Tue, Jun 11, 2013 at 9:41 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Tue, 11 Jun 2013 09:01:48 +0200 Benjamin