Re: Possible to run an xorg desktop in Wayland?

Hello, Maybe you are interrested in [1], but I do not maintain it for the moment. It' Xnest for wayland, it's mostly based on Xwayland code, but provide a root window. Best regards. [1] https://github.com/gschwind/xwlnest Le vendredi 21 juillet 2017 à 10:30 +0300, Pekka Paalanen a écrit : > On

Re: [RFC wayland-protocols] Color management protocol

Hello Pekka, Your idea is mostly correct, but I have few comment. Some element of context: on my side I do not do photo editing at all but I calibrate and profile my monitor often to get a similar visual experience from a computer to another. On 13/01/2017 17:03, Pekka Paalanen wrote: On

Re: [RFC wayland-protocols] Color management protocol

Hello Graeme Gill I read many comments on this topic including yours, and I agree with you about some points in particular about the calibration and profiling procedure, but I very puzzled by your position about some points. It's look like you hate display managers[1] because they are not

Re: [RFC wayland-protocols] Color management protocol

Hello, It's very difficult to contribute to this discussion, but here is my delta contribution. I agree with the following proposal with comment bellow. On 19/12/2016 09:27, Carsten Haitzler (The Rasterman) wrote: On Mon, 19 Dec 2016 17:01:50 +1100 Graeme Gill said:

Re: Monitor profiling (Re: [RFC wayland-protocols] Color management protocol)

On 13/01/2017 15:17, Pekka Paalanen wrote: the calibrating or monitor profiling process (are these the same thing?) As far as I know, no they are different, calibrating a monitor is the attempt to set cLUT and monitor setting to be close to a given target, often a given color space with a

Re: [PATCH RFC] Add tiled states per edge

etry is not required. "MUST" have a strong meaning within specification. Another thing is "Resizing is initiated by the compositor only" is just useless, the compositor is free to ignore move/resize request from clients. Taken all comment above you get :

Re: [PATCH RFC] Add tiled states per edge

elling > clients whether to draw the maximize icon or not). > >> >> To me, these should be compositor-specific actions, rather than something >> clients are aware of. IMO, tiling is also “the compositor knows better”, and >> thus the client should not initiate actions. >

[PATCH weston v3 3/3] compositor-x11: remove manual mouse button grab/ungrab

-by: Benoit Gschwind <gschw...@gnu-log.net> --- libweston/compositor-x11.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/libweston/compositor-x11.c b/libweston/compositor-x11.c index b6acccd..5d063b5 100644 --- a/libweston/compositor-x11.c

[PATCH weston v3 2/3] compositor-x11: remove redundant state arg of x11_backend_deliver_button_event

The "state" variable in x11_backend_deliver_button_event is basically the same as (event->response_type == XCB_BUTTON_PRESS), thus update the code to use the last one. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- libweston/compositor-x11.c | 21 ++

[PATCH weston v3 0/3] compositor-x11: improving handling of mouse events

v3: - change the patch log of patch 3 v2: - fix assert to comply weston coding style. v1: - add some sanity checking, - remove redundant viarable, - use a better X11 passive grab Benoit Gschwind (3): compositor-x11: add assert to avoid misuse of x11_backend_deliver_button_event

[PATCH weston v3 1/3] compositor-x11: add assert to avoid misuse of x11_backend_deliver_button_event

The x11_backend_deliver_button_event can be called with any xcb_generic_event. The assert check if the call is done with the expected events. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- libweston/compositor-x11.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib

Re: [PATCH weston v2 0/2] Separate Weston from libweston

, but that doesn't matter. Tested-by: Benoit Gschwind <gschw...@gnu-log.net> Ack-by: Benoit Gschwind <gschw...@gnu-log.net> Best regards. On 22/06/2016 14:28, Quentin Glidic wrote: > On 22/06/2016 13:44, Pekka Paalanen wrote: >> On Thu, 9 Jun 2016 15:20:35 +0300 >> Pekka Paalanen

Re: How to create client in child thread

Hello, The reply from Pekka is about compositor using a client to make the rendering, but I not sure this is what you asking for. Are you talking about building a compositor ? It look like you are making a wayland client that try to delegate the drawing to a thread. Is it what you want to do ?

Re: [PATCH wayland-protocols v3 7/7] xdg-shell: Introduce xdg_positioner

t; + > > > > @@ -724,7 +953,7 @@ > button press, key press, or touch down event. The serial number of the > event should be passed as 'serial'. > > - The parent of a grabbing popup must either be a xdg_toplevel surface

Re: [PATCH wayland-protocols v3 6/7] xdg-shell: Make xdg_popup non-grabbing by default

ts. Thus yes in both case the client can grab mouse pointer indefinitely if the compositor doesn't provide a "force cancel grab" mechanism like a bind to ESC key. The draft is simple to explain and simple to implement. Best regards. -- Benoit Gschwind

Re: [PATCH wayland-protocols v3 5/7] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

Hello Jonas, Fine for me. Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> Best regards On 26/05/2016 06:32, Jonas Ådahl wrote: > The reason for using wl_surface before was that xdg_popup and > xdg_surface (now xdg_toplevel) had no common interface other than > wl_sur

Re: [PATCH wayland-protocols v3 4/7] xdg-shell: Improve error enum formatting some

Hello Jonas, This one do what it tell. Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> Best regards. On 26/05/2016 06:32, Jonas Ådahl wrote: > The long lines stood out, break them by putting the summary on its own > line. > > Signed-off-by: Jonas Ådahl <jad...@

Re: [PATCH wayland-protocols v3 2/7] xdg-shell: Put xdg_shell events after requests

ld be interpreted, and possibly how it should be > + drawn. > + > + Clients must send an ack_configure in response to this event. See > + xdg_surface.configure and xdg_surface.ack_configure for details. > + > + > + > + > + > + > + > > > The close event is sent by the compositor when the user > Best regards -- Benoit Gschwind ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v3 1/7] xdg-shell: Turn xdg_surface into a generic base interface

Hello Jonas, On 08/06/2016 03:18, Jonas Ådahl wrote: > On Wed, Jun 08, 2016 at 12:37:01AM +0200, Benoit Gschwind wrote: >> Hello, >> >> This proposal look good, few optional comments following. >> >> On 26/05/2016 06:32, Jonas Ådahl wrote: >>> Split ou

Re: [PATCH wayland-protocols v3 1/7] xdg-shell: Turn xdg_surface into a generic base interface

e width and height arguments are in window geometry coordinates. > - See set_window_geometry. > + See xdg_surface.set_window_geometry. > > Values set in this way are double-buffered. They will get applied > on the next commit. > @@ -488,7 +543,7 @@ >

Re: [PATCH] xdg-shell: add draw states for xdg_surface

tate to be a /semantic state/: see activated state above. >> I think we should think about window state once more :D > > I reckon the current states as defined in xdg-shell are commonly understood, > established and accepted between environments,

Re: [PATCH] xdg-shell: add draw states for xdg_surface

a new list, it's better isn't it ?" This is my opinion. Best regards. On 07/06/2016 10:59, Jonas Ådahl wrote: > On Tue, Jun 07, 2016 at 10:47:13AM +0200, Benoit Gschwind wrote: >> Hello Olivier >> >> On 07/06/2016 10:30, Olivier Fourdan wrote: >>> H

Re: [PATCH] xdg-shell: add draw states for xdg_surface

to draw a line between draw states and "behaviors" states, they are linked. I think we should think about window state once more :D > Cheers, > Olivier > ___ > wayland-devel mailing list > wayland-devel@l

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello Matthias, I agree the two reply from Jonas, and Olivier. I just add to Olivier comment, that even we tried to remove MWM hints (i.e. they do not belong any up-to-date standards), they are still used by up-to-date software and implemented by popular WMs. This use case show that (1) those

[PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

sprintf can overflow the fixed length title which is char[32]. This patch change title to dynamically allocated char array using asprintf or strdup. If one of them fail we leave returning NULL to indicate the failure. Signed-of-by: Benoit Gschwind<gschw...@gnu-log.net> --- v3:

[PATCH v2] compositor-x11: fix title overflow in x11_backend_create_output

sprintf can overflow the fixed length title which is char[32]. This patch change title to dynamically allocated char array using asprintf or strdup. If one of them fail we leave returning NULL to indicate the failure. Signed-of-by: Benoit Gschwind<gschw...@gnu-log.net> --- src/compositor

Re: [PATCH v1] compositor-x11: fix title overflow in x11_backend_create_output

Hello Yong, Thanks for the review. On 05/06/2016 17:47, Yong Bakos wrote: > Hi Benoit, > Other than the comments inline below, this patch is > Reviewed-by: Yong Bakos <yba...@humanoriented.com> > Tested-by: Yong Bakos <yba...@humanoriented.com> > > On Jun 4, 201

[PATCH v1] compositor-x11: fix title overflow in x11_backend_create_output

--- src/compositor-x11.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 629b5f3..a518820 100644 --- a/src/compositor-x11.c +++ b/src/compositor-x11.c @@ -782,7 +782,7 @@

Re: [PATCH RFC] xdg-shell: Add tiled states

Hello, For reference this discussion was split from [1]. Note also I did this comment in the thread [2]. And I reiterate that we are making : - _NET_SUPPORTED [3], - _NET_WM_ALLOWED_ACTIONS [4] - and _NET_WM_STATE [5]. So why not drafting from the existing and improve it ? [1]

Re: [PATCH RFC] xdg-shell: Add tiled states

Hello Jonas, The things I see for maximized vs. tilling: - tilling window does not need a unmaximize button, because they are not maximized; - tilling window may want to switch maximized and draw the corresponding button; - tilling window may not need close button to be drawn. We will quickly

Re: [PATCH] xdg-shell: add draw states for xdg_surface

separating them does not improve the situation. Keeping them together just avoid long discussion on which side they must go state or drawing state? On 31/05/2016 23:04, Derek Foreman wrote: > On 31/05/16 02:31 PM, Benoit Gschwind wrote: >> Hello mike, >> >> Thank for your

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello mike, Thank for your clarification, I try to summarize the issue/need: A compositor may want to draw a client without the shadow. In particular if the window is integrated to a GUI component, I can imagine tilling. Taking your issue, the drawing state look very similar to the state flags.

Re: [PATCH] xdg-shell: add draw states for xdg_surface

prefer the EWMH > approach to the MWM hints ^_~ > > Back to the topic... > > - Original Message - >> On Tue, May 31, 2016 at 10:31:28AM +0200, Benoit Gschwind wrote: >>> Hello Jonas, Mike and Olivier, >>> >>> [...] >>>> I see nothing

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On 31/05/2016 10:53, Jonas Ådahl wrote: > On Tue, May 31, 2016 at 10:31:28AM +0200, Benoit Gschwind wrote: >> Hello Jonas, Mike and Olivier, >> >> On 30/05/2016 15:09, Olivier Fourdan wrote: >>> Hi Jonas, >>> >>> - Original Message - >&g

Re: [PATCH] xdg-shell: add draw states for xdg_surface

a monitor in a > multi-monitor setup for example (so we don't have shadows crossing monitors > for example) - Maybe it's just overkill, dunno. > > We could also consider "no border", again, per edge as well. Or not. > This last comments look to overlap with some already existing feature within the protocol, I think about the input shape. Also, because the issue is not well described the discussion overflow to severals other issues. > Cheers, > Olivier > > > ___ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel > Best regards -- Benoit Gschwind ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Protocol for window previews/thumbnails

Hello Olivier, You should keep an eye on libweston :) Best regards Le 20/05/2016 10:33, Olivier Fourdan a écrit : > Hi, > > On 12 May 2016 at 00:35, ade low wrote: >> [...] >> It is important that it is a standard, cross-compositor protocol. For >> example, if I am using

Re: [PATCH weston 3/6] Move the functions launching clients to main.c

Hello Giulio, With this patch, and mine to fix MODULEDIR of patch #2, this patch does not build due to incomplete type: src/screenshooter.c:46:24: error: field 'process' has incomplete type struct weston_process process; The patch look fine, if I ignore this building error, I also saw a lot

Re: [PATCH weston 2/6] Split the modules and include files between weston and libweston

xt paragraph) shall be included in all copies or substantial > + * portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS > + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN > + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > + * SOFTWARE. > + */ > + > +#ifndef WESTON_H > +#define WESTON_H > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +void * > +load_weston_module(const char *name, const char *entrypoint); > + > +#ifdef __cplusplus > +} > +#endif > + > +#endif > diff --git a/src/weston.pc.in b/src/weston.pc.in > index c560eb3..f2ffc9e 100644 > --- a/src/weston.pc.in > +++ b/src/weston.pc.in > @@ -9,4 +9,4 @@ Name: Weston Plugin API > Description: Header files for Weston plugin development > Version: @WESTON_VERSION@ > Requires.private: wayland-server pixman-1 xkbcommon > -Cflags: -I${includedir} > +Cflags: -I${includedir}/weston > -I{includedir}/libweston-@LIBWESTON_ABI_VERSION@ > Best regard -- Benoit Gschwind ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston v2 1/3] compositor-x11: add assert to avoid misuse of x11_backend_deliver_button_event

The x11_backend_deliver_button_event can be called with any xcb_generic_event. The assert check if the call is done with the expected events. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-x11.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compositor

[PATCH weston v2 3/3] compositor-x11: remove manual mouse button grab/ungrab

, that automatically grab buttons as soon as they occur. The passive grab include an automatic ungrab when all mouse button are released. This probably fix some mysterious bugs. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-x11.c | 27 +-- 1 file chang

[PATCH weston v2 2/3] compositor-x11: remove redundant state arg of x11_backend_deliver_button_event

The "state" variable in x11_backend_deliver_button_event is basically the same as (event->response_type == XCB_BUTTON_PRESS), thus update the code to use the last one. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-x11.c | 21 ++---

[PATCH weston v2 0/3] compositor-x11: improving handling of mouse events

v2: - fix assert to comply weston coding style. v1: - add some sanity checking, - remove redundant viarable, - use a better X11 passive grab Benoit Gschwind (3): compositor-x11: add assert to avoid misuse of x11_backend_deliver_button_event compositor-x11: remove redundant state arg

Re: [PATCH weston v1 3/3] compositor-x11: remove manual mouse button grab/ungrab

being > passed to another client. > > > On Fri, May 13, 2016 at 4:34 AM, Benoit Gschwind <gschw...@gnu-log.net > <mailto:gschw...@gnu-log.net>> wrote: > > In current compositor-x11, the mouse buttons are grabbed and ungrabbed > manually that may prod

Re: [PATCH weston] eventdemo: use %u for uint32_t printing

Hello Pekka, Look sane. Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> On 13/05/2016 13:38, Pekka Paalanen wrote: > From: Pekka Paalanen <pekka.paala...@collabora.co.uk> > > I was confused why timestamp was printed negative. This fixes it, and > others whil

[PATCH weston v1 1/3] compositor-x11: add assert to avoid misuse of x11_backend_deliver_button_event

The x11_backend_deliver_button_event can be called with any xcb_generic_event. The assert check if the call is done with the expected events. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-x11.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compositor

Re: [PATCH weston 2/3] eventdemo: use zalloc

Hello Pekka, Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> Tested-by: Benoit Gschwind <gschw...@gnu-log.net> just in case, If you apply my suggestion for the previous patch, this patch may be useless. Best regards, Benoit Gschwind On 10/05/2016 16:11, Pekka Paalanen wrote: &

Re: [PATCH weston 3/3] eventdemo: do not print axis events if not requested

Hello Pekka, Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> Tested-by: Benoit Gschwind <gschw...@gnu-log.net> That surprising that the log_axis was not used here :) Best regards, Benoit Gschwind On 10/05/2016 16:11, Pekka Paalanen wrote: > From: Pekka Paalan

Re: [PATCH weston 1/3] eventdemo: do not print pointer frames alone

Hello Pekka, as-is you get my: Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> Tested-by: Benoit Gschwind <gschw...@gnu-log.net> But I have comments that may be worth to read :) On 10/05/2016 16:11, Pekka Paalanen wrote: > From: Pekka Paalanen <pekka.paala...@collabora

Re: [PATCH] Build a libweston library

ng libweston implementation detail to weston-0. Outside this comments the patch is working and is making what he claim. I did not already tested to create a compositor from the library. But it's probably something we can tackle later. Tested-by: Benoit Gschwind <gschw...@gnu-log.net> Best reg

[PATCH weston v4 00/14] compositor-wayland: refactor the configuration API

and variables as suggested by Pekka Benoit Gschwind (14): compositor-wayland: fix spacing and lines wraping compositor-wayland: fix too long lines compositor-wayland: rename wayland_output_init_from_config compositor-wayland: rename misleading output arg of weston_wayland_output_config_init

[PATCH weston v4 13/14] compositor-wayland: rename new_config arg of weston_wayland_backend_config_add_new_output

Rename new_config to config to follow legacy naming scheme. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main.c b/src/main.c index 285a10d..d0a962f 100644 --- a/src/main.c +++

[PATCH weston v4 12/14] compositor-wayland: rename new_config arg of weston_wayland_backend_config_release

Rename new_config to config to follow legacy naming scheme. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main.c b/src/main.c index e28a576..285a10d 100644 --- a/src/main.c +++

[PATCH weston v4 01/14] compositor-wayland: fix spacing and lines wraping

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index d0d1082..9351687 100644 --- a/src/compositor-wayland.c +++

[PATCH weston v4 11/14] compositor-wayland: rename out_config arg of load_wayland_backend_config

Rename the out_config arg of load_wayland_backend_config to follow legacy naming convention. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/main.c

[PATCH weston v4 08/14] compositor-wayland: replace and remove new_config in load_wayland_backend_config

Remove the unseless intermediate variable new_config in the function load_wayland_backend_config, replacing it by the existing variable out_config. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 44 1 file chang

[PATCH weston v4 04/14] compositor-wayland: rename misleading output arg of weston_wayland_output_config_init

Rename the misleading output argument to output_config in the weston_wayland_output_config_init function. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff

[PATCH weston v4 05/14] compositor-wayland: add versionning to config structure

The patch use temporary code that prepare the patch: "compositor-wayland: move configuration parsing to weston main.c" Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 29 ++--- src/compositor-wayland.h | 3 +++ 2 f

[PATCH weston v4 10/14] compositor-wayland: rename wayland_backend_config_release function

Rename the wayland_backend_config_release function to weston_wayland_backend_config_release to follow legacy naming scheme. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main.c b/src/main.c

[PATCH weston v4 09/14] compositor-wayland: rename wayland_backend_config_add_new_output function

Rename wayland_backend_config_add_new_output to weston_wayland_backend_config_add_new_output to follow the legacy naming scheme. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main.c

[PATCH weston v4 02/14] compositor-wayland: fix too long lines

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 9351687..4799f90 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-way

Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

Hello Bryce, Ok I can live with this patches ;) Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> On 05/05/2016 00:24, Bryce Harrington wrote: > On Sat, Apr 30, 2016 at 11:41:15AM +0200, Benoit Gschwind wrote: >> Hello Bryce, >> >> I think my comments on previous

Re: [PATCH weston v2 9/9] wayland-backend: move all parsing functions to weston

Hello Pekka, I submitted a patches set (v3) to address all comments. Best regards. On 04/05/2016 15:41, Pekka Paalanen wrote: > On Thu, 28 Apr 2016 20:33:16 +0200 > Benoit Gschwind <gschw...@gnu-log.net> wrote: > >> Move all parsing functions from the wayland ba

[PATCH weston v3 00/17] compositor-wayland: refactor the configuration API

v3: - rebase to master - heavy patches spliting to help review as suggested by Pekka - fix typo. - rename functions and variables as suggested by Pekka Benoit Gschwind (17): compositor-wayland: fix misc. typo compositor-wayland: add versionning to config structure compositor-wayland

[PATCH weston v3 06/17] compositor-wayland: refactor load_wayland_backend

Rename compositor to c in load_wayland_backend function. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main.c b/src/main.c index 92b7ac2..a84bdeb 100644 --- a/src/main.c +++ b/src/

[PATCH weston v3 05/17] compositor-wayland: move configuration parsing to main.c

functions. Update the code to properly load the backend as others backends. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 215 - src/main.c | 223 ++- 2

[PATCH weston v3 07/17] compositor-wayland: refactor load_wayland_backend

Rename config to wc in load_wayland_backend function. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main.c b/src/main.c index a84bdeb..2ff8cd7 100644 --- a/src/main.c +++ b/src/main.c @@ -

[PATCH weston v3 12/17] compositor-wayland: refactor wayland_backend_create

Rename new_config to config in wayland_backend_create function. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 1

[PATCH weston v3 01/17] compositor-wayland: fix misc. typo

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index d0d1082..83f31de 100644 --- a/src/compositor-wayland.c +++ b/src/comp

[PATCH weston v3 15/17] compositor-wayland: rename wayland_backend_config_release

Rename wayland_backend_config_release to weston_wayland_backend_config_release. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main.c b/src/main.c index 5b8eb80..adaebf7 100644 ---

[PATCH weston v3 13/17] compositor-wayland: refactor backend_init

Rename unused variable config to wc in backend_init function. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 133bd37..67d20d0

[PATCH weston v3 17/17] compositor-wayland: rename wayland_backend_config_add_new_output

Rename wayland_backend_config_add_new_output to weston_wayland_backend_config_add_new_output. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main.c b/src/main.c index 55ecc08..2e5c743

[PATCH weston v3 14/17] compositor-wayland: refactor backend_init

Rename new_config to config in backend_init function. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 6

[PATCH weston v3 02/17] compositor-wayland: add versionning to config structure

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 27 --- src/compositor-wayland.h | 3 +++ 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 83f31de..b51467d

[PATCH weston v3 16/17] compositor-wayland: rename wayland_output_config_init

Rename wayland_output_config_init to weston_wayland_output_config_init. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main.c b/src/main.c index adaebf7..55ecc08 100644 --- a/src/main.c +++

[PATCH weston v3 09/17] compositor-wayland: refactor wayland_backend_config_add_new_output

Rename new_config to config in wayland_backend_config_add_new_output function. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main.c b/src/main.c index 8d42ec5..3d643f1 100644 ---

[PATCH weston v3 08/17] compositor-wayland: refactor load_wayland_backend

Rename variable new_config to config in load_wayland_backend function. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/src/main.c b/src/main.c

[PATCH weston v3 11/17] compositor-wayland: refactor wayland_backend_create

Remove argv, argc and weston_config from wayland_backend_create function. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index f

[PATCH weston v3 03/17] compositor-wayland: rename wayland_output_init_from_config

Rename wayland_output_init_from_config to wayland_output_config_init. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index b

Re: [PATCH weston v2 7/9] wayland-backend: split init_backend

Hello Yong, Thanks, I will fix this in next version after few more review :) Best regards. Le 29/04/2016 03:38, Yong Bakos a écrit : > On Apr 28, 2016, at 1:33 PM, Benoit Gschwind <gschw...@gnu-log.net> wrote: >> >> Extract configuration parsing from init_back

Re: [PATCH weston v7 2/3] drm: port the drm backend to the new init api

mff7.net> > Acked-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> > Tested-by: Benoit Gschwind <gschw...@gnu-log.net> > > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> > --- > > v5: > - Update to reflect format rename to gdb_format &g

Re: [PATCH weston v7 1/3] x11: port the x11 backend to the new init api

Hello Bryce, It's look the you use space within Makefile.am instead of tabulation. Le 30/04/2016 10:30, Benoit Gschwind a écrit : > Hello Bryce, > > It look good after trivial rebase to master. > > Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> > Tested-by: Benoi

Re: [PATCH weston v7 1/3] x11: port the x11 backend to the new init api

Hello Bryce, It look good after trivial rebase to master. Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> Tested-by: Benoit Gschwind <gschw...@gnu-log.net> Le 30/04/2016 00:40, Bryce Harrington a écrit : > From: Benoit Gschwind <gschw...@gnu-log.net> > > Use

[PATCH weston v1] rpi-backend: refactor the configuration API

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- v1: - fix missing file - update Makefile.am Makefile.am | 3 +++ src/compositor-rpi.c | 42 -- src/compositor-rpi.h | 49 + src/

[PATCH weston v1] headless-backend: fix leak of transfrom configuration

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- v1: - fix warning for freeing a const - fix typo src/main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main.c b/src/main.c index f034dda..404e5fc 100644 --- a/src/main.c +++ b/src/main.c @@

[PATCH] rpi-backend: refactor the configuration API

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- NOTE: The patch is theorical and wasn't tested on rasbery-pi src/compositor-rpi.c | 42 -- src/main.c | 40 ++-- 2 files changed, 54 insertions(

[PATCH] headless-backend: fix leak of transfrom configuration

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main.c b/src/main.c index f034dda..9c15b71 100644 --- a/src/main.c +++ b/src/main.c @@ -692,7 +692,7 @@ load_headless_backend(

[PATCH weston v2 9/9] wayland-backend: move all parsing functions to weston

Move all parsing functions from the wayland backend and put them into the weston code and add versionning to configuration structure. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 232 --- src/compositor-way

[PATCH weston v2 8/9] wayland-backend: put configuration structure in separate header

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- Makefile.am | 3 +++ src/compositor-wayland.c | 20 + src/compositor-wayland.h | 58 3 files changed, 62 insertions(+), 19 deletions(-) create mode 1006

[PATCH weston v2 3/9] wayland-backend: use new config struture to create backend

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 0bfd3ad..0440057 100644 --- a/src/compositor-wayland.c +++

[PATCH weston v2 6/9] wayland-backend: split wayland_output_create_for_config

The splitting intend to separate configuration parsing from output setup. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 96 ++-- 1 file changed, 60 insertions(+), 36 deletions(-) diff --git a/src/comp

[PATCH weston v2 2/9] wayland-backend: fix memory leak of display_name

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 8577a74..0bfd3ad 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -

[PATCH weston v2 7/9] wayland-backend: split init_backend

Extract configuration parsing from init_backend function. The new init_backend start by generating the configuration structure from configuration file with separated function and then use this structure to load the backend. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/comp

[PATCH weston v2 4/9] wayland-backend: move config parsing in create_cursor

Move configuration parsing from create_cursor to backend_init. Use newer configuration structure to initialize the cursor in create_cursor. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 32 +++- 1 file changed, 19 inse

[PATCH weston v2 0/9] wayland-backend: refactor the configuration API

I did a patches set that split the previous patch in severals steps. The step intend to help the review, and may not be logical. The patch is focuced on keeping the legacy configuration behaviours. Benoit Gschwind (9): wayland-backend: Create a basic config structure to use in new init API

[PATCH weston v2 1/9] wayland-backend: Create a basic config structure to use in new init API

Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 9d1a251..8577a74 100644 --- a/src/comp

[PATCH weston v2 5/9] wayland-backend: define output configuration structure

The structure is not used currently, just the definition to be used. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-wayland.c | 8 1 file changed, 8 insertions(+) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 175bd68..f218c9e

Re: [PATCH weston] compositor-fbdev: make copy of the device string

hat the pointer to the device path stays valid gets harder and > harder with migrating to the libweston-style config handling. Therefore, > make a copy of the string, private to struct fbdev_output. > > Now the pointer passed in to fbdev_output_create() could be freed right > after the call ret

[PATCH weston v3 1/3] fbdev-backend: refactor configuration API

Implement a "well" defined API to configure the fbdev backend. Following and according to discussion about libweston API Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- Makefile.am| 5 - src/compositor-fbdev.c | 45 +++---

[PATCH weston v3 0/3] fbdev-backend: refactor configuration API

I hope I covered all remaining issues. v3: - update Makefile.am - fix memory corruption/leak of device variable - move transform configuration in the weston side v2: - add src/compositor-fbdev.h in the Makefile.am - fix typo Benoit Gschwind (3): fbdev-backend: refactor configuration API

[PATCH weston v3 3/3] fbdev-backend: move output transform configuration

The output transform configuration is moved into weston and added to the fbdev configuration structure. Signed-off-by: Benoit Gschwind <gschw...@gnu-log.net> --- src/compositor-fbdev.c | 17 - src/compositor-fbdev.h | 2 ++ src/main.c | 8 3 files c

  1   2   >