Re: [PATCH 1/1] weston-launch: alter tty command line parameter semantics

2014-12-08 Thread Damian, Alexandru
What annoyed me was weston silently ignoring the tty argument in certain conditions (you have to specify a new user argument while being root). I reasoned that user access to the tty should be set up by the kernel policies, and we should not enforce the policy at weston level. If the system is

Re: [[PATCH v3 2/2]] compositor: check if seteuid worked

2013-09-27 Thread Damian, Alexandru
Launching weston directly through sudo. The seteuid failed for some reason - I didn't track it down - so I added the check. Alex On Thu, Sep 26, 2013 at 10:42 PM, Kristian Høgsberg hoegsb...@gmail.comwrote: On Wed, Sep 25, 2013 at 02:47:47PM +0100, Alex DAMIAN wrote: From: Alexandru DAMIAN

Re: [PATCH 1/1] config: add command line option for config file

2013-09-27 Thread Damian, Alexandru
=intel@lists.freedesktop.org] On Behalf Of Alex DAMIAN Sent: Thursday, September 26, 2013 2:27 AM To: wayland-devel@lists.freedesktop.org Cc: Damian, Alexandru Subject: [PATCH 1/1] config: add command line option for config file From: Alexandru DAMIAN alexandru.dam...@intel.com

Re: [[PATCH v3 2/2]] compositor: check if seteuid worked

2013-09-27 Thread Damian, Alexandru
Just had my coffe - I mean through suid - i chmod-ed +s the weston executable. I can't repro, I don't know what I did at that time. On Fri, Sep 27, 2013 at 9:03 AM, Damian, Alexandru alexandru.dam...@intel.com wrote: Launching weston directly through sudo. The seteuid failed for some reason

Re: [PATCH v3 1/2] config: verify that the config file is not null

2013-09-26 Thread Damian, Alexandru
Disregard this patch, I sent in another that should handle better the config file issues. Alex On Wed, Sep 25, 2013 at 11:23 PM, Damian, Alexandru alexandru.dam...@intel.com wrote: The nice thing was that even if some other code besides the _log tries to read the file path, that code can

Re: [PATCH v2 2/2] compositor: check if seteuid worked

2013-09-25 Thread Damian, Alexandru
Funky, I tested the correct patch and then submitted this garbage. Thanks for spotting this, new patch in the mail. Alex On Wed, Sep 25, 2013 at 2:36 PM, Emilio Pozuelo Monfort poch...@gmail.comwrote: Hi, On 25/09/13 14:48, Alex DAMIAN wrote: From: Alexandru DAMIAN

Re: [PATCH v3 1/2] config: verify that the config file is not null

2013-09-25 Thread Damian, Alexandru
The nice thing was that even if some other code besides the _log tries to read the file path, that code can expect to open the path and read from it just fine, instead of receiving a NULL and maybe crashing. I'm gonna check tomorrow if this happens somewhere else in the code, and if not, modify