[PATCH weston] Fix a crash when opening two terminal windows and closing the first one.

2012-11-29 Thread Dima Ryazanov
To reproduce, launch the terminal, open a second window using Ctrl-Shift-N, go back to the first window, and press Ctrl-D. The terminal's master FD gets events even after being closed, causing terminal_destroy to be called twice on the same object. To fix this, I'm adding a function to stop

[PATCH weston] Fix a typo.

2012-11-11 Thread Dima Ryazanov
--- src/evdev-touchpad.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev-touchpad.c b/src/evdev-touchpad.c index 6a3217b..73c04eb 100644 --- a/src/evdev-touchpad.c +++ b/src/evdev-touchpad.c @@ -160,7 +160,7 @@ get_touchpad_model(struct evdev_device *device)

Re: [PATCH weston] Fix a crash when a client disconnects.

2012-07-22 Thread Dima Ryazanov
...@gmail.comwrote: On Tue, Jul 10, 2012 at 02:35:10PM -0400, Kristian Høgsberg wrote: On Tue, Jul 10, 2012 at 09:28:11AM -0700, Dima Ryazanov wrote: I see the following use-after-free when a client disconnects: ==21822== Invalid write of size 8 ==21822==at 0x54A8F74: wl_list_remove

Re: [PATCH weston] Fix a crash when a client disconnects.

2012-07-12 Thread Dima Ryazanov
We have a different case to consider though. When a surface is explicitly destroyed by calling surface.destroy(), we still need to destroy pending callbacks, and that case the resource system wont do it for us. So we need to iterate through the list and free them manually. Is there an

[PATCH weston] Fix a crash when a client disconnects.

2012-07-10 Thread Dima Ryazanov
I see the following use-after-free when a client disconnects: ==21822== Invalid write of size 8 ==21822==at 0x54A8F74: wl_list_remove (wayland-util.c:51) ==21822==by 0x409C87: destroy_frame_callback (compositor.c:1362) ==21822==by 0x56B44E7: destroy_resource (wayland-server.c:427)

Re: [PATCH] compositor: Fix buggy snprintf that sets module path

2012-05-24 Thread Dima Ryazanov
Wouldn't this be simpler? snprintf(path, sizeof path, %s/%s, MODULEDIR, name); On Wed, May 23, 2012 at 11:32 PM, Chad Versace chad.vers...@linux.intel.com wrote: If the MODULEDIR string contains '%', then snprintf(path, sizeof(path), MODULEDIR /%s, name); does not do what you want. Fix

[PATCH weston] window: Don't crash if a cursor image failed to load.

2012-05-08 Thread Dima Ryazanov
Signed-off-by: Dima Ryazanov d...@gmail.com --- clients/window.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index 2c59b23..72d36d3 100644 --- a/clients/window.c +++ b/clients/window.c @@ -687,10 +687,14 @@ create_cursors

[PATCH] Don't discard key press / key release events if the keys are different. Otherwise, keystrokes get dropped if the user types too quickly.

2011-08-16 Thread Dima Ryazanov
--- compositor/compositor-x11.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/compositor/compositor-x11.c b/compositor/compositor-x11.c index 0e9fed7..b83dc76 100644 --- a/compositor/compositor-x11.c +++ b/compositor/compositor-x11.c @@ -468,7 +468,8 @@

<    1   2