[PATCH weston] ivi-shell: listen compositor wake_signal

If compositor wakes up from sleep state, we have to trigger repaint for all outputs. Signed-off-by: Emre Ucan --- ivi-shell/ivi-shell.c | 16 ivi-shell/ivi-shell.h | 1 + 2 files changed, 17 insertions(+) diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c index

[PATCH weston v2] ivi-shell: use install paths in example config

) Reported-by: Michael Tretter Signed-off-by: Emre Ucan --- Makefile.am | 4 +--- ivi-shell/weston.ini.in | 60 - 2 files changed, 31 insertions(+), 33 deletions(-) diff --git a/Makefile.am b/Makefile.am index 69ca6cb..819c9c9 100644 --- a

[PATCH weston] ivi-shell: use install paths in example config

The example weston.ini file uses source and build directory paths. Therefore, it is only useful when used on the same system that is used to build Weston. We can use install paths instead of build/source paths to fix this problem. Reported-by: Michael Tretter Signed-off-by: Emre Ucan

[PATCH weston 7/9] ivi-shell: allow to set transitions only once

Transitions are only atomically set during commit_changes. Therefore, it should not be possible to set same type of transition to same surface/layer more than once. Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-transition.c | 74 +-- 1 file changed, 9

[PATCH weston 8/9] ivi-shell: remove surface_set_transition_duration

it is not used Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h | 9 + ivi-shell/ivi-layout.c| 17 - 2 files changed, 1 insertion(+), 25 deletions(-) diff --git a/ivi-shell/ivi-layout-export.h b/ivi-shell/ivi-layout-export.h index 834b906..fee7adb

[PATCH weston 6/9] ivi-shell: remove start rectangle from ivi_layout_surface

it is always equal to destination rectangle. Therefore, we can remove it Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h | 4 ivi-shell/ivi-layout-transition.c | 8 ivi-shell/ivi-layout.c| 4 3 files changed, 4 insertions(+), 12 deletions(-) diff

[PATCH weston 9/9] ivi-shell: remove move_layer_cancel API

Transitions are committed during commit_changes. If we want to remove previously set transitions, we need to call layer_set_transition with IVI_LAYOUT_TRANSITION_NONE. Therefore, this API is redundant. Signed-off-by: Emre Ucan --- ivi-shell/hmi-controller.c| 4 +++- ivi-shell/ivi

[PATCH weston 5/9] ivi-shell: remove redundant code in commit_surface_list

Move out the statements out of if statement, which are the same in every branch. Furthermore, *_move_resize_view() function does not modify destination rectangle of the surface. Therefore, we don't need to store the destination rectangle locally and set it again. Signed-off-by: Emre

[PATCH weston 4/9] ivi-shell: remove VIEW_FADE_ONLY transition

we can use VIEW_FADE transition instead Signed-off-by: Emre Ucan --- ivi-shell/hmi-controller.c| 2 +- ivi-shell/ivi-layout-export.h | 1 - ivi-shell/ivi-layout.c| 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/ivi-shell/hmi-controller.c b/ivi-shell/hmi

[PATCH weston 2/9] ivi-shell: remove unused VIEW_RESIZE transition

we can use VIEW_MOVE_RESIZE instead Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h | 1 - ivi-shell/ivi-layout-transition.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/ivi-shell/ivi-layout-export.h b/ivi-shell/ivi-layout-export.h index b6291f1..b3f5beb

[PATCH weston 1/9] ivi-shell: remove unused VIEW_ORDER transition

it is not possible to make transition of z-order changes Signed-off-by: Emre Ucan --- ivi-shell/hmi-controller.c| 3 --- ivi-shell/ivi-layout-export.h | 1 - 2 files changed, 4 deletions(-) diff --git a/ivi-shell/hmi-controller.c b/ivi-shell/hmi-controller.c index 0e44df8..f8858c5 100644

[PATCH weston 3/9] ivi-shell: remove DEST_RECT_ONLY transition

we can use VIEW_MOVE_RESIZE tranisition instead Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h | 1 - ivi-shell/ivi-layout.c| 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/ivi-shell/ivi-layout-export.h b/ivi-shell/ivi-layout-export.h index b3f5beb

[PATCH weston 0/9] Transition rework part 1

to ensure same type of transition is only set once for a ivilayer/ivisurface - 8th and 9th patch remove unused, unnecessary APIs from ivi_layout_interface Emre Ucan (9): ivi-shell: remove unused VIEW_ORDER transition ivi-shell: remove unused VIEW_RESIZE transition ivi-shell: remove

[PATCH weston] libweston: don't accumulate damage from transparent views

If view is set to be entirely transparent, there is no need to accumulate its damage. This is an important optimization for using view transparency. Because otherwise transparent views are rendered like an opaque view, and their pixel values are set to 0 in fragment shader. Signed-off-by: Emre

[PATCH weston 6/7] compositor: initialize ret in repaint_timer_handler

If output_list of compositor is empty, value of ret is read without initialization. Signed-off-by: Emre Ucan --- libweston/compositor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libweston/compositor.c b/libweston/compositor.c index 67b5d28..4816f33 100644 --- a

[PATCH weston 5/7] gl-renderer: set num_images after import_simple_dmabuf

we have to set num_images after import_simple_dmabuf call. Otherwise, egl_images will not be correctly referenced in gl_renderer_attach_dmabuf. (Found by clang source code analyzer) Signed-off-by: Emre Ucan --- libweston/gl-renderer.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH weston 7/7] ivi-shell: remove dead assignments in layer transition

Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-transition.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shell/ivi-layout-transition.c index b887ff6..a223b58 100644 --- a/ivi-shell/ivi-layout-transition.c +++ b/ivi-shell

[PATCH weston 0/7] Fix source code analyzer findings

These patches fix some of the findings which are found by clang source code analyzer. Emre Ucan (7): compositor-drm: remove superfluos get_disable_state call compositor-drm: remove dead assigment in drm_fb_create_dumb hmi-controller: remove dead assignments in add_launchers input: fix use

[PATCH weston 4/7] input: fix use-after-free issue at pointer_cancel

removed, when constraint is an one-shot constraint. (Found by clang source code analyzer) Signed-off-by: Emre Ucan --- libweston/input.c | 12 1 file changed, 12 deletions(-) diff --git a/libweston/input.c b/libweston/input.c index 3e91c26..a9d21cb 100644 --- a/libweston/input.c ++

[PATCH weston 3/7] hmi-controller: remove dead assignments in add_launchers

assigned values of x, y, ret and layout_surface are never read. (Found by clang source code analyzer) Signed-off-by: Emre Ucan --- ivi-shell/hmi-controller.c | 4 1 file changed, 4 deletions(-) diff --git a/ivi-shell/hmi-controller.c b/ivi-shell/hmi-controller.c index b13936f..0e44df8

[PATCH weston 1/7] compositor-drm: remove superfluos get_disable_state call

drm_output_get_disable_state function returns a duplicated output_state object. Here we are creating the object, but we are never using it. Therefore, it is safe to remove. (Found by clang source code analyzer) Signed-off-by: Emre Ucan --- libweston/compositor-drm.c | 1 - 1 file changed, 1

[PATCH weston 2/7] compositor-drm: remove dead assigment in drm_fb_create_dumb

ret is overwritten by drmModeAddFB2 call (Found by clang source code analyzer) Signed-off-by: Emre Ucan --- libweston/compositor-drm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index f8c13ee..506ded5 100644 --- a/libweston

[PATCH weston] tests: fix a race condition in ivi-shell tests

surfaces and layers which are not expected by test plugins. We can start ivi-shell tests without config file to solve this problem. Then, weston will not load hmi-controller plugin. Reported-by: Pekka Paalanen Signed-off-by: Emre Ucan --- Makefile.am| 16 +--- tests/weston

[PATCH weston v2 3/4] ivi-shell: don't expilicitly assign outputs to views

it is assigned in weston_view_assign_outputs Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c index 3c52ce1..ea31dea 100644 --- a/ivi-shell/ivi-layout.c +++ b/ivi-shell/ivi-layout.c @@ -822,7

[PATCH weston 4/4] ivi-shell: fix the layer assignment change from one screen to another

if the layer is in order of some screen we need to remove it from there and mark the screen order as dirty so it will be removed in commit_screen_list call later layer should only be assigned to one screen at a time Signed-off-by: Eugen Friedrich Signed-off-by: Emre Ucan --- ivi-shell/ivi

[PATCH weston 3/4] ivi-shell: don't expilicitly assign outputs to views

it is assigned in weston_view_assign_outputs Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout.c | 4 1 file changed, 4 deletions(-) diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c index 3c52ce1..4799c25 100644 --- a/ivi-shell/ivi-layout.c +++ b/ivi-shell/ivi-layout.c

[PATCH weston 2/4] ivi-shell: don't schedule compositor repaint

-by: Emre Ucan --- ivi-shell/ivi-layout.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c index 394179b..3c52ce1 100644 --- a/ivi-shell/ivi-layout.c +++ b/ivi-shell/ivi-layout.c @@ -27,7 +27,7 @@ * Implementation

[PATCH weston 1/4] ivi-shell: change layer visibility to bool

ivi_layout_layer_set_visibility has bool as argument. Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ivi-shell/ivi-layout-export.h b/ivi-shell/ivi-layout-export.h index 277ac59..f656602 100644 --- a/ivi-shell/ivi

[PATCH weston v2 6/6] ivi-shell: remove ivi_shell_setting

it has only developermode option parameter. The parameter is only used in init_ivi_shell. Therefore, we can basically remove the struct, and check the option locally in the function. Signed-off-by: Emre Ucan Reviewed-by: Pekka Paalanen --- ivi-shell/ivi-shell.c | 42

[PATCH weston v2 1/6] ivi-shell: register ivi_layout_interface

Signed-off-by: Emre Ucan Acked-by: Pekka Paalanen --- ivi-shell/ivi-layout-export.h | 13 + ivi-shell/ivi-layout.c| 6 ++ ivi-shell/ivi-shell.c | 2 -- 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/ivi-shell/ivi-layout-export.h b/ivi-shell/ivi

[PATCH weston v2 5/6] ivi-shell: don't load controller modules

controller modules can be loaded as weston modules from the main function of weston. Signed-off-by: Emre Ucan Reviewed-by: Pekka Paalanen --- ivi-shell/ivi-layout.c | 40 ivi-shell/ivi-shell.c | 28 2 files changed, 4

[PATCH weston v2 4/6] tests: load ivi-shell test plugins as weston module

It is better to load ivi controller modules as a generic weston module. Then, we do not need to have a specific ivi way of loading modules. Signed-off-by: Emre Ucan --- tests/ivi_layout-internal-test.c | 21 - tests/ivi_layout-test-plugin.c | 20 +++- tests

[PATCH weston v2 3/6] hmi-controller: load as weston module

weston loads hmi-controller as a weston module. IVI-shell does not need to load it explicitly. Signed-off-by: Emre Ucan Reviewed-by: Pekka Paalanen --- ivi-shell/hmi-controller.c | 36 ivi-shell/weston.ini.in| 2 +- 2 files changed, 17 insertions

[PATCH weston v2 2/6] hmi-controller: remove ivi_layout_interface global

Put the interface into hmi_controller struct. It is better to have it in an object. Signed-off-by: Emre Ucan Reviewed-by: Pekka Paalanen --- ivi-shell/hmi-controller.c | 194 +++-- 1 file changed, 100 insertions(+), 94 deletions(-) diff --git a/ivi

[PATCH] dmabuf: set modifier to invalid for not supporting clients

lients which are not supporting modifiers. Without this patch linux-dmabuf protocol is not working for not supporting clients. Fixes: b138d7afb3a2a7d51dccb12f08d70c2d86766901 ("gl-renderer: Ignore INVALID modifier") Signed-off-by: Emre Ucan --- libweston/gl-renderer.c | 2 +- libwesto

[PATCH weston 6/6] ivi-shell: remove ivi_shell_setting

it has only developermode option parameter. The parameter is only used in init_ivi_shell. Therefore, we can basically remove the struct, and check the option locally in the function. Signed-off-by: Emre Ucan --- ivi-shell/ivi-shell.c | 42 -- 1 file

[PATCH weston 5/6] ivi-shell: don't load controller modules

controller modules can be loaded as weston modules from the main function of weston. Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout.c | 40 ivi-shell/ivi-shell.c | 28 2 files changed, 4 insertions(+), 64 deletions

[PATCH weston 3/6] hmi-controller: load as weston module

weston loads hmi-controller as a weston module. IVI-shell does not need to load it explicitly. Signed-off-by: Emre Ucan --- ivi-shell/hmi-controller.c | 33 ++--- ivi-shell/weston.ini.in| 2 +- 2 files changed, 15 insertions(+), 20 deletions(-) diff --git a/ivi

[PATCH weston 0/6] Register ivi_layout_interface to Weston Plugin Registry

some minor clean-ups in hmi-controller and ivi-shell. Emre Ucan (6): ivi-shell: register ivi_layout_interface hmi-controller: remove ivi_layout_interface global hmi-controller: load as weston module tests: load ivi-shell test plugins as weston module ivi-shell: don't load controller mo

[PATCH weston 1/6] ivi-shell: register ivi_layout_interface

controller modules can be loaded from the main function of weston. They will get the ivi_layout_interface via weston plugin registry. Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h | 13 + ivi-shell/ivi-layout.c| 6 ++ ivi-shell/ivi-shell.c | 2

[PATCH weston 4/6] tests: load ivi-shell test plugins as weston module

Signed-off-by: Emre Ucan --- tests/ivi_layout-internal-test.c | 21 - tests/ivi_layout-test-plugin.c | 20 +++- 2 files changed, 15 insertions(+), 26 deletions(-) diff --git a/tests/ivi_layout-internal-test.c b/tests/ivi_layout-internal-test.c index 4d73eff

[PATCH weston 2/6] hmi-controller: remove ivi_layout_interface global

Put the interface into hmi_controller struct. It is better to have it in an object. Signed-off-by: Emre Ucan --- ivi-shell/hmi-controller.c | 194 +++-- 1 file changed, 100 insertions(+), 94 deletions(-) diff --git a/ivi-shell/hmi-controller.c b/ivi

[PATCH weston] launcher: don't exit when user is not root

weston does not need to be root. It requires adjusting ownership on the given tty device. If weston does not have proper rights, it will get an error at startup anyway. Signed-off-by: Emre Ucan --- libweston/launcher-direct.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libweston

[PATCH weston v4 6/9] xwm: dump_property() to use FILE internally

From: Pekka Paalanen Write the output of dump_property() out in one log call. When multiple processes (weston and Xwayland) are writing to the same file, this will keep the property dump uninterrupted by Xwayland debug prints. This is also preparation for more development in the same direction.

[PATCH weston v4 5/9] compositor: offer logs via weston-debug

From: Pekka Paalanen This registers a new weston-debug scope "log" through which one can get live log output interspersed with possible other debugging prints. Signed-off-by: Pekka Paalanen pass the log_scope to weston_debug_scope_timestamp API to append the scope name to the timestamp Signed

[PATCH weston v4 8/9] xwm: convert WM_DEBUG into a weston-debug scope

From: Pekka Paalanen Instead of a compile time choice, offer the XWM debugging messages through the weston-debug protocol and tool on demand. Users will not need to recompile weston to get XWM debugging, and it won't flood the weston log. The debug scope needs to be initialized in launcher.c for

[PATCH weston v4 9/9] compositor: protocol logger

From: Pekka Paalanen This is better than running Weston with WAYLAND_DEBUG=server: - It is enabled on demand, no unnecessary flooding and no need to restart the compositor if debug was enabled. - It prints client pointers so that messages with different clients can be seen apart. Signed-off-

[PATCH weston v4 7/9] xwm: move FILE to the callers of dump_property()

From: Pekka Paalanen This is preparation for using the weston-debug infrastructure for WM_DEBUG. dump_property() may be called from different debugging contexts and often needs to be prefixed with more information. An alternative to this patch would be to pass in the weston_debug_scope as an arg

[PATCH weston v4 1/9] protocol: add weston-debug.xml

From: Pekka Paalanen This is a new debugging extension for non-production environments. The aim is to replace all build-time choosable debug prints in the compositor with runtime subscribable debug streams. Signed-off-by: Pekka Paalanen Added new libweston-$MAJOR-protocols.pc file and install

[PATCH weston v4 2/9] libweston: add weston_debug API and implementation

From: Pekka Paalanen weston_debug is both a libweston API for relaying debugging messages, and the compositor-debug wayland protocol implementation for accessing those debug messages from a Wayland client. weston_debug_compositor_{create,destroy}() are private API, hence not exported. Signed-of

[PATCH weston v4 3/9] compositor: add option to enable weston_debug

From: Pekka Paalanen Let users enable the compositor debug protocol on the compositor command line. This allows weston-debug tool to work. Signed-off-by: Pekka Paalanen Signed-off-by: Maniraj Devadoss --- compositor/main.c | 7 +++ man/weston.man| 15 +-- 2 files changed,

[PATCH weston v4 4/9] clients: add weston-debug

From: Pekka Paalanen A tool for accessing the zcompositor_debug_v1 interface features. Installed along weston-info, because it should be potentially useful for people running libweston-based compositors. Signed-off-by: Pekka Paalanen Added a man page for weston-debug client Signed-off-by: Ma

[PATCH weston v4 0/9] weston-debug API and tool

This series of patches are from weston debug protocol RFC posted by Pekka Paalanen along with the modifications done by Maniraj Devadoss . https://lists.freedesktop.org/archives/wayland-devel/2017-June/034227.html v3: 1. protocol is renamed to weston-debug.xml 2. libweston-3-protocols-pc is inst