Re: [PATCH wayland-protocols v7] text: Create second version of text input protocol

2016-10-14 Thread Jan Arne Petersen
Hi, On Wed, 2016-10-12 at 15:50 -0700, Bryce Harrington wrote: > On Wed, Jul 06, 2016 at 12:26:28AM +0200, Jan Arne Petersen wrote: > > > > On Thu, Jun 9, 2016 at 1:01 PM Carlos Garnacho <carl...@gnome.org> > > wrote: > > > > Hi C

Re: [PATCH weston 3/3] simple-im: Rename source file to be consistent with other client tools

2016-10-12 Thread Jan Arne Petersen
>    0); > - zwp_input_method_context_v1_preedit_ > string(keyboard->context, > - >    keyboard->serial, > -

Re: [PATCH wayland-protocols v7] text: Create second version of text input protocol

2016-07-06 Thread Jan Arne Petersen
On Wed, Jul 6, 2016, 01:44 Jonas Ådahl <jad...@gmail.com> wrote: > On Wed, Jul 06, 2016 at 12:26:28AM +0200, Jan Arne Petersen wrote: > > On Thu, Jun 9, 2016 at 1:01 PM Carlos Garnacho <carl...@gnome.org> > wrote: > > > > Hi Carlos, > > > >

Re: [PATCH 5/5] text-backend: update to version 2 of text input protocol

2016-07-05 Thread Jan Arne Petersen
On Tue, Jul 5, 2016 at 10:46 PM Arnaud Vrac <raw...@gmail.com> wrote: > > > On 5 juil. 2016, at 22:11, Jan Arne Petersen <jana...@gmail.com> wrote: > > > > > > On Wed, Jun 8, 2016 at 5:40 PM Arnaud Vrac <av...@freebox.fr> wrote: > > The input

Re: [PATCH wayland-protocols v7] text: Create second version of text input protocol

2016-07-05 Thread Jan Arne Petersen
between v1 and v2, so please bear with me, I > hope the feedback is useful. Sure that is perfectly fine, I think that is the idea of the unstable protocols anyways that we can still change everything and adapt them with real world experience. > > On Mon, May 30, 2016 at 11:41 AM, Jan Arne

Re: [PATCH 5/5] text-backend: update to version 2 of text input protocol

2016-07-05 Thread Jan Arne Petersen
_data(resource); > > if (context->input) > - > zwp_text_input_v1_send_modifiers_map(context->input->resource, > + > zwp_text_input_v2_send_modifiers_map(context->input->resource, > map); > } > &

Re: [PATCH 3/5] text-backend: implement keyboard release

2016-07-05 Thread Jan Arne Petersen
(cr, _interface, > + context, unbind_keyboard); > > context->keyboard = cr; > > -- > 2.7.4 > > In an update to the input-method protocol we need to remove the wl_keyboard fr

Re: [PATCH 2/5] text-backend: track shown panel

2016-07-05 Thread Jan Arne Petersen
nel_signal, >_input->cursor_rectangle); > + if (text_input->manager->current_panel == NULL) > + text_input->manager->current_panel = text_input; > } > }

Re: [PATCH 1/5] text-backend: send event when the input panel visiblity changes

2016-07-05 Thread Jan Arne Petersen
(struct wl_client *client, > struct text_input *text_input = > wl_resource_get_user_data(resource); > struct weston_compositor *ec = text_input->ec; > > - text_input->input_panel_visible = false; > + t

[PATCH wayland-protocols v7] text: Create second version of text input protocol

2016-05-30 Thread Jan Arne Petersen
@@ + + + + +Copyright © 2012, 2013 Intel Corporation +Copyright © 2015, 2016 Jan Arne Petersen + +Permission to use, copy, modify, distribute, and sell this +software and its documentation for any purpose is hereby granted +without fee, provided that the above copyright notice appear in +all

[PATCH wayland-protocols v6] text: Create second version of text input protocol

2016-04-03 Thread Jan Arne Petersen
wp_text_input per wl_seat (client side should be handled by client toolkit) * Allow focus tracking without wl_keyboard present * Improve update state handling and better define state handling Signed-off-by: Jan Arne Petersen <jana...@gmail.com> --- Changes to v5: * Remove client side created

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-26 Thread Jan Arne Petersen
On Fri, Mar 25, 2016 at 8:16 AM Daiki Ueno <u...@gnu.org> wrote: > Hello, > > Jan Arne Petersen <jana...@gmail.com> writes: > > > There is a reference implementation of this version of the protocol in > QtWayland > > https://codereview.qt-project.org/#/c/

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-26 Thread Jan Arne Petersen
for different > surface), is that planned to be improved in the future? > Yes, I first want to get the text protocol ready. But yes the input-method protocol will be completely redesigned also. > See my other comments below. > > On Monday, 14 March 2016 12:58:27 PDT Jan Arne Petersen wr

Re: [PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-23 Thread Jan Arne Petersen
the qtvirtualkeyboard (which plugs in the Qt input method system) in the Qt compositor and use that to input text in all clients. Jan Arne Petersen On Mon, Mar 14, 2016 at 12:58 PM Jan Arne Petersen <jana...@gmail.com> wrote: > There were some shortcomings in the first version of the proto

[PATCH wayland-protocols v5] text: Create second version of text input protocol

2016-03-14 Thread Jan Arne Petersen
wp_text_input per wl_seat (client side should be handled by client toolkit) * Allow focus tracking without wl_keyboard present * Improve update state handling and better define state handling Signed-off-by: Jan Arne Petersen <jana...@gmail.com> --- Chnages to v4: * Improved descriptions *

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-19 Thread Jan Arne Petersen
Hi, On 18/02/16 20:36, Rui Tiago Cação Matos wrote: > On Wed, Feb 17, 2016 at 6:13 AM, Jan Arne Petersen <jana...@gmail.com> wrote: >>>> + > ... >>>> + >>>> + >>>> + >>>> + >>> &g

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-16 Thread Jan Arne Petersen
Hi, On 08/02/16 16:38, Rui Tiago Cação Matos wrote: > Hi, > > Thanks for the update. I'm replying to both v4 and your reply to my > previous mail. Inline: > > On Tue, Feb 2, 2016 at 2:33 PM, Jan Arne Petersen <jana...@gmail.com> wrote: >> + >> +

[PATCH v3 wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
@@ + + + + +Copyright © 2012, 2013 Intel Corporation +Copyright © 2015, 2016 Jan Arne Petersen + +Permission to use, copy, modify, distribute, and sell this +software and its documentation for any purpose is hereby granted +without fee, provided that the above copyright notice

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
On 28/01/16 11:05, Jonas Ådahl wrote: > On Thu, Jan 28, 2016 at 08:52:40AM +0100, Jan Arne Petersen wrote: >> There were some shortcomings in the first version of the protocol which >> makes it not really useful in real world applications. It is not really >> possible to fix

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
Hi, On 28/01/16 13:05, Daiki Ueno wrote: > Hello, > > Jan Arne Petersen <jana...@gmail.com> writes: > >> Fixes some shortcomings of the first version: >> >> * Use only one wp_text_input per wl_seat (client side should be >> handled by client

[PATCH v2 wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
@@ + + + + +Copyright © 2012, 2013 Intel Corporation +Copyright © 2015, 2016 Jan Arne Petersen + +Permission to use, copy, modify, distribute, and sell this +software and its documentation for any purpose is hereby granted +without fee, provided that the above copyright notice

[PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
@@ + + + + +Copyright © 2012, 2013 Intel Corporation +Copyright © 2015, 2016 Jan Arne Petersen + +Permission to use, copy, modify, distribute, and sell this +software and its documentation for any purpose is hereby granted +without fee, provided that the above copyright notice

Re: [PATCH v3 wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
ext-input/text-input-unstable-v2.xml >> @@ -0,0 +1,481 @@ >> + >> + >> + >> + >> +Copyright © 2012, 2013 Intel Corporation >> +Copyright © 2015, 2016 Jan Arne Petersen >> + >> +Permission to use, copy, modify, distribute,

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
wl_suface via enable/disable (renamed in v3). So there is only text input happening when the surface which has text focus is also enabled. > Not having a destroy request isn't so bad if that's the intended scope > but I think we should still have one. Added them. > On Thu, Ja

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
On 29/01/16 00:33, Bill Spitzak wrote: > > > On Wed, Jan 27, 2016 at 11:52 PM, Jan Arne Petersen <jana...@gmail.com > <mailto:jana...@gmail.com>> wrote: > > > + Text is generally UTF-8 encoded, indices and lengths are in > bytes. > >

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
On 29/01/16 21:43, Bill Spitzak wrote: > > > On Wed, Jan 27, 2016 at 11:52 PM, Jan Arne Petersen <jana...@gmail.com > <mailto:jana...@gmail.com>> wrote: > > > + > + > + Notify when a new composing tex

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-01-28 Thread Jan Arne Petersen
add another request with a fd to a later protocol version. Regards Jan Arne -- Jan Arne Petersen | jan.peter...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts ___

[PATCH wayland-protocols] text: Create second version of text input protocol

2016-01-27 Thread Jan Arne Petersen
@@ + + + + +Copyright © 2012, 2013 Intel Corporation +Copyright © 2015, 2016 Jan Arne Petersen + +Permission to use, copy, modify, distribute, and sell this +software and its documentation for any purpose is hereby granted +without fee, provided that the above copyright notice

Re: [PATCH weston 05/10] Use input method protocol from wayland-protocols

2015-11-04 Thread Jan Arne Petersen
On 04/11/15 09:49, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl <jad...@gmail.com> Reviewed-by: Jan Arne Petersen <jana...@gmail.com> > --- > Makefile.am | 17 ++- > clients/keyboard.c | 174 +- > client

Re: [PATCH weston 04/10] Use text input protocol from wayland-protocols

2015-11-04 Thread Jan Arne Petersen
On 04/11/15 09:49, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl <jad...@gmail.com> Reviewed-by: Jan Arne Petersen <jana...@gmail.com> > --- > Makefile.am| 21 ++- > clients/editor.c | 119 + > clients/keyboard.c | 12 +-

Re: Unstable protocol name breakage

2015-10-20 Thread Jan Arne Petersen
a different stable name for them (they both need to be fixed in a non backward compatible way anyways). Regards Jan Arne -- Jan Arne Petersen | jan.peter...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-5213254

Re: [PATCH weston] Add config option to disable input method

2015-06-09 Thread Jan Arne Petersen
launching the input method client Thanks, pq ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel -- Jan Arne Petersen | jan.peter...@kdab.com | Senior Software Engineer

Re: EFL/Wayland and xdg-shell

2015-04-16 Thread Jan Arne Petersen
instead of resizing (see http://www.jonnor.com/files/maliit/maliit-lmt-technical-overview-widget-reloc.pdf) I will add an event to the text protocol to support that. Regards Jan Arne -- Jan Arne Petersen | jan.peter...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbHCo KG, a KDAB

Re: [PATCH weston] text-input: Replace model with input

2015-01-12 Thread Jan Arne Petersen
On Mon Jan 12 2015 at 5:34:40 PM Derek Foreman der...@osg.samsung.com wrote: commit 78d00e45cc renamed text_model to text_input This cleans up remaining uses of the word model Signed-off-by: Derek Foreman der...@osg.samsung.com --- Please note that this applies on top of my earlier

Re: [PATCH weston 7/7] text: Fix text-input for multi-seat

2015-01-10 Thread Jan Arne Petersen
On Fri Dec 05 2014 at 10:47:05 PM Derek Foreman der...@osg.samsung.com wrote: Multi-seat configurations currently break the text-backend, crashing weston. This is an attempt to clean up any crashes and have somewhat sensible input panel behavior with multi-seat. Signed-off-by: Derek Foreman

Re: [PATCH v2 weston] editor: Make editor multi-seat aware

2014-12-18 Thread Jan Arne Petersen
Hey, On Wed Dec 17 2014 at 4:53:24 PM Derek Foreman der...@osg.samsung.com wrote: With multi-seat, multiple entries can occur on the text inputs in the editor. Also, the panel shouldn't be hidden by the editor if either text entry is still active. Signed-off-by: Derek Foreman

Re: [PATCH weston v2 6/7] text: Don't crash if a seat has no keyboard

2014-12-15 Thread Jan Arne Petersen
Hey, On Mon Dec 08 2014 at 5:57:04 PM Derek Foreman der...@osg.samsung.com wrote: A keyboard might not be present in a seat, so check that before dereferencing keyboard related pointers. Also, use the keyboard pointer we set to shorten the code a little bit. Signed-off-by: Derek Foreman

Re: [Take 2][PATCH] Add touch support for wl_shell_surface_move

2013-08-15 Thread Jan Arne Petersen
On 08/15/2013 12:49 AM, Rusty Lynch wrote: From 3c68e0e2aa98250c65a5d5e9658299904ccf34f1 Mon Sep 17 00:00:00 2001 From: Rusty Lynch rusty.ly...@intel.com Date: Wed, 14 Aug 2013 09:27:44 -0700 Subject: [PATCH] Add touch support for wl_shell_surface_move --- clients/calibrator.c| 4 +-

[PATCH 3/5] editor: Properly adjust cursor on delete

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 16ede4f..35f6d08 100644 --- a/clients/editor.c

[PATCH 0/5] Fix some bugs in editor example

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Fix some bugs I noticed when testing the editor example with latest Wayland enabled Maliit. Jan Arne Petersen (5): editor: Fix text selection editor: Support deleting text in preedit_string editor: Properly adjust cursor on delete editor

[PATCH 4/5] editor: Improve checks on delete add asserts

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/clients/editor.c b/clients/editor.c index 35f6d08..cd24f6a 100644 --- a/clients/editor.c +++ b

[PATCH 2/5] editor: Support deleting text in preedit_string

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Delete text marked with wl_text_input::delete_surrounding_text on preedit_string event. When text is explicitly marked with delete_surrounding_text do not delete selected text. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients

[PATCH 1/5] editor: Fix text selection

2013-05-30 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 76 1 file changed, 44 insertions(+), 32 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index

Re: [PATCH 0/5] Improve text protocol

2013-05-02 Thread Jan Arne Petersen
On 05/02/2013 09:56 PM, Kristian Høgsberg wrote: On Tue, Apr 16, 2013 at 06:19:47PM -0700, Bill Spitzak wrote: Jan Arne Petersen wrote: I completely agree that editing UTF-8 text as UTF-8 is fine. I am just wondering if we should have offsets in Unicode code points (with the addition

[PATCH v2 08/28] text: rename text_model::commit to commit_state

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Use ::commit_state as a request name to make clear what is commited. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 2 +- protocol/text.xml | 2 +- src/text-backend.c | 6 +++--- 3 files changed, 5 insertions

[PATCH v2 06/28] text: Fix some text and input-method docs

2013-04-18 Thread Jan Arne Petersen
From: Krzesimir Nowak krno...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- protocol/input-method.xml | 40 +++- protocol/text.xml | 36 +++- 2 files changed, 46 insertions(+), 30 deletions

[PATCH v2 05/28] text: Fix password content hint value

2013-04-18 Thread Jan Arne Petersen
From: Krzesimir Nowak krno...@openismus.com 0xc in this case was a combination of autocapitalization (0x4) and lowercase (0x8) instead of hidden_text (0x40) and sensitive_data (0x80). Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- protocol/text.xml | 2 +- 1 file changed, 1

[PATCH v2 11/28] text: Add none preedit-style

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Use default preedit style as default. None is used when the composing text should look like non-composing text. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/keyboard.c | 2 +- protocol/text.xml | 3 ++- 2 files changed, 3

[PATCH v2 16/28] text: Move input panel into an own file

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- src/Makefile.am | 3 +- src/compositor.c | 1 + src/compositor.h | 13 ++ src/input-panel.c | 461 ++ src/shell.c | 350

[PATCH v2 19/28] text: Fix serial handling

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 24 ++-- clients/keyboard.c | 23 +-- clients/weston-simple-im.c | 28 +++- protocol

[PATCH v2 21/28] keyboard: Remove unneded calls

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/keyboard.c | 16 1 file changed, 16 deletions(-) diff --git a/clients/keyboard.c b/clients/keyboard.c index bd88207..4fc8e73 100644 --- a/clients/keyboard.c

[PATCH v2 23/28] text: Rename ::set_panel to ::set_overlay_panel

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Also add documentation to input_panel_surface::set_overlay_panel. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- protocol/input-method.xml | 8 ++-- src/input-panel.c | 6 +++--- 2 files changed, 9 insertions(+), 5

[PATCH v2 26/28] text: add cursor_rectangle event to input_panel_surface

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- protocol/input-method.xml | 10 ++ src/input-panel.c | 37 - 2 files changed, 34 insertions(+), 13 deletions(-) diff --git a/protocol

[PATCH v2 24/28] text: Improve protocol documentation.

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- protocol/input-method.xml | 98 +++ protocol/text.xml | 52 - 2 files changed, 106 insertions(+), 44 deletions

[PATCH v2 27/28] keyboard: Fix offsets when deleting text

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/keyboard.c | 90 +++--- 1 file changed, 85 insertions(+), 5 deletions(-) diff --git a/clients/keyboard.c b/clients/keyboard.c

[PATCH v2 28/28] editor: Fix some offsets for multi-byte characters

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 100 ++- 1 file changed, 48 insertions(+), 52 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index

[PATCH v2 25/28] text: Rename input_method to wl_input_method

2013-04-18 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Also rename input_method_context to wl_input_method_context, input_panel to wl_input_panel and input_panel_surface to wl_input_panel_surface. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/keyboard.c | 162

Re: [PATCH 0/5] Improve text protocol

2013-04-16 Thread Jan Arne Petersen
Hi, On 04/15/2013 09:14 PM, Bill Spitzak wrote: Jan Arne Petersen wrote: * Changes offsets to be Unicode character instead of byte based No, PLEASE DON'T DO THIS!!! You think you are making things easier but you are making it much much harder. My main reason was that EFL, IBus

[PATCH 0/5] Improve text protocol

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com This patch series: * Fixes serials handling in text protocol * Changes offsets to be Unicode character instead of byte based * Adds documentation to the protocols * Adds wl_ prefixes to the interfaces. It is based on the previous Extend text

[PATCH 3/5] text: Rename ::set_panel to ::set_overlay_panel

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Also add documentation to input_panel_surface::set_overlay_panel. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- protocol/input-method.xml | 8 ++-- src/input-panel.c | 6 +++--- 2 files changed, 9 insertions(+), 5

[PATCH 2/5] text: Rename text_input to wl_text_input

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 118 ++--- clients/keyboard.c | 10 ++--- protocol/text.xml | 8 ++-- src/control.c | 2 +- src/text

[PATCH 4/5] text: Improve protocol documentation.

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- protocol/input-method.xml | 87 +++ protocol/text.xml | 6 ++-- 2 files changed, 70 insertions(+), 23 deletions(-) diff --git

[PATCH 5/5] text: Rename input_method to wl_input_method

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Also rename input_method_context to wl_input_method_context, input_panel to wl_input_panel and input_panel_surface to wl_input_panel_surface. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/keyboard.c | 162

Re: [PATCH 17/18] text: Only allow input-method started by weston to bind

2013-04-08 Thread Jan Arne Petersen
On 04/08/2013 01:51 AM, Yichao Yu wrote: Does this mean it is not possible to start a stand alone input method??? No. It just means that the compositor (weston) starts the stand alone input method. On Sun, Apr 7, 2013 at 6:12 PM, Jan Arne Petersen jpeter...@openismus.com mailto:jpeter

[PATCH 00/18] Extend text protocol for IBus support

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com This is a series of patches which makes it possible to use IBus with Wayland/Weston. An IBus with the required Wayland support is available at https://github.com/openismus/ibus. * Some cleanups from the previous text input patch series (required

[PATCH 11/18] text: Add none preedit-style

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Use default preedit style as default. None is used when the composing text should look like non-composing text. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/keyboard.c | 2 +- protocol/text.xml | 3 ++- 2 files changed, 3

[PATCH 13/18] editor: Send cursor position to the input method

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/clients/editor.c b/clients/editor.c index e686248..e61eda0 100644

[PATCH 14/18] text: Add support for panels following the cursor

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Add input_panel_surface::set_panel to specify input panel surfaces which are overlaying the application and are following the input cursor. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- protocol/input-method.xml | 3 ++ src

[PATCH 15/18] text: Add output argument to set_toplevel

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Allow to specify an output for a toplevel input panel surface. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/keyboard.c| 26 ++ protocol/input-method.xml | 1 + src/shell.c

[PATCH 16/18] text: Move input panel into an own file

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- src/Makefile.am | 3 +- src/compositor.c | 1 + src/compositor.h | 13 ++ src/input-panel.c | 470 ++ src/shell.c | 350

[PATCH 18/18] Add weston-control to allow reloading the config file

2013-04-07 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/.gitignore | 3 ++ clients/Makefile.am | 9 + clients/weston-control.c | 101 +++ protocol/Makefile.am | 1

Re: [PATCH 00/13] Clean up text protocol and move to wayland

2013-03-18 Thread Jan Arne Petersen
On 03/08/2013 09:17 PM, Pekka Vuorela wrote: On 19.02.2013 20:26, Jan Arne Petersen wrote: From: Jan Arne Petersen jpeter...@openismus.com This series finalizes the first version of the text protocol and moves it from Weston to Wayland, so that it can be implemented in toolkits. It adds

Re: [PATCH 00/13] Clean up text protocol and move to wayland

2013-02-20 Thread Jan Arne Petersen
On 19.02.2013 21:38, Yichao Yu wrote: On Tue, Feb 19, 2013 at 3:11 PM, Jan Arne Petersen jpeter...@openismus.com wrote: * im-client to send a key event - Already supported (input_method::keysym/input_method::key) Not really sure about this one, aren't these input_method::* requests used

Re: [PATCH 00/13] Clean up text protocol and move to wayland

2013-02-20 Thread Jan Arne Petersen
On 19.02.2013 22:31, Pekka Vuorela wrote: On 19.02.2013 22:11, Jan Arne Petersen wrote: On 19.02.2013 20:01, Yichao Yu wrote: On Tue, Feb 19, 2013 at 1:26 PM, Jan Arne Petersen jpeter...@openismus.com wrote: From: Jan Arne Petersen jpeter...@openismus.com This series finalizes the first

[PATCH 00/13] Clean up text protocol and move to wayland

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com This series finalizes the first version of the text protocol and moves it from Weston to Wayland, so that it can be implemented in toolkits. It adds the missing language/text-direction support to the protocol. text_model gets renamed

[PATCH 01/13] tests: Fix text-test

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Updated to changed text protocol. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- tests/text-test.c | 68 --- 1 file changed, 40 insertions(+), 28 deletions(-) diff --git a/tests

[PATCH 02/13] text: Add language and text-direction to protocol

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 20 - clients/keyboard.c | 54 ++ clients/weston-simple-im.c | 54

[PATCH 03/13] text: Add example for language/text direction

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 36 +- clients/keyboard.c | 89 -- 2 files changed, 121 insertions(+), 4 deletions(-) diff

[PATCH 04/13] keyboard: Reset state on activate

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/keyboard.c | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/clients/keyboard.c b/clients/keyboard.c index 824db34..303b608

[PATCH 06/13] text: Fix password content hint value

2013-02-19 Thread Jan Arne Petersen
From: Krzesimir Nowak krno...@openismus.com 0xc in this case was a combination of autocapitalization (0x4) and lowercase (0x8) instead of hidden_text (0x40) and sensitive_data (0x80). Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- protocol/text.xml | 2 +- 1 file changed, 1

[PATCH 07/13] text: Fix some text and input-method docs

2013-02-19 Thread Jan Arne Petersen
From: Krzesimir Nowak krno...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- protocol/input-method.xml | 40 +++- protocol/text.xml | 36 +++- 2 files changed, 46 insertions(+), 30 deletions

[PATCH 05/13] editor: Reset text model on reset

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com There were some reset calls missing, which resulted in wrong preedit state on input method side. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 08/13] view: g_type_init() is deprecated in glib = 2.35

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/view.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/view.c b/clients/view.c index 1bb9b9b..bfad897 100644 --- a/clients/view.c +++ b/clients/view.c @@ -293,7

[PATCH 09/13] text: rename text_model::commit to commit_state

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Use ::commit_state as a request name to make clear what is commited. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 2 +- protocol/text.xml | 2 +- src/text-backend.c | 6 +++--- 3 files changed, 5 insertions

[PATCH 10/13] text: Order requests and events in a nice way

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 14 ++--- protocol/text.xml | 172 ++--- src/text-backend.c | 24 tests/text-test.c | 14 ++--- 4 files

[PATCH 12/13] text: Add none preedit-style

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Use default preedit style as default. None is used when the composing text should look like non-composing text. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/keyboard.c | 2 +- protocol/text.xml | 3 ++- 2 files changed, 3

[PATCH 11/13] text: Rename text_model to text_input

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Also rename text_model_factory to text_input_manager. Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 142 +++ clients/keyboard.c | 10 +-- protocol/text.xml | 61 +++--- src

[PATCH 13/13] text: Move text protocol to wayland

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/Makefile.am | 6 +- clients/editor.c | 89 +++--- clients/keyboard.c | 11 +- protocol/Makefile.am | 1 - protocol/text.xml| 330

[PATCH] protocol: Add wl_text_input interface

2013-02-19 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com wl_text_input objects are used for text input. They add support for text input and input methods to applications. A text-input object is created from a wl_text_input_manager and corresponds typically to a text entry in an application. Signed-off

[PATCH 3/3] text: Add example for language/text direction

2013-02-11 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 36 +- clients/keyboard.c | 89 -- 2 files changed, 121 insertions(+), 4 deletions(-) diff

[PATCH 1/3] shell: Fix bug when input panel is shown twice

2013-02-11 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- src/shell.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shell.c b/src/shell.c index 6e0db35..8c3a452 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2772,6 +2772,9

[PATCH 2/3] text: Add language and text-direction to protocol

2013-02-11 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com Signed-off-by: Jan Arne Petersen jpeter...@openismus.com --- clients/editor.c | 20 - clients/keyboard.c | 54 ++ clients/weston-simple-im.c | 54

[PATCH 0/3] Add language and text-direction to text protocol

2013-02-11 Thread Jan Arne Petersen
From: Jan Arne Petersen jpeter...@openismus.com The proposed API allows to send the language and text-direction for inserted text from an input-method to an application. It also allows an application to specify a preferred language for the input. This could be used by an application to set

Re: Questions and thoughts about input method protocol

2013-02-05 Thread Jan Arne Petersen
agree with Daniel Stone. In addition you could also just look at the code (it is open source). Just check weston-simple-im.c for the compose-key input method which is already there for some months now. -- Jan Arne Petersen Openismus GmbH http://www.openismus.com

Re: Rename text_model and text_model_factory?

2013-02-05 Thread Jan Arne Petersen
by clients to create an arbitrary amount of text_model objects on request. An input method on the other hand cannot create input_method_context by itself but just gets them handed out when such a context gets activated. Jan Arne -- Jan Arne Petersen Openismus GmbH http://www.openismus.com

Re: [PATCH RFC] Add language and text-direction to text protocol

2013-02-01 Thread Jan Arne Petersen
On 31.01.2013 23:39, Weng Xuetian wrote: On Thursday 31 January 2013 17:44:02,Jan Arne Petersen : From: Jan Arne Petersen jpeter...@openismus.com The proposed API allows to send the language and text-direction for inserted text from an input-method to an application. It also allows

Re: [PATCH RFC] Add language and text-direction to text protocol

2013-02-01 Thread Jan Arne Petersen
On 31.01.2013 23:49, Weng Xuetian wrote: On Thursday 31 January 2013 20:50:00,Jan Arne Petersen : Currently the context is state-less but even when we add state there, in Qt, for example, there is currently just one input context per application not one per widget. Not the per-widget case

Re: Questions and thoughts about input method protocol

2013-02-01 Thread Jan Arne Petersen
will be broken or not input method friendly or whatever. But with touch based phones, tablets etc more an more people will use input methods (via virtual keyboards) and applications will improve their support. -- Jan Arne Petersen Openismus GmbH http://www.openismus.com

Re: [PATCH RFC] Add language and text-direction to text protocol

2013-02-01 Thread Jan Arne Petersen
On 01.02.2013 13:46, Yichao Yu wrote: On Fri, Feb 1, 2013 at 3:18 AM, Jan Arne Petersen jpeter...@openismus.com wrote: On 31.01.2013 23:39, Weng Xuetian wrote: And, IMHO, those hint should be set in a key-value map, instead of everytime we add some new API, hence the API would be much more

Re: [PATCH RFC] Add language and text-direction to text protocol

2013-02-01 Thread Jan Arne Petersen
On 01.02.2013 14:25, Yichao Yu wrote: On Fri, Feb 1, 2013 at 8:06 AM, Jan Arne Petersen jpeter...@openismus.com wrote: On 01.02.2013 13:46, Yichao Yu wrote: On Fri, Feb 1, 2013 at 3:18 AM, Jan Arne Petersen jpeter...@openismus.com wrote: On 31.01.2013 23:39, Weng Xuetian wrote: And, IMHO

  1   2   3   >