Re: [PATCH Weston 1/1] desktop-shell: implement autolaunch

The %m from glibc would indeed be a portability problem. However, it is already lightly used within wayland (11 occurrences) and heavily in weston (125 occurrences). I suggest you keep them for now, then clean them all up in one patch later - assuming the wayland community and prospective users

Re: [PATCH 4/4] wayland-server: Abort if a read from a client gives 0 length

Am 29.09.2014 um 06:31 schrieb Jason Ekstrand : > > On Sep 28, 2014 11:49 AM, "Karsten Otto" wrote: > > > > From: Philip Withnall > > > > This happens if the socket has been gracefully closed. > > > > [KAO: It prevents a potential inf

Re: Wayland, Weston and libinput to patchwork?

Looks like this could be really helpful. I find it difficult enough to track the state of my own patches in the list, can't imagine what its like for a maintainer. Also, it could give newcomers a good idea of what's going on in the projects, and where to jump in to help. Cheers, Karsten ___

Re: [PATCH 3/4] queue-test: Add another assertion

48 schrieb Dima Ryazanov : > I've brought this up once, but looks like it's acceptable in the test suite > since it already relies on asserts: > http://lists.freedesktop.org/archives/wayland-devel/2013-February/007454.html > > On Sep 28, 2014 6:57 PM, "Bill Spitzak&qu

[PATCH 3/4] queue-test: Add another assertion

From: Philip Withnall Ensure that the round trip succeeds. [KAO: adjusted to current test framework] Signed-off-by: Philip Withnall --- tests/queue-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/queue-test.c b/tests/queue-test.c index 96f2100..6e2e932 100644

[PATCH 1/4] connection: Fix sendmsg() on BSD systems

From: Philip Withnall BSD systems expect all unused fields in the msghdr struct to be initialized to 0 and NULL respectively, and returns EINVAL otherwise. It can't hurt to be tidy about things on other platforms either though. [KAO: Make comments refer to all BSD-like systems] --- src/connecti

[PATCH 4/4] wayland-server: Abort if a read from a client gives 0 length

From: Philip Withnall This happens if the socket has been gracefully closed. [KAO: It prevents a potential infinite loop when using a different event handling mechanism than epoll, if said mechanism cannot distinguish EOF from regular read (e.g. select).] --- src/wayland-server.c | 2 +- 1 file

[PATCH 2/4] event-loop.c: Use correct OS abstraction function for dupfd()

From: Philip Withnall Signed-off-by: Philip Withnall --- src/event-loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/event-loop.c b/src/event-loop.c index a149db9..1f571ba 100644 --- a/src/event-loop.c +++ b/src/event-loop.c @@ -134,7 +134,7 @@ wl_event_loop_add_fd(

Re: [PATCH 3/4] wayland-server: Abort if a read from a client gives 0 length

Am 22.09.2014 um 10:49 schrieb Pekka Paalanen : > On Thu, 11 Sep 2014 21:42:26 +0200 > Karsten Otto wrote: > >> From: Philip Withnall >> Date: Fri, 15 Feb 2013 12:57:05 + >> >> This happens if the socket has been gracefully closed. >> >> Sig

[PATCH] Do not abort() the compositor when dup fails during fd marshalling

Treat dup failures as a marshalling error and return NULL. The compositor will destroy the offending client but keep other clients intact. A client entcountering dup failure will still abort(), as it does on other marshalling errors. Signed-off-by: Karsten Otto --- src/connection.c| 13

[PATCH 4/4] queue-test: Add another assertion

From: Philip Withnall Date: Fri, 15 Feb 2013 12:57:23 + Ensure that the round trip succeeds. [kao: adjusted patch to current test framework style] Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto --- tests/queue-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 3/4] wayland-server: Abort if a read from a client gives 0 length

From: Philip Withnall Date: Fri, 15 Feb 2013 12:57:05 + This happens if the socket has been gracefully closed. Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto --- src/wayland-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src

[PATCH 2/4] event-loop.c: Use correct OS abstraction function for dupfd()

From: Philip Withnall Date: Fri, 15 Feb 2013 12:56:52 + Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto --- src/event-loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/event-loop.c b/src/event-loop.c index a149db9..1f571ba 100644 --- a/src/event

[PATCH 1/4] connection: Fix sendmsg() on FreeBSD

eply2 Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto --- src/connection.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index f292853..c4eb354 100644 --- a/src/connection.c +++ b/src/connection.c @@ -287,10 +2

[PATCH wayland] Portability: Simple stability improvements and cleanups

A selection of simple patches to improve general stability of wayland. They are harmless enough to be included anytime, maybe even for 1.6, but no rush. Tested on ubuntu 14.04 LTS with wayland/weston (>1.5.92) The patches were originally posted by Philip Withnall in his series of FreeBSD portabi