Re: [RFC wayland-protocols v2] Introduce the restricted_registry protocol

2015-11-25 Thread Mariusz Ceier
Hi, It's missing README, but otherwise it looks good to me: Reviewed-by: Mariusz Ceier Mariusz Ceier On 25 November 2015 at 15:10, Giulio Camuffo wrote: > This new extension is used by clients wanting to execute priviledged > actions such as taking a screenshot. > Th

Re: [PATCH] Introduce the authorizer protocol

2015-11-25 Thread Mariusz Ceier
Hi, On 25 November 2015 at 16:14, Pekka Paalanen wrote: > On Tue, 24 Nov 2015 18:07:34 +0100 > Mariusz Ceier wrote: > > > Hi, > > > > On 24 November 2015 at 17:35, Giulio Camuffo > > wrote: > > > > > 2015-11-24 18:16 GMT+02:00 Mariusz Ceier :

Re: [PATCH] Introduce the authorizer protocol

2015-11-24 Thread Mariusz Ceier
Hi, On 24 November 2015 at 17:35, Giulio Camuffo wrote: > 2015-11-24 18:16 GMT+02:00 Mariusz Ceier : > > Hi, > > How the clients will know: > > a) which interface is restricted and which is not ? > > It doesn't, but does it need to know it? It can still ask

Re: [PATCH] Introduce the authorizer protocol

2015-11-24 Thread Mariusz Ceier
- probably causing compositor to show many popups/notifications. I think it would be better to send list of interfaces and receive back a list of interfaces for which access was granted instead. Mariusz Ceier On 24 November 2015 at 16:16, Giulio Camuffo wrote: > This new extension is used

Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer interface

2015-11-23 Thread Mariusz Ceier
physical motion is not guaranteed. > + > + If the client needs button events or focus state, it can receive > them > + from a wl_pointer object of the same seat that the > wp_relative_pointer > + object is associated with. > + > + > + + summary="high 32 bits of a 64 bit timestamp with microsecond > granularity"/> > + + summary="low 32 bits of a 64 bit timestamp with microsecond > granularity"/> > + + summary="the x component of the motion vector"/> > + + summary="the y component of the motion vector"/> > + + summary="the x component of the unaccelerated motion vector"/> > + + summary="the y component of the unaccelerated motion vector"/> > + > + > + > + > -- > 2.4.3 > > Mariusz Ceier ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 00/10] weston wayland-protocols migration

2015-11-04 Thread Mariusz Ceier
le to compile weston. If that's not an issue: Reviewed-by: Mariusz Ceier Mariusz Ceier On 4 November 2015 at 09:49, Jonas Ådahl wrote: > Hi, > > This series changes weston to depend on wayland-protocols for the > majority of the protocols previously in the protocols/ directory. The

Re: Unstable protocol name breakage

2015-10-19 Thread Mariusz Ceier
On 20 October 2015 at 05:59, Jonas Ådahl wrote: > On Tue, Oct 20, 2015 at 05:26:45AM +0200, Mariusz Ceier wrote: > > Hi, > > > > On 20 October 2015 at 04:22, Jonas Ådahl wrote: > > > > > Hi again, > > > > > > I was about to start migrating

Re: Unstable protocol name breakage

2015-10-19 Thread Mariusz Ceier
rsor-position.xml, weston-test.xml, workspaces.xml) I plan to leave > them > be, as they either are purely weston internal, simple toy protocols or > have no > consesus that they are to be ever be official protocols. > > So what should we do about these naming

Re: State of Wayland protocol development

2015-10-09 Thread Mariusz Ceier
enough so we could always > > >> just rely on the pkg-config version check in configure.ac? That would > > >> be fine too. > > > > > > I don't think we should restrict ourself to using it as a git > submodule. > > > It would for example not be possible if you use Mercurial or some other > > > version control system (SDL comes to mind as an example of that). > > > Releases could be made on-demand, meaning it wouldn't be a problem for > > > weston to depend on a particular version. > > > > > > I'd also expect weston master to depend on wayland master as well as > > > wayland-protocols master, far that matter. > > > > Agreed, but indeed that doesn't preclude Weston from using it as a git > > submodule - just as long as we're considerate of other users who will > > need releases. > > True. Not that I see the actual point though (I only see the installing > being less tested). > > > > > Thanks a lot for doing this Jonas; it sounds good to me. How about we: > > - wait until Monday or Tuesday to see if anyone can pick concrete > > holes in this proposal > > AFAIU Wayland development is the least active on weekends so can just > wait for some more days so work-days contributors have the time to > react. > > - if none, I can create the repository then, with the usual Wayland ACL > > - patch Weston master to include protocols as a submodule > > - patch Weston to move its development protocols (xdg-shell, > > linux-dmabuf, presentation_timing, scaler) to protocols > > - go ahead and commit the protocols you and Carlos have been working > > on (gestures, pointer-lock/rel-pointer, new DnD) > > - document all of the above > > Sounds like a plan to me, except the DND changes poke at wayland.xml and > moving wayland.xml into wayland-protocols/ is not something I've thought > very much about. Should we? > > > > > I'll ack the Weston patches as long as they pass distcheck, and you > > can then just commit them directly. > > > > Cheers, > > Daniel > > > Jonas > Mariusz Ceier ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [RFC wayland] cpp-test: check for C++ compiler

2014-12-19 Thread Mariusz Ceier
This won't work when there's C++ compiler but no 'which', but I think that's ok, since it only affects 1 test. Reviewed-by: Mariusz Ceier On 19 December 2014 at 17:40, Marek Chalupa wrote: > > Do not try to build it if no C++ compiler is present &

Re: [PATCH wayland 1/2] tests: C++ compilation test

2014-12-19 Thread Mariusz Ceier
Hi, On 19 December 2014 at 15:20, Marek Chalupa wrote: > > Hi, > > git tells me that this patch adds white space error (new line before EOF) > > On 15 December 2014 at 11:33, Mariusz Ceier > wrote: >> >> This test includes one of wayland headers, which produ

[PATCH wayland v2 2/2] scanner: Fix header generation for server protocols

2014-12-15 Thread Mariusz Ceier
Server protocols headers should include wayland-server.h, instead of wayland-util.h. Otherwise they're not useable with C++ compiler unless wayland-server.h was included earlier. Signed-off-by: Mariusz Ceier --- Notes: v2: s/generatation/generation/ src/scanner.c | 2 +- 1 file chang

[PATCH wayland 2/2] scanner: Fix header generatation for server protocols

2014-12-15 Thread Mariusz Ceier
Server protocols headers should include wayland-server.h, instead of wayland-util.h. Otherwise they're not useable with C++ compiler unless wayland-server.h was included earlier. Signed-off-by: Mariusz Ceier --- src/scanner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH wayland 1/2] tests: C++ compilation test

2014-12-15 Thread Mariusz Ceier
rning: implicit declaration of function ‘wl_resource_post_event’ Signed-off-by: Mariusz Ceier --- Makefile.am| 4 +++- configure.ac | 1 + tests/cpp-compile-test.cpp | 5 + 3 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 tests/cpp-compile-test.cpp

Re: [PATCH weston] Destroy resources when destroying an output

2014-05-08 Thread Mariusz Ceier
Hi, I sent similar patch in the past, and this reply from Pekka may be still relevant: http://lists.freedesktop.org/archives/wayland-devel/2013-December/012691.html Mariusz Ceier On 8 May 2014 19:38, Neil Roberts wrote: > When an output is destroyed it now also destroys any resources t

[PATCH weston] Don't include xserver-server-protocol.h

2014-04-07 Thread Mariusz Ceier
It was removed in 757d8aff2757387bcd594e2ee2a27055b366eac3, along with xserver protocol. Signed-off-by: Mariusz Ceier --- xwayland/dnd.c| 1 - xwayland/launcher.c | 1 - xwayland/window-manager.c | 1 - 3 files changed, 3 deletions(-) diff --git a/xwayland/dnd.c b/xwayland

[PATCH] [weston] Don't crash when eglCreateContext fails

2014-02-08 Thread Mariusz Ceier
eglCreateContext fails with every EGLConfig that nvidia blob 334.16 provides causing NULL pointer dereference in gl_renderer_destroy when destroying fragment and fan bindings. This should fix #74699. Signed-off-by: Mariusz Ceier --- src/gl-renderer.c | 6 -- 1 file changed, 4 insertions

Re: [PATCH wayland] tests/resources-test: Fix wl_resource_post_event call

2014-01-06 Thread Mariusz Ceier
I think both patches (and original code too obviously) are wrong - WL_DISPLAY_ERROR (opcode 0) event has signature "ous", so Quentin patch calls event with too many arguments and ignores types, and Marek patch calls event with too few arguments and incorrect type for the second argument. Imo, corre

[PATCH] Destroy resources when destroying input and output

2013-12-25 Thread Mariusz Ceier
structures are freed. That fixes at least x11 and freerds backend. Signed-off-by: Mariusz Ceier --- src/compositor.c | 4 src/input.c | 15 --- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index ff0f3ab..a4077e8 100644 --- a

Re: [PATCH 1/1] Add a FreeRds backend, take 3

2013-12-23 Thread Mariusz Ceier
> >> >> 2) When using windows remote desktop client, weston exits after >> accepting connection due to SIGPIPE signal. Here's backtrace: >> ==31717== >> ==31717== Process terminating with default action of signal 13 (SIGPIPE) >> ==31717==at 0x6080AD0: __write_nocancel (syscall-template.S:81) >>

[PATCH] Add missing return

2013-09-10 Thread Mariusz Ceier
Signed-off-by: Mariusz Ceier --- src/data-device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/data-device.c b/src/data-device.c index ec3df33..8de5063 100644 --- a/src/data-device.c +++ b/src/data-device.c @@ -393,6 +393,7 @@ weston_seat_start_drag(struct weston_seat *seat

Re: [PATCH weston] window: fix NULL pointer dereference

2013-07-16 Thread Mariusz Ceier
I used attached program to trigger it - it's modified fullscreen.c client with 2 subsurfaces. When I run it, press 'f' to make the main surface fullscreen and move pointer over blue border, I get the crash. On 16 July 2013 18:59, Rob Bradford wrote: > On 16 July 2013 01

[PATCH weston] window: fix NULL pointer dereference

2013-07-15 Thread Mariusz Ceier
NULL pointer dereference happens when input->focus_widget == NULL and input->grab == NULL. Signed-off-by: Mariusz Ceier --- clients/window.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/clients/window.c b/clients/window.c index cbfe12f..9933cb9

[PATCH wayland] connection: Handle empty signature and signature with just a version.

2013-07-10 Thread Mariusz Ceier
7;\0' value, signaling end of arguments. Signed-off-by: Mariusz Ceier --- src/connection.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/connection.c b/src/connection.c index 2ca9bce..9bb850c 100644 --- a/src/connection.c +++ b/src/connection.c @@ -419,6 +419,7 @@ get_next_arg