Re: [PATCH v4] Fixes CJK wide character display

2013-08-19 Thread Othman, Ossama
Hi, CCing the list this time around ... On Sun, Aug 18, 2013 at 7:59 PM, Peng Wu wrote: > By jumping two columns when wide character prints, > and draw wide background under wide character. > --- > clients/terminal.c | 31 +-- > 1 file changed, 29 insertions(+), 2 d

Re: [PATCH weston v2 4/4] weston.pc: Provide moduledir

2013-06-10 Thread Othman, Ossama
Hi, --- a/src/Makefile.am > +++ b/src/Makefile.am > @@ -94,7 +94,6 @@ westoninclude_HEADERS = \ > ../shared/matrix.h \ > ../shared/config-parser.h > > -moduledir = $(libdir)/weston > module_LTLIBRARIES =

Re: [PATCH] configure.ac: Do not make missing colord or libunwind a hard failure

2013-06-03 Thread Othman, Ossama
Hi Daniel, On Mon, Jun 3, 2013 at 11:45 AM, Daniel Stone wrote: > > The usual pattern here is to set the default to 'auto', which will > check whether or not the dependency is installed and select yes or no > accordingly. If someone explicitly passes --enable-colord and it's > not installed, we

Re: Compiling weston now needs colord

2013-06-03 Thread Othman, Ossama
Hi, On Thu, May 30, 2013 at 12:42 AM, wrote: > On 30/05/2013 08:24, Michael Hasselmann wrote: > >> On Tue, 2013-05-28 at 22:16 -0700, Bill Spitzak wrote: >> >>> Running autogen.sh in weston with --disable-colord works to avoid this, >>> I suspect nothing I care about is lost this way. >>> >> >>

Re: [PATCH] wfits: run without superuser

2013-05-31 Thread Othman, Ossama
Hi, On Fri, May 31, 2013 at 8:14 AM, Martin Minarik < minari...@student.fiit.stuba.sk> wrote: > > diff --git a/src/extensions/weston/weston-wfits.cpp > b/src/extensions/weston/weston-wfits.cpp > index a54e0fe..96cf617 100644 > --- a/src/extensions/weston/weston-wfits.cpp > +++ b/src/extensions/wes

Re: [PATCH weston] fix module_init signature in module tests

2013-05-17 Thread Othman, Ossama
Hi Artie, Sorry about that. I didn't realize some Weston binaries were only built under the "check" target. I'll run "make distcheck" the next time around. Thanks for the fix! -Ossama On Fri, May 17, 2013 at 6:12 AM, U. Artie Eoff wrote: > From: "U. Artie Eoff" > > surface-global-test and

Re: [PATCH] config-parser: Honor the XDG_CONFIG_DIRS environment variable

2013-05-14 Thread Othman, Ossama
Hi Kristian, On Tue, May 14, 2013 at 1:57 PM, Kristian Høgsberg wrote: > On Tue, May 14, 2013 at 09:55:19AM -0700, Othman, Ossama wrote: > > I've attached the patch since the patch I sent through git send-mail was > > sent through an e-mail account that isn't subscribe

Re: [PATCH] config-parser: Honor the XDG_CONFIG_DIRS environment variable

2013-05-14 Thread Othman, Ossama
ster as of this morning. Sorry for the churn. -Ossama On Tue, May 14, 2013 at 7:05 AM, Kristian Høgsberg wrote: > On Mon, May 13, 2013 at 11:41 PM, Othman, Ossama > wrote: > > Hi Kristian, > > > >> I think it's good to go - however, inlining the patch messed up th

Re: [PATCH] config-parser: Honor the XDG_CONFIG_DIRS environment variable

2013-05-13 Thread Othman, Ossama
Hi Kristian, I think it's good to go - however, inlining the patch messed up the > whitespace. Ideally, send patches using git send-email, which can be > configured to use smtp servers, and you can pass --annotate if you > want to add a message or comment to the patch (put it after the --- > that

Re: [PATCH] config-parser: Honor the XDG_CONFIG_DIRS environment variable

2013-05-12 Thread Othman, Ossama
t in weston_compositor object. The > config path patch here is somewhat orthogonal to that though. > > On Sun, May 12, 2013 at 2:20 AM, Othman, Ossama > wrote: > ... > > + info.count = 0; > > + info.paths = malloc(DEFAULT_DIR_COUNT * sizeof(char *)); > > + if (in

Re: [PATCH] config-parser: Honor the XDG_CONFIG_DIRS environment variable

2013-05-11 Thread Othman, Ossama
I've revised the patch to build a list of possible filenames as Bill suggested. This time around I've included a patch for the man page, as well. Thanks! -Ossama --- Search for a given config file in the directories listed in $XDG_CONFIG_DIRS if it wasn't found in $XDG_CONFIG_HOME or ~/.config.

Re: [PATCH] config-parser: Honor the XDG_CONFIG_DIRS environment variable

2013-05-11 Thread Othman, Ossama
Hi Bill, That's a great suggestion. I'll rework the patch. Thanks! -Ossama On Fri, May 10, 2013 at 5:32 PM, Bill Spitzak wrote: > > > Othman, Ossama wrote: > >> Hi, >> >> Minor correction to my previous patch. This revision corrects a small >&

Re: [PATCH] config-parser: Honor the XDG_CONFIG_DIRS environment variable

2013-05-10 Thread Othman, Ossama
Hi, Minor correction to my previous patch. This revision corrects a small leak in config_file_path_xdg_config_dirs(). Thanks! -Ossama --- Search for a given config file in the directories listed in $XDG_CONFIG_DIRS if it wasn't found in $XDG_CONFIG_HOME or ~/.config. This allows packages to i

[PATCH] config-parser: Honor the XDG_CONFIG_DIRS environment variable

2013-05-10 Thread Othman, Ossama
Search for a given config file in the directories listed in $XDG_CONFIG_DIRS if it wasn't found in $XDG_CONFIG_HOME or ~/.config. This allows packages to install custom config files in /etc/xdg/weston, for example, thus allowing them to avoid dealing with home directories. Signed-off-by: Ossama Ot