Re: [PATCH v7] unstable/drm-lease: DRM lease protocol support

2019-10-18 Thread Philipp Zabel
On Fri, 2019-10-18 at 10:43 -0400, Drew DeVault wrote: > Regarding hotplugging, the Wayland compositor is probably keeping track > of hotplugs itself and withdrawing/offering connectors as appropriate. > > Also, when the lease is issued, the compositor withdraws that connector. > For the client, up

Re: [PATCH v7] unstable/drm-lease: DRM lease protocol support

2019-10-18 Thread Philipp Zabel
On Fri, 2019-10-18 at 08:51 +, Simon Ser wrote: > On Thursday, October 17, 2019 11:15 PM, Drew DeVault wrote: > > > On Thu Oct 17, 2019 at 6:08 PM Simon Ser wrote: > > > > > Should we keep the connector event, now that we have an unprivileged > > > DRM FD? > > > Alternatives include: > > >

Re: [PATCH v2] unstable/drm-lease: DRM lease protocol support

2019-07-03 Thread Philipp Zabel
On Tue, 2019-07-02 at 13:30 -0400, Drew DeVault wrote: > From: Marius Vlad > > DRM leasing is a feature which allows the DRM master to "lease" a subset > of its DRM resources to another DRM master via drmModeCreateLease, which > returns a file descriptor for the new DRM master. We use this protoc

Re: [PATCH] unstable/drm-lease: DRM lease protocol support

2019-06-28 Thread Philipp Zabel
Hi Pekka, On Fri, 2019-06-28 at 12:58 +0300, Pekka Paalanen wrote: > On Fri, 28 Jun 2019 11:23:53 +0200 > Philipp Zabel wrote: > > On Thu, 2019-06-27 at 20:36 +, Simon Ser wrote: > > > What would be other use-cases for DRM leases? Probably fullscreen games? > >

Re: [PATCH] unstable/drm-lease: DRM lease protocol support

2019-06-28 Thread Philipp Zabel
On Thu, 2019-06-27 at 20:36 +, Simon Ser wrote: [...] > > + > > + > > +The compositor may choose to advertise 0 or more connectors which > > may be > > +leased to clients, and will use this event to do so. This object > > may be > > +passed into a lease reque

Re: Fw: How in the world do I find out the size of a surface in a Wayland client???

2019-06-12 Thread Philipp Zabel
Hi, On Wed, 2019-06-12 at 05:20 +, happysmash27 wrote: > I am trying to make a Wayland program, and my compositor is Sway. To > make it work well, I want my program to use the output size that Sway > gives it. The question is... how in the world do I find out what that > size actually is??? I

Re: [RFC wayland-protocols v2 0/1] Color Management Protocol

2019-03-07 Thread Philipp Zabel
On Wed, 2019-03-06 at 18:09 +0100, Sebastian Wick wrote: [...] > 4. How do universal planes handle gamma when blending? This hopefully >has a sinmple answer and there probably is some documention which >I just can't find. I think they currently don't, and it will depend on the driver. Ther

Re: [RFC wayland-protocols 1/1] unstable: add color management protocol

2019-02-14 Thread Philipp Zabel
On Wed, 2019-02-13 at 21:47 -0700, Chris Murphy wrote: > On Wed, Feb 13, 2019 at 7:55 PM Sebastian Wick > wrote: > > > > + > > I suggest ICC spec language. 'ICC-absolute colorimetric' > > > + > > 'media-relative colorimetric' > > > > + > > I think this is 'deviceRGB' alt

Re: [PATCH RFC wayland-protocols] unstable/linux-dmabuf: add wp_linux_dmabuf_device_hint

2018-11-15 Thread Philipp Zabel
Hi Pekka, thank you for the explanation. On Wed, 2018-11-14 at 11:03 +0200, Pekka Paalanen wrote: [...] > The hints protocol we are discussing here is a subset of what > https://github.com/cubanismo/allocator aims to achieve. Originally we > only concentrated on getting the format and modifier mo

Re: [PATCH RFC wayland-protocols] unstable/linux-dmabuf: add wp_linux_dmabuf_device_hint

2018-11-12 Thread Philipp Zabel
Hi Simon, On Fri, 2018-11-02 at 18:49 +, Simon Ser wrote: > On Friday, November 2, 2018 12:30 PM, Philipp Zabel > wrote: > > > > + > > > > + > > > > +This event advertizes the primary device that the server > > > >

Re: [PATCH RFC wayland-protocols] unstable/linux-dmabuf: add wp_linux_dmabuf_device_hint

2018-11-02 Thread Philipp Zabel
On Thu, 2018-11-01 at 17:04 +, Daniel Stone wrote: > Hi Simon, > Thanks a lot for taking this on! :) > > On Thu, 1 Nov 2018 at 16:45, Simon Ser wrote: > > This commit introduces a new wp_linux_dmabuf_device_hints object. This > > object > > advertizes a preferred device via a file descriptor

Re: [PATCH wayland-protocols v5] unstable/drm-lease: DRM lease protocol support

2018-09-06 Thread Philipp Zabel
Hi Marius, On Thu, 2018-09-06 at 11:29 +, Marius-cristian Vlad wrote: > > [...] > > > - removed 'revoked' event entirely as it adds complexity without > > > adding > > > too much benefit. > > > > The client will notice this via the leased drm fd sooner or later > > anyway, so it seems that th

Re: [PATCH wayland-protocols v5] unstable/drm-lease: DRM lease protocol support

2018-09-04 Thread Philipp Zabel
Hi Marius, thank you for the update! Am Dienstag, den 04.09.2018, 17:39 +0300 schrieb Marius Vlad: > Simple protocol extension to manage DRM lease. Based on the work by > Keith > Packard in [1], respectively [2]. > > [1] > https://cgit.freedesktop.org/mesa/drm/commit/?id=c4171535389d72e9135c961

Re: [PATCH wayland-protocols v4] unstable/drm-lease: DRM lease protocol support

2018-08-30 Thread Philipp Zabel
On Thu, 2018-08-30 at 11:01 +, Marius-cristian Vlad wrote: [...] > > One interesting question is how to handle the situation when the > > client deliberately, or not, holds the lease indefinitely. > > The client implicitly cancels the lease by closing the lease fd (or by > having it closed au

Re: [PATCH wayland-protocols v4] unstable/drm-lease: DRM lease protocol support

2018-08-30 Thread Philipp Zabel
; - instead of advertising all leasable connectors at once, advertise each > connector for each leasable output. Use an object to represent a > leasable connector and provide a request to add that leasable connector > when creating the lease (Philipp Zabel) > - add two events to handle

Re: [PATCH wayland-protocols v3] unstable/drm-lease: DRM lease protocol support

2018-08-24 Thread Philipp Zabel
Hi Marius, On Fri, 2018-08-24 at 09:21 +, Marius-cristian Vlad wrote: > On Fri, 2018-08-24 at 10:57 +0200, Philipp Zabel wrote: [...] > > > yes, sending one event per connector is a good design, but see > > > below if we actually might want to extend that to creatin

Re: [PATCH wayland-protocols v3] unstable/drm-lease: DRM lease protocol support

2018-08-24 Thread Philipp Zabel
Hi Pekka, On Thu, 2018-08-23 at 14:39 +0300, Pekka Paalanen wrote: > Sorry for the potentially duplicate email, my MUA messed up the CC list > on the first go. > > > On Thu, 23 Aug 2018 08:41:30 +0200 > Philipp Zabel wrote: > > > Hi, > > > > On Wed, 201

Re: [PATCH wayland-protocols v3] unstable/drm-lease: DRM lease protocol support

2018-08-22 Thread Philipp Zabel
On Mon, 2018-08-20 at 23:00 +0300, Marius Vlad wrote: [...] > + > + > + This interface is used for managing zwp_kms_lease_v1 object. It is used > + to create a zwp_kms_lease_v1 object (the actual lease object) and also > to > + revoke the lease. > + > + > + > + >

Re: [PATCH wayland-protocols v3] unstable/drm-lease: DRM lease protocol support

2018-08-22 Thread Philipp Zabel
Hi, On Wed, 2018-08-22 at 11:12 +, Marius-cristian Vlad wrote: [...] > > Why not just send the connectors one by one, a single event with all > > relevant information for each? > > Hmm, okay, I'll try do that. I'm wondering what should be used to identify a connector to a hypothetical Vulka

Re: [PATCH wayland-protocols v3] unstable/drm-lease: DRM lease protocol support

2018-08-22 Thread Philipp Zabel
On Wed, 2018-08-22 at 09:24 -0700, Keith Packard wrote: > Marius-cristian Vlad writes: > > > > Can't the client query available modes on the passed connector via > > > the > > > leased fd? > > > > That's how the client does it now, it uses the leased fd to query > > available modes. Presumably t

Re: [PATCH wayland-protocols v3] unstable/drm-lease: DRM lease protocol support

2018-08-22 Thread Philipp Zabel
Hi Marius, On Mon, 2018-08-20 at 23:00 +0300, Marius Vlad wrote: > Simple protocol extension to manage DRM lease. Based on the work by Keith > Packard in [1], respectively [2]. > > [1] > https://cgit.freedesktop.org/mesa/drm/commit/?id=c4171535389d72e9135c9615cecd07b346fd6d7e > [2] > https://gi

Re: Advertising supported Dmabuf modifiers of DRM device

2018-07-27 Thread Philipp Zabel
of modifiers to clients depending on the > situation. Could this be used to notify Vulkan clients that they should reallocate their swapchain for better performance, by setting swapchain status to VK_SUBOPTIMAL_KHR? regards Philipp --8<-- Author: Philipp Zabe

Re: [PATCH weston 1/2 v3] compositor-drm: Add support for DRM lease

2018-02-21 Thread Philipp Zabel
Hi Marius, On Wed, 2018-02-21 at 16:49 +0200, Marius Vlad wrote: > Signed-off-by: Marius Vlad > --- > Makefile.am| 2 + > compositor/main.c | 9 ++ > configure.ac | 4 + > libweston/compositor-drm.c | 272 > +++

Re: [PATCH v14 03/41] compositor-drm: Introduce drm_plane_state structure

2018-01-29 Thread Philipp Zabel
Hi Daniel, On Wed, 2017-12-20 at 12:26 +, Daniel Stone wrote: > Track dynamic plane state (CRTC, FB, position) in separate structures, > rather than as part of the plane. This will make it easier to handle > state management later, and much more closely tracks what the kernel > does with atomi

[PATCH v2 2/2] gl-renderer: return conservative format list if dmabuf import modifiers unsupported

2018-01-17 Thread Philipp Zabel
If the EGL_EXT_image_dma_buf_import_modifiers extension is not supported, let gl_renderer_query_dmabuf_formats return a hardcoded fallback list. That list contains ARGB, XRGB, and if the GL_EXT_texture_rg extension is supported, YUYV, NV12, YUV420, and YUV444. Signed-off-by: Philipp Zabel

[PATCH v2 1/2] linux-dmabuf: send deprecated format events

2018-01-17 Thread Philipp Zabel
before version 3, skipping formats that only support non-linear modifiers. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- No changes since v1. --- libweston/linux-dmabuf.c | 19 --- libweston/linux-dmabuf.h | 3 +++ 2 files changed, 15 insertions(+), 7 deletions

Re: [PATCH] linux-dmabuf: send deprecated format events

2018-01-16 Thread Philipp Zabel
On Fri, 2017-12-15 at 09:46 +, Daniel Stone wrote: > Hi Michael and Philipp, > > On 15 December 2017 at 09:25, Philipp Zabel wrote: > > Although the format event is deprecated, some clients, especially the > > GStreamer waylandsink, only support zwp_linux_dmabuf_v1 vers

Re: [PATCH v14 17/41] compositor-drm: Atomic modesetting support

2018-01-03 Thread Philipp Zabel
Hi Daniel, I think drm_pending_state_apply_atomic (or its callers) leak pending_state: On Wed, 2017-12-20 at 12:26 +, Daniel Stone wrote: > +static int > +drm_pending_state_apply_atomic(struct drm_pending_state *pending_state, > +enum drm_state_apply_mode mode) > +

Re: [PATCH v14 37/41] compositor-drm: Add test-only mode to state application

2018-01-03 Thread Philipp Zabel
On Wed, 2017-12-20 at 12:26 +, Daniel Stone wrote: > @@ -2424,9 +2453,16 @@ drm_pending_state_apply_atomic(struct > drm_pending_state *pending_state, > case DRM_STATE_APPLY_ASYNC: > flags |= DRM_MODE_PAGE_FLIP_EVENT | DRM_MODE_ATOMIC_NONBLOCK; > break; > +

Re: [PATCH] linux-dmabuf: send deprecated format events

2017-12-15 Thread Philipp Zabel
On Fri, 2017-12-15 at 10:51 +, Daniel Stone wrote: > Hi Philipp, > > On 15 December 2017 at 10:46, Philipp Zabel wrote: > > On Fri, 2017-12-15 at 09:46 +, Daniel Stone wrote: > > > On 15 December 2017 at 09:25, Philipp Zabel > > > wrote: > >

Re: [PATCH] linux-dmabuf: send deprecated format events

2017-12-15 Thread Philipp Zabel
Hi Daniel, On Fri, 2017-12-15 at 09:46 +, Daniel Stone wrote: > Hi Michael and Philipp, > > On 15 December 2017 at 09:25, Philipp Zabel wrote: > > Although the format event is deprecated, some clients, especially the > > GStreamer waylandsink, only support zwp_linux_dm

[PATCH] linux-dmabuf: send deprecated format events

2017-12-15 Thread Philipp Zabel
before version 3, skipping formats that only support non-linear modifiers. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- libweston/linux-dmabuf.c | 19 --- libweston/linux-dmabuf.h | 3 +++ 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/libweston

Re: [PATCH wayland-protocols 1/3] Add meson build system support

2017-12-05 Thread Philipp Zabel
Signed-off-by: Jonas Ådahl > --- > meson.build | 81 > + > meson_options.txt | 4 +++ > tests/meson.build | 13 > wayland-protocols.pc.in | 2 +- > 4 files changed, 99 insertions(+), 1 deletion(-) > create mode

Re: [PATCH weston v12 09/40] compositor-drm: Move repaint state application to flush

2017-09-27 Thread Philipp Zabel
Hi Daniel, On Tue, 2017-09-26 at 18:15 +0100, Daniel Stone wrote: > Split repaint into two stages, as implied by the grouped-repaint > interface: drm_output_repaint generates the repaint state only, and > drm_repaint_flush applies it. > > This also moves DPMS into output state. Previously, the us

Re: [PATCH weston v12 27/40] compositor-drm: Add modifiers to GBM dmabuf import

2017-09-27 Thread Philipp Zabel
On Tue, 2017-09-26 at 18:16 +0100, Daniel Stone wrote: > Add support for the GBM_BO_IMPORT_FD_MODIFIER path, which allows us to > import multi-plane dmabufs, as well as format modifiers. > > Signed-off-by: Daniel Stone > --- >  configure.ac   |   3 - >  libweston/compositor-drm.c | 18

Re: [PATCH weston v12 16/40] compositor-drm: Allow disabling atomic

2017-09-27 Thread Philipp Zabel
Hi Daniel, On Tue, 2017-09-26 at 18:15 +0100, Daniel Stone wrote: > Add a test environment variable to allow disabling atomic modesetting. > > > Signed-off-by: Daniel Stone > --- >  libweston/compositor-drm.c | 12 +++- >  1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/

Re: [PATCH weston v11 10/13] compositor-drm: Use drm_plane for scanout plane

2017-07-21 Thread Philipp Zabel
Hi Daniel, On Tue, 2017-07-18 at 14:14 +0100, Daniel Stone wrote: > Use a real drm_plane to back the scanout plane, displacing > output->fb_{last,cur,pending} to their plane-tracked equivalents. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 157 >

Re: wl_output ambiguity, xdg_shell fullscreen refresh rate

2017-05-16 Thread Philipp Zabel
On Mon, 2017-05-15 at 17:51 +0200, Philipp Kerling wrote: > 2017-05-15 (月) の 12:19 +0200 に Philipp Zabel さんは書きました: > > On Mon, 2017-05-15 at 11:18 +0300, Pekka Paalanen wrote: > > > On Sun, 14 May 2017 14:43:44 +0200 > > > Philipp Kerling wrote: > > >

Re: wl_output ambiguity, xdg_shell fullscreen refresh rate

2017-05-15 Thread Philipp Zabel
On Mon, 2017-05-15 at 11:18 +0300, Pekka Paalanen wrote: > On Sun, 14 May 2017 14:43:44 +0200 > Philipp Kerling wrote: > > > Hi Wayland team and community, > > > > allow me to quickly introduce myself first, since this is my first post > > on this list. > > I'm Philipp, studying Computer Enginee

[PATCH] configure.ac: Add AC_SYS_LARGEFILE

2017-05-02 Thread Philipp Zabel
Allow to enable large file support on 32-bit systems. Signed-off-by: Philipp Zabel --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index a87ad0d..92911f7 100644 --- a/configure.ac +++ b/configure.ac @@ -37,6 +37,8 @@ AM_MAINTAINER_MODE([enable

[PATCH] libweston: fix pixel-format helpers compilation on non-X11 EGL platforms

2017-04-12 Thread Philipp Zabel
/include/EGL/egl.h:39:0, from libweston/pixel-formats.c:39: [...]/usr/include/EGL/eglplatform.h:119:22: fatal error: X11/Xlib.h: No such file or directory Fixes: 903721a6215f ("libweston: Add pixel-format helpers") Signed-off-by: Philipp Zabel --- Makefile.am | 2 +- 1 file