Re: [RFC libinput] Import buttonset interface

2016-05-03 Thread PrasannaKumar Muralidharan
> simply said, I don't know. It's one of the things where we have to write > most of the interface, see if it makes sense and then remove the bits that > we don't actually need. your main target right now is a rotary encoder > but I do encourage you to think of how to deal with other devices that a

Re: [RFC libinput] Import buttonset interface

2016-04-22 Thread PrasannaKumar Muralidharan
> fwiw, it's very frowned upon to take someone else's patch, rebase it and > then send it on as your own when it has very little changes. Please keep > original authorship while it makes sense and add the author as co-author > where substantial changes have been made. I definitely did not intend t

[RFC libinput] Import buttonset interface

2016-04-21 Thread PrasannaKumar Muralidharan
From: PrasannaKumar Muralidharan Import buttonset interface code from https://github.com/whot/libinput/tree/wip/buttonbox-interface. There is no user for buttonset interface as of now. I have taken the buttonset interface code and removed code related to wacom tablet. Please review the changes

Re: [RFC libinput] Add dial input device support

2016-02-21 Thread PrasannaKumar Muralidharan
> remember that libinput is a low-level library and doesn't know about how a > specific device is being used by the layers above it. Hence a value in > degrees isn't any less useful than a value in miscellaneous units which is > what the _discrete() API bit is for. If the caller cares about units,

Re: [RFC libinput] Add dial input device support

2016-02-19 Thread PrasannaKumar Muralidharan
> right. the approach we used for this was to have an API that exports the > value in degrees and an API for get_value_discrete() or similarly named. > Look up the libinput_event_pointer*axis* API to get an idea. For several devices (example dimmers used for controlling lamps) value in degrees is

Re: [RFC libinput] Add dial input device support

2016-02-19 Thread PrasannaKumar Muralidharan
Hi Andreas, > Instead of car steering wheels I would rather mention rotaty knobs that are > common in car infotainment systems to navigate through menues. Those are > relative - you never get absolute angles just rotation ticks. > But is that the type of device you had in mind? Those devices usua

Re: [RFC libinput] Add dial input device support

2016-02-18 Thread PrasannaKumar Muralidharan
Hi Peter, Thanks for your time in looking at the patch. > First: yes, implementing support for dial interfaces is within the scope of > libinput, I think it makes sense to add this. But not quite in this form, > the various CAP flags are libinput interfaces that denote a specific > functionality.

[RFC libinput] Add dial input device support

2016-02-15 Thread PrasannaKumar Muralidharan
From: PrasannaKumar Muralidharan I am implementing dial input device support and would like to get feedback on the code that I have implemented so far. Did not implement test cases as of now, any pointers on how the test framework works will be helpful. Smartwatch can use dial input, Car can