On 8/16/18 5:24 AM, Peter Hutterer wrote:
On Fri, Aug 10, 2018 at 12:55:42PM -0500, Derek Foreman wrote:
On 2018-08-02 03:32 AM, Quentin Glidic wrote:
On 8/2/18 10:29 AM, Quentin Glidic wrote:
From: Quentin Glidic
If we start a special (grabbing) client when Weston is unfocused, it
would
On 8/2/18 10:29 AM, Quentin Glidic wrote:
From: Quentin Glidic
If we start a special (grabbing) client when Weston is unfocused, it
would lose focus when coming back to Weston.
A first attempt to fix this was 85d55540cb64bf97a08b40f79dc66843f8295d3b
but it messed with VT switching.
This fix
From: Quentin Glidic
If we start a special (grabbing) client when Weston is unfocused, it
would lose focus when coming back to Weston.
A first attempt to fix this was 85d55540cb64bf97a08b40f79dc66843f8295d3b
but it messed with VT switching.
This fix just updates the saved focus, so when Weston
From: Quentin Glidic
This reverts commit 85d55540cb64bf97a08b40f79dc66843f8295d3b.
It brought issues for proper VT switching focus handling.
Signed-off-by: Quentin Glidic
---
libweston/input.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a
o full of features, don’t you think? :-)
Then, all four patches are:
Reviewed-by: Quentin Glidic
(With or without the split.)
Thanks,
+The core focus of Weston is correctness and reliability. Weston aims to be lean
+and fast, but more importantly, to be predictable. Whilst Weston does have
kno
On 6/27/18 3:04 PM, Emil Velikov wrote:
From: Emil Velikov
Adding those to configure.ac ensures that:
- the weston.ini files are {re,}generated only when needed
- the .in files are shipped in the tarball
- all the manual handling of the above can be removed ;-)
Did you actually test tha
Hi,
On 5/31/18 5:42 AM, adlo wrote:
I am attempting to write a simple test compositor using libweston.
Here is my code so far:
https://github.com/adlocode/test-libweston-desktop
What else do I need to do in order to get it to the point where something
appears on the screen, such as a rectang
thing.
Signed-off-by: Derek Foreman > ---
Changes from v1:
Only reverts the changes in window-manager.c (and updates frame_create call
to pass NULL for icon surface.
Yeah, looks safer to me:
Reviewed-by: Quentin Glidic
I’m sure Scott will submit a complete feature soon, this way we can
fo
On 3/19/18 1:31 PM, Daniel Stone wrote:
The previous rewrite of the wayland-egl ABI checker introduced checks
for removed symbols as well as added symbols, but broke some failure
conditions. Add an explict return-code variable set in failure paths,
rather than chaining or conditions.
If we canno
("wayland-egl: use correct `nm` path when cross-compiling")
Cc: Emil Velikov
Straightforward:
Reviewed-by: Quentin Glidic
Thanks,
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index 6f59c369..514468aa 100644
--- a/Makefil
walk an uninitialized list and
dereference a NULL pointer.
Initializing the list earlier prevents this from happening.
Signed-off-by: Derek Foreman
Good catch:
Reviewed-by: Quentin Glidic
Thanks,
---
libweston-desktop/xdg-shell-v6.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
On 3/11/18 9:49 PM, Simon Ser wrote:
[snip]
+
+
+
+ This interface permits choosing between client-side and server-side
+ window decorations for a toplevel surface.
+
+ A window decoration is a user interface component used to move, resize
and
+ change a window's state
On 3/2/18 4:33 PM, Simon Ser wrote:
This adds a new protocol to negotiate server- and client-side rendering of
window decorations for xdg-toplevels. This allows compositors that want
to draw decorations themselves to send their preference to clients, and
clients that prefer server-side decoration
(I wonder if Pekka or Daniel would like to be dropped off the CC list as
it may be too desktop-ish for them?)
On 3/3/18 10:58 AM, Simon Ser wrote:
Hi,
Thanks for taking time reviewing the protocol and suggesting an alternative
design.
On March 2, 2018 4:36 PM, Mike Blumenkrantz
wrote:
Hi,
From: Quentin Glidic
Signed-off-by: Quentin Glidic
---
libweston/compositor-x11.c | 64 +-
1 file changed, 29 insertions(+), 35 deletions(-)
diff --git a/libweston/compositor-x11.c b/libweston/compositor-x11.c
index 14faeda03..7675b7275 100644
--- a
From: Quentin Glidic
We discussed on IRC about races between the several event sources that
exist in libweston, libwayland and compositor code. Adding a priority
system in the event loop is a first step to fix these potential races
and help cope with bad clients.
A second issue is that
From: Quentin Glidic
This will allow compositors to pick any event loop implementation they
want, and integrating the libweston components with it.
Specifically, idle and timeout sources can now have proper priorities to
avoid being ghosted by client event processing.
Signed-off-by: Quentin
with a destroyed weston_seat */
+ if (seat == NULL)
+ parent_is_toplevel = true;
+
Good comment. Now I’m not sure if it belongs here or in
weston_desktop_seat_popup_grab_get_topmost_surface() (with a separate if).
Probably no big deal anyway.
With these 3 (not counting the comment) things fixed, the
libwe
t left as unmaintained/unused), the
libweston-desktop stuff is:
Reviewed-by: Quentin Glidic
Thanks,
+ return;
+ }
+
+ seat = weston_desktop_seat_from_seat(wseat);
+
if (popup->committed) {
wl_resource_post_error(popup->resource,
On 1/7/18 12:09 PM, Emmanuel Gil Peyrot wrote:
This was preventing weston-info from building if both
weston-simple-dmabuf-drm and weston-simple-dmabuf-v4l2 were disabled at
build-time.
Signed-off-by: Emmanuel Gil Peyrot
Reported-by: Cedric Sodhi
Tested-by: Cedric Sodhi
Reviewed-by: Quentin
On 12/8/17 3:13 PM, Matt Hoosier wrote:
On Fri, Dec 8, 2017 at 4:26 AM, Quentin Glidic
wrote:
On 12/8/17 11:22 AM, Quentin Glidic wrote:
From: Matt Hoosier
As discussed on
https://lists.freedesktop.org/archives/wayland-devel/2017-August/034720.html,
it's useful for the
On 12/8/17 11:22 AM, Quentin Glidic wrote:
From: Matt Hoosier
As discussed on
https://lists.freedesktop.org/archives/wayland-devel/2017-August/034720.html,
it's useful for the shell implementation to know when these change,
for example to relay the information on to taskbars or similar
e the weston_desktop_surface
definition public, new functions are introduced for attaching
listeners to these signals.
Signed-off-by: Matt Hoosier
Reviewed-by: Quentin Glidic
Signed-off-by: Quentin Glidic
---
libweston-desktop/libweston-desktop.h | 3 +++
libweston-desktop/surface.c
From: Quentin Glidic
This fixes a race between Xwayland committing the surface content via
the wl_surface, and the XWM setting the role of the surface.
We now keep track of the (first) content commit on the surface and
forward it to the shell when we finally get the role.
There is no need to
too, like in xcb_get_property_reply_t.
Signed-off-by: Emmanuel Gil Peyrot
Reviewed-by: Quentin Glidic
Just re-checked to be sure, found a tiny thing I overlooked (see below),
but the Rb still stands anyway.
---
clients/window.c | 4 +--
libweston/compositor-wayland.c | 2
From: Quentin Glidic
Since the install script cannot know the correct bindir, just pass it
from Meson directly.
Signed-off-by: Quentin Glidic
---
meson.build | 3 ++-
tools/install-compat-scripts.sh | 10 --
2 files changed, 6 insertions(+), 7 deletions(-)
diff
From: Quentin Glidic
If libdir is an absolute path (which means it’s outside of prefix) we
would wrongly add the prefix to it in the install script. Just pass the
correct libdir from Meson directly thanks to join_paths() magic.
Signed-off-by: Quentin Glidic
---
Just found this one while doing
On 11/16/17 4:04 PM, Harsha Manjula Mallikarjun (RBEI/ECF3) wrote:
Hi All,
we are developing a middleware frame work for a 3D window manager.
The window manager should be able to map the client buffers to
3D shapes (cube, cylinder and so on).
Our idea is that "3D window manager" uses libweston
On 11/13/17 10:20 PM, Louis-Francis Ratté-Boulianne wrote:
Don't just ignore the minimal and maximal sizes requested
by the application.
Signed-off-by: Louis-Francis Ratté-Boulianne
---
xwayland/window-manager.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/xwayland/win
On 11/7/17 6:01 PM, Matt Hoosier wrote:
Hi Pekka,
On Wed, Oct 25, 2017 at 10:09 AM, Ucan, Emre (ADITG/ESB)
wrote:
Actually, IMO ivi-shell is not a proper wayland compositor.
Because it is violating wayland protocol by not supporting wl_shell
interface.
The wl_shell protocol was designed fo
full device path.
Signed-off-by: Pekka Paalanen
Seems good:
Reviewed-by: Quentin Glidic
Thanks,
---
libweston/weston-launch.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libweston/weston-launch.c b/libweston/weston-launch.c
index 6a7a7649..79a02506 100644
eviewed-by: Quentin Glidic
Thanks,
---
libweston/weston-launch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libweston/weston-launch.c b/libweston/weston-launch.c
index bc50de74..6a7a7649 100644
--- a/libweston/weston-launch.c
+++ b/libweston/weston-launch.c
@@ -69
&& !wl.new_user)
+ error(1, 0, "tty option requires -u option as well.");
Nit: maybe EINVAL?
And maybe "-t/--tty … -u/--user", at least use the same format to make
it clearer?
Anyway, this one is:
Reviewed-by: Quentin Glidic
Thanks,
+
if (wl.new_user)
: Pekka Paalanen
Quite useful indeed:
Reviewed-by: Quentin Glidic
Thanks,
---
compositor/main.c | 13 +
man/weston.ini.man | 8
man/weston.man | 8
3 files changed, 29 insertions(+)
diff --git a/compositor/main.c b/compositor/main.c
index 9e4451e5
On 10/31/17 12:48 PM, Pekka Paalanen wrote:
From: Pekka Paalanen
Split out a new function. This is a pure refactoring, no change in
behaviour.
This helps a following patch that adds a loop over output->head_list.
Signed-off-by: Pekka Paalanen
Quite obvious:
Reviewed-by: Quentin Gli
: Quentin Glidic
As a nitpick, maybe we could add xstrdup or safe_strdup to handle the
NULL case?
Thanks,
---
libweston/compositor.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/libweston/compositor.c b/libweston/compositor.c
index 1cc5050a..de667cfa
x27;t yet have a compositor or a backend.
The SEGV handler uses weston_log(), so cannot move catch_signals() any
earlier.
Signed-off-by: Pekka Paalanen
Sounds good:
Reviewed-by: Quentin Glidic
Thanks,
---
compositor/main.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
)
Great work!
The whole series is:
Reviewed-by: Quentin Glidic
Thanks,
--
Quentin “Sardem FF7” Glidic
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
On 10/23/17 8:55 AM, Pekka Paalanen wrote:
Hi,
I'm CC'ing Quentin for the automake comments below.
On Thu, 12 Oct 2017 13:13:41 +0200
Emre Ucan wrote:
From: Pekka Paalanen
This is a new debugging extension for non-production environments. The
aim is to replace all build-time choosable deb
From: Quentin Glidic
Using XDG_RUNTIME_DIR to create anonymous files is problematic when
XDG_RUNTIME_DIR is not a tmpfs. OTOH, shm_open is in POSIX.1-2001, so it
should be available on all platforms we care about.
As a bonus, the created fd is already CLOEXEC.
Signed-off-by: Quentin Glidic
On 10/18/17 11:01 AM, Jonas Ådahl wrote:
On Wed, Oct 18, 2017 at 10:58:44AM +0200, Quentin Glidic wrote:
From: Quentin Glidic
If a surface is in state A, and we just sent a configure for state B,
setting back state A would be ignored, because state B has not been
committed yet.
Now, we check
From: Quentin Glidic
If a surface is in state A, and we just sent a configure for state B,
setting back state A would be ignored, because state B has not been
committed yet.
Now, we check against the latest configured state (which is current
state if configure list is empty).
Reported on
From: Quentin Glidic
If a surface is in state A, and we just sent a configure for state B,
setting back state A would be ignored, because state B has not been
committed yet.
Since we only send a configure event if the state was different,
consider pending as different if the configure list is
Hi,
I will limit my review to the libweston-desktop usage, as it’s the only
part I know.
On 10/17/17 11:59 AM, Michael Teyfel wrote:
Signed-off-by: Michael Teyfel
---
ivi-shell/ivi-shell.c | 172 ++
1 file changed, 172 insertions(+)
diff -
On 10/10/17 5:21 PM, Emil Velikov wrote:
On 10 October 2017 at 15:19, Quentin Glidic
wrote:
On 10/10/17 3:43 PM, Emil Velikov wrote:
From: Emil Velikov
Wire-up the imported sources, test and pkg-config files.
v2:
- Don't mangle with existing EXTRA_DIST list
- Add the symbols
On 10/10/17 3:43 PM, Emil Velikov wrote:
From: Emil Velikov
Wire-up the imported sources, test and pkg-config files.
v2:
- Don't mangle with existing EXTRA_DIST list
- Add the symbols check script to the `make check' target
- Rename wayland-egl-{priv,backend}.h
Signed-off-by: Emil Velik
From: Quentin Glidic
The old code for scheduling configure events on idle looked like:
if (configure_scheduled) {
if (this_event_is_the_same) {
remove_timer();
return;
}
}
If we queued one new event (either changed, or the client had never
received any configure event), followed
On 8/18/17 11:30 AM, Quentin Glidic wrote:
From: Quentin Glidic
Projects have been using various ways to check for the wayland-scanner,
mostly based on their developper own use case, and often not allowing
others use cases to work without a workaround.
Hopefully this macro will support all
From: Quentin Glidic
Projects have been using various ways to check for the wayland-scanner,
mostly based on their developper own use case, and often not allowing
others use cases to work without a workaround.
Hopefully this macro will support all use cases without needing user
action.
Signed
On 8/5/17 4:38 PM, Quentin Glidic wrote:
Pushed this one as a critical bug fix (since we are in RC1):
18e77af6..3000a1c7 master -> master
I’ll let someone else push the others while in RC if they find them
critical enough. Otherwise, I’ll push them after the release.
Release done, pushed
On 8/5/17 1:59 PM, Arnaud Vrac wrote:
Without this weston crashes when a client using xdg-shell-v5 is run.
Signed-off-by: Arnaud Vrac
---
libweston-desktop/xdg-shell-v5.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libweston-desktop/xdg-shell-v5.c b/libweston-desktop/xdg-shell-v5.c
On 8/5/17 1:59 PM, Arnaud Vrac wrote:
Without this weston crashes when a client using xdg-shell-v5 is run.
Signed-off-by: Arnaud Vrac
Oops. Good catch:
Reviewed-by: Quentin Glidic
Thanks,
---
libweston-desktop/xdg-shell-v5.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
On 8/5/17 1:59 PM, Arnaud Vrac wrote:
It's been unused since the legacy (non-libinput) input backends have
been removed.
Signed-off-by: Arnaud Vrac
Sounds good:
Reviewed-by: Quentin Glidic
Thanks,
---
configure.ac| 4 ++--
libweston/libinput-device.c | 1 -
2
@@ -337,6 +337,7 @@ dmabuf_image_destroy(struct dmabuf_image *image)
linux_dmabuf_buffer_set_user_data(image->dmabuf, NULL, NULL);
wl_list_remove(&image->link);
+ free(image);
}
static const char *
Good:
Reviewed-by: Quentin Glidic
Thanks,
--
Quent
this by checking for dlsym instead of dlopen.
This can be reproduced by configuring the build with:
CFLAGS="-fsanitize=address -fsanitize=undefined"
LDFLAGS="-fsanitize=address -fsanitize=undefined"
Signed-off-by: Arnaud Vrac
Well explained:
Reviewed-by: Que
.
Signed-off-by: Philipp Kerling
I’ll take that as a bug fix, so let’s land it in beta.
Added a couple of variables to avoid the long lines breaks and:
Reviewed-by: Quentin Glidic
Then pushed:
e3715527..c5f12416 master -> master
Thanks!
---
desktop-shell/shell.c | 5 +
1 f
On 7/27/17 3:01 PM, Giulio Camuffo wrote:
When unmaximizing a surface the configure event should send 0,0 as the
requested size, so that the client can use the size that it had before
maximizing
Hi,
I disagree on this patch for a few reasons:
- the size can be ignored in this case, so there is
to optimize the “serial is not in the list” case (since the
list is ordered) but I failed. The wanted code is
else if (==) { found = true; break; } else break;
Anyway, this is:
Reviewed-by: Quentin Glidic
either with the optimized break or not.
Thanks for catching this,
}
+ (toplevel->next.size.width != geometry.width ||
+toplevel->next.size.height != geometry.height)) {
struct weston_desktop_client *client =
weston_desktop_surface_get_client(toplevel->base.desktop_surface);
str
sed for shell_surface keyboard focus
tracking.
As said on IRC, added your Sob, and:
Reviewed-by: Quentin Glidic
And pushed:
4c4b9cfb..ba8a0d04 master -> master
Thanks!
---
desktop-shell/shell.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/desktop-shell/shell.c b/d
On 5/15/17 4:40 PM, Pekka Paalanen wrote:
On Mon, 15 May 2017 15:29:29 +0200
Quentin Glidic wrote:
From: Quentin Glidic
Signed-off-by: Quentin Glidic
---
libweston-desktop/xwayland.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/libweston-desktop/xwayland.c b/libweston
h we should always call view_set_position(),
not just the first time we set this state.
Signed-off-by: Ilia Bozhinov
Good:
Reviewed-by: Quentin Glidic
And pushed:
749637a8..3e5303da master -> master
Thanks,
---
libweston-desktop/xwayland.c | 2 +-
xwayland/window-manager.c
On 7/20/17 4:33 PM, Matt Hoosier wrote:
It's useful for the shell implementation to know when these change,
for example to relay the information on to taskbars or similar.
The idea is good, we need something like that. (But maybe not, see below).
To avoid ABI changes or the need to make the
From: Quentin Glidic
If we start a special (grabbing) client when Weston is unfocused, it
would lose focus when coming back to Weston.
Signed-off-by: Quentin Glidic
---
v2:
Reset saved focus in weston_keybord_set_focus()
Shuffled the focus saving code (since it calls set_focus() to NULLify
On 7/18/17 3:58 PM, Pekka Paalanen wrote:
On Wed, 24 May 2017 11:32:21 +0300
Jussi Kukkonen wrote:
On 23 May 2017 at 14:51, Quentin Glidic
wrote:
So you want to break the simple (cross-compiling) cases to fix
something that doesn’t need fixing?
I think that is not warranted.
* My issue
On 7/20/17 11:25 AM, Daniel Stone wrote:
Hi,
On 20 July 2017 at 10:14, Quentin Glidic
wrote:
Using ${pc_sysrootdir} sounds like the correct thing to do. However, your
patch introduces a triple / when PKG_CONFIG_SYSROOT_DIR is not set.
Having two / is already trouble on some platform (though
On 7/6/17 11:02 AM, Tomek Bury wrote:
Hi,
I've attached a trivial patch we discussed yesterday on #wayland
channel. The patch adds a sysroot prefix to the "pkgdatadir" variable.
The pkg-config automatically adds sysroot to paths returned by --cflags
and --libs but *NOT* to --variable.
The "
On 7/20/17 10:49 AM, Jonas Ådahl wrote:
On Thu, Jul 20, 2017 at 10:45:38AM +0200, Quentin Glidic wrote:
From: Quentin Glidic
Now we keep track of serial->state association and we discard the states
that the client ignored.
Signed-off-by: Quentin Glidic
Reviewed-by: Jonas Ådahl
Tha
From: Quentin Glidic
Now we keep track of serial->state association and we discard the states
that the client ignored.
Signed-off-by: Quentin Glidic
---
On 7/20/17 10:24 AM, Jonas Ådahl wrote:
> Noticed one more thing I missed in the previous review: cleanup of the
> pending
From: Quentin Glidic
Now we keep track of serial->state association and we discard the states
that the client ignored.
Signed-off-by: Quentin Glidic
---
v3:
Fixed a tiny style issue
Now send an error on wrong serial
libweston-desktop/xdg-shell-v5.c |
On 7/20/17 5:56 AM, Jonas Ådahl wrote:
On Tue, Jul 18, 2017 at 01:14:49PM +0200, Quentin Glidic wrote:
From: Quentin Glidic
Now we keep track of serial->state association and we discard the states
that the client ignored.
Signed-off-by: Quentin Glidic
---
libweston-desktop/xdg-shell-v
From: Quentin Glidic
Now we keep track of serial->state association and we discard the states
that the client ignored.
Signed-off-by: Quentin Glidic
---
libweston-desktop/xdg-shell-v5.c | 45 +++-
libweston-desktop/xdg-shell-v6.c |
From: Quentin Glidic
We were checking against the pending size, which lead some clients
(simple-egl) to crash because they sent a buffer before acknowledging
the latest configure event.
Signed-off-by: Quentin Glidic
Tested-by: Emmanuel Gil Peyrot
Reviewed-by: Jonas Ådahl
---
Added your Rb
On 7/12/17 11:09 AM, Jonas Ådahl wrote:
On Wed, Jul 12, 2017 at 09:53:03AM +0200, Quentin Glidic wrote:
From: Quentin Glidic
Signed-off-by: Quentin Glidic
Reviewed-by: Jonas Ådahl
Thanks. Added Emmanuel Tb from IRC and pushed:
1170c663..19d1f6ef master -> master
Patch 3 not pushed,
On 7/12/17 12:07 PM, Jonas Ådahl wrote:
On Wed, Jul 12, 2017 at 12:02:29PM +0200, Quentin Glidic wrote:
On 7/12/17 11:23 AM, Jonas Ådahl wrote:
On Wed, Jul 12, 2017 at 09:53:04AM +0200, Quentin Glidic wrote:
From: Quentin Glidic
We were checking against the pending size, which lead some
On 7/12/17 11:23 AM, Jonas Ådahl wrote:
On Wed, Jul 12, 2017 at 09:53:04AM +0200, Quentin Glidic wrote:
From: Quentin Glidic
We were checking against the pending size, which lead some clients
(simple-egl) to crash because they sent a buffer before acknowledging
the latest configure event
From: Quentin Glidic
Signed-off-by: Quentin Glidic
---
libweston-desktop/xdg-shell-v5.c | 56 +++---
libweston-desktop/xdg-shell-v6.c | 58
2 files changed, 57 insertions(+), 57 deletions(-)
diff --git a/libweston
From: Quentin Glidic
Signed-off-by: Quentin Glidic
---
libweston-desktop/xdg-shell-v5.c | 80 ++---
libweston-desktop/xdg-shell-v6.c | 97 ++--
2 files changed, 98 insertions(+), 79 deletions(-)
diff --git a/libweston-desktop/xdg
From: Quentin Glidic
We were checking against the pending size, which lead some clients
(simple-egl) to crash because they sent a buffer before acknowledging
the latest configure event.
Signed-off-by: Quentin Glidic
---
libweston-desktop/xdg-shell-v5.c | 6 --
libweston-desktop/xdg-shell
On 6/23/17 1:11 PM, Daniel Stone wrote:
Hi Quentin,
On 13 April 2017 at 20:15, Quentin Glidic
wrote:
When switching a state twice in a row, we were overwriting the old value
without setting it back, sending a wrong state to the client.
Now we update our requested state, then check if we need
On 6/23/17 12:59 PM, Daniel Stone wrote:
Hi Quentin,
On 10 March 2017 at 10:50, Quentin Glidic
wrote:
@@ -634,22 +633,27 @@ weston_desktop_xdg_toplevel_committed(struct
weston_desktop_xdg_toplevel *toplev
+ if ((toplevel->next_state.maximized || toplevel->next_state.full
On 5/31/17 2:37 PM, adlo wrote:
Is libweston 1.0 good enough for writing a compositor?
Yes, but each major version is adding or changing API to make it simpler
to write a compositor. Specifically, libweston 2 has introduced a much
nicer output API, thanks to Armin’s GSoC work.
Are there an
On 5/24/17 8:37 PM, adlo wrote:
On 24 May 2017, at 16:43, Quentin Glidic
wrote:
There is no need, because the compositor is supposed to list only relevant
surfaces.
What I would like to do is get the desktop window so that I can display a fake
live image of the empty desktop as a
On 5/24/17 5:41 PM, adlo wrote:
On 15 May 2017, at 10:52, Quentin Glidic
wrote:
If you are writing/porting a window switcher, please consider using Wayland Wall window-switcher
protocol[1]. If you are not, please don’t, as this protocol is very specific to switchers (it has
"switch_to
nnot find a way that works for everyone, then we failed at
defining what wayland-scanner is and how it should be used.
Jussi
On 23 May 2017 at 11:56, Quentin Glidic <mailto:sardemff7%2bwayl...@sardemff7.net>> wrote:
>
> On 5/23/17 10:05 AM, Jussi Kukkonen wrote:
>>
&
On 9/9/16 4:31 AM, Bryce Harrington wrote:
Updated to include review feedback from Quentin on the v5. That
involves refinements to the destructor behavior, reorganizing patches a
bit, and noting that if the idle manager is destroyed by the client, the
individual inhibitor objects remain active.
On 3/13/17 11:40 AM, Sergei Trofimovich wrote:
Before the change build failed on Gentoo as:
libweston/weston_launch-weston-launch.o: In function `handle_open':
weston/libweston/weston-launch.c:363: undefined reference to `major'
weston/libweston/weston-launch.c:365: undefined reference
troy(window->icon_surface);
+ window->icon_surface = NULL;
+ }
If we wait until success to replace the icon, we could keep a good
(though outdated) icon if we failed to import the new one.
With the uint32_t fix and that shifted around:
Reviewed-by: Quentin Glidic
A
the screen.
This patch makes sure, that there is at least a refresh rate of 1 Hz, because
it returns the default refresh rate of 60 Hz otherwise.
[1]: https://github.com/LineageOS/lge-kernel-mako
Signed-off-by: Oliver Smith
We’ll just pretend I know what I’m doing:
Reviewed-by: Quentin Glidic
long_option_with_arg() to assert
Signed-off-by: Lyude
Reviewed-by: Eric Engestrom
Nice one, I had one a lng time ago but never really rebased it:
Reviewed-by: Quentin Glidic
Changed the style a tiny bit (line wrapping) and pushed:
dbfd248d..47bbdc72 master -> master
T
On 5/23/17 10:05 AM, Jussi Kukkonen wrote:
Modify wayland-scanner lookup: Use the path given by pkg-config
but offer an option to override the path with
"--with-wayland-scanner-path=PATH". The latter is useful for
cross-compile situations.
I would rather use --with-wayland-scanner.
AC_PATH_P
On 5/19/17 4:57 PM, adlo wrote:
Do any compositors support this protocol?
Any compositor based on libweston and capable of loading weston plugins
(and later libweston plugins), using Weston Wall[1].
The implementation is limited (no workspaces support) but that is
something fixable in the fut
From: Quentin Glidic
Signed-off-by: Quentin Glidic
---
libweston-desktop/xwayland.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/libweston-desktop/xwayland.c b/libweston-desktop/xwayland.c
index 4f4b453f..4dcb5f03 100644
--- a/libweston-desktop/xwayland.c
+++ b/libweston
On 5/15/17 3:13 PM, adlo wrote:
On 15 May 2017, at 10:52, Quentin Glidic
wrote:
If you are writing/porting a window switcher, please consider using
Wayland Wall window-switcher protocol[1]. If you are not, please
don’t, as this protocol is very specific to switchers (it has
"switch_to
On 5/15/17 9:46 AM, Pekka Paalanen wrote:
On Mon, 15 May 2017 07:05:26 +0200
Wojciech Kluczka wrote:
In Wayland array can contain only integers.
Hi,
not exactly. The data type inside an array is unspecified by the XML
language. You can use literally anything, it's just a binary blob with
a
On 4/26/17 4:20 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
---
meson.build | 596 ++
meson_options.txt | 16 ++
2 files changed, 612 insertions(+)
create mode 100644 meson.build
create mode 100644 meson_options.txt
On 4/26/17 4:20 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
---
meson.build | 596 ++
meson_options.txt | 16 ++
2 files changed, 612 insertions(+)
create mode 100644 meson.build
create mode 100644 meson_options.txt
Bryce Harrington
Reviewed-by: Quentin Glidic
Let’s start small and push this one for now:
2cd87fe8..9ad4de1f master -> master
Thanks,
---
desktop-shell/shell.c | 137 --
desktop-shell/shell.h | 14 +++---
2 files changed, 84 insertion
From: Quentin Glidic
When switching a state twice in a row, we were overwriting the old value
without setting it back, sending a wrong state to the client.
Now we update our requested state, then check if we need to schedule a
configure event, if we have one scheduled already or even if we can
fullscreen or maximized, leading to
the unmaximize/maximize dance being done at each commit.
This was introduced in 8f9d90a84bb2888b074fea93c4a28778bc6439c6.
Changes since v1:
- Fix the actual issue instead of a symptom.
Signed-off-by: Emmanuel Gil Peyrot
Nice fix:
Reviewed-by: Quentin Glidic
1 - 100 of 616 matches
Mail list logo