[PATCH weston] compositor-x11: fix segfault when use_pixman is true

Signed-off-by: Ryo Munakata --- libweston/compositor-x11.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libweston/compositor-x11.c b/libweston/compositor-x11.c index de64e49..34ef854 100644 --- a/libweston/compositor-x11.c +++ b/libweston/compositor-x11.c @@ -917,8

Re: [PATCH weston] clients/simple-shm: remove unreachable function call

Hi Daniel-san. On Mon, 21 Nov 2016 09:44:42 + Daniel Stone wrote: > Hi Munakata-san, > > On 18 November 2016 at 12:17, Ryo Munakata wrote: > > window->wait_for_configure should be false after dispatching more than once. > > Therefore this redraw() will never be ca

[PATCH weston] clients/simple-shm: remove unreachable function call

window->wait_for_configure should be false after dispatching more than once. Therefore this redraw() will never be called. Signed-off-by: Ryo Munakata --- clients/simple-shm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/clients/simple-shm.c b/clients/simple-shm.c index 9fa2

[PATCH weston] libweston: remove unused function declaration of weston_compositor_top

Signed-off-by: Ryo Munakata --- libweston/compositor.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/libweston/compositor.h b/libweston/compositor.h index e00d285..4ca52f9 100644 --- a/libweston/compositor.h +++ b/libweston/compositor.h @@ -1451,9 +1451,6

Re: [PATCH wayland] Revert "client: require WAYLAND_DISPLAY to be set"

Although I personally like the current behavior, I think this revert is reasonable. Acked-By: Ryo Munakata Thanks. On Mon, 17 Aug 2015 16:17:57 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > This reverts commit fb7e13021730d0a5516ecbd3712ea4235e05d24d. > > Devel

Re: [PATCH wayland] Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

On Wed, 12 Aug 2015 19:34:31 -0700 Dima Ryazanov wrote: Hi Dima. Reviewed-by: Ryo Munakata Thanks. > Although defaulting to wayland-0 seems convenient, it has an undesirable > side effect: clients may unintentionally connect to the wrong compositor. > Generally, it's safer t

[PATCH weston] Use [x]zalloc instead of [x]malloc + memset

Signed-off-by: Ryo Munakata --- clients/editor.c| 3 +-- clients/subsurfaces.c | 6 ++ fullscreen-shell/fullscreen-shell.c | 9 +++-- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index d0b7fee

Re: [PATCH weston] input: when destroying a seat, remove keyboard focus first

This annoys me when using Valgrind. Reviewed-by: Ryo Munakata Thank you. On Thu, 6 Aug 2015 12:19:51 -0500 Derek Foreman wrote: > If we destroy all the devices before trying to remove keyboard focus > we'll segfault because we destroyed the keyboard. > > Signed-off-

Re: [PATCH weston v2] desktop-shell: drop shell_client from the head of the surface list on destroy

On Fri, 29 May 2015 10:46:44 -0500 Derek Foreman wrote: Hi all. I sent an almost same patch to ML recently, which means this problem hasn't been fixed. So now: Reviewed-by: Ryo Munakata This patch has been forgotten for a long time. Please push it unless anyone has issues with it. &

Re: [PATCH] desktop-shell: fix bug referencing invalid surface list

Hi Derek. On 08/05, Derek Foreman wrote: > On 29/07/15 01:12 PM, Ryo Munakata wrote: > > In shell_destroy_shell_surface, we remove the link of a shell_surface. > > There is a case which the link references shell_client::surface_list > > which is already free'd. >

Re: [PATCH? weston] - wayland backend: outputs are destroyed twice

On 07/29, Dawid Gajownik wrote: Hi Dawid. > Hi, > > in src/compositor-wayland.c:wayland_backend_destroy() you can find this code: > > struct weston_output *output, *next; > > wl_list_for_each_safe(output, next, &b->compositor->output_list, link) > wayland_output

[PATCH] desktop-shell: fix bug referencing invalid surface list

In shell_destroy_shell_surface, we remove the link of a shell_surface. There is a case which the link references shell_client::surface_list which is already free'd. Therefore we have to remove shell_client::surface_list when freeing a shell_client. Signed-off-by: Ryo Munakata --- desktop-

[PATCH weston] compositor: remove a call to weston_compositor_schedule_repaint

In weston_compositor_create, we initialize output_list. After that we call weston_compositor_schedule_repaint which just calls weston_output_schedule_repaint on all elements of output_list. This call does nothing obviously. So we remove it. Signed-off-by: Ryo Munakata --- src/compositor.c | 2

[PATCH] compositor: destroy modifier_binding_list

Signed-off-by: Ryo Munakata --- src/compositor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compositor.c b/src/compositor.c index 4e88375..ec2be7d 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4558,6 +4558,7 @@ weston_compositor_shutdown(struct weston_compositor *ec

[PATCH weston] desktop-shell: set the current size in the first 'resizing' configure event

Weston has sent the first 'resizing' configure event with width=height=0. But resizing to that size doesn't make sense. Instead, we now send the current width and height of the surface at the beginning of resizing. Signed-off-by: Ryo Munakata --- desktop-shell/shell.c | 3 +++

Re: [PATCH weston] compositor-fbdev: enumerate available fbdevs using udev

On Wed, 11 Mar 2015 17:58:00 + Philip Withnall wrote: > On Wed, 2015-03-11 at 16:05 +0200, Pekka Paalanen wrote: > > On Tue, 10 Mar 2015 11:34:45 +0900 > > Ryo Munakata wrote: > > > > > This was a TODO: > > > "Ideally, available frame buffers s

Re: [PATCH weston] compositor-fbdev: enumerate available fbdevs using udev

On Wed, 11 Mar 2015 17:54:42 + Philip Withnall wrote: First, sorry for my late reply. > On Thu, 2015-03-12 at 00:40 +0900, Ryo Munakata wrote: > > On Wed, 11 Mar 2015 16:05:55 +0200 > > Pekka Paalanen wrote: > > > > > On Tue, 10 Mar 2015 11:34:45 +

Re: [PATCH weston] compositor-fbdev: enumerate available fbdevs using udev

2015/03/12 0:40 "Ryo Munakata" : > > On Wed, 11 Mar 2015 16:05:55 +0200 > Pekka Paalanen wrote: > > > On Tue, 10 Mar 2015 11:34:45 +0900 > > Ryo Munakata wrote: > > > + > > > struct fbdev_compositor { > > > struct weston_composito

Re: [PATCH weston] compositor-fbdev: enumerate available fbdevs using udev

On Wed, 11 Mar 2015 16:05:55 +0200 Pekka Paalanen wrote: > On Tue, 10 Mar 2015 11:34:45 +0900 > Ryo Munakata wrote: > > > This was a TODO: > > "Ideally, available frame buffers should be enumerated > > using udev, rather than passing a device node in as a &

[PATCH weston] xwayland: wm: fix an invalid read

This `for` statement needs corresponding braces. Signed-off-by: Ryo Munakata --- xwayland/window-manager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index ec3dab9..ad608b7 100644 --- a/xwayland/window-manager.c

[PATCH weston] compositor-fbdev: enumerate available fbdevs using udev

This was a TODO: "Ideally, available frame buffers should be enumerated using udev, rather than passing a device node in as a parameter." Signed-off-by: Ryo Munakata --- src/compositor-fbdev.c | 55 +++--- 1 file changed, 52 insertions(+), 3

Re: [PATCH 2/2] Fix trivial memory leaks

ought I saw valgrind reported this as a memory leak. Now I tested it with valgrind and this part seems to be my mistake. I just sent v2 of this patch with only the good parts. Thank you. -- Ryo Munakata ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston v2] Fix trivial memory leaks

Signed-off-by: Ryo Munakata --- desktop-shell/shell.c | 2 ++ src/compositor-x11.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index aae304d..826692f 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -6453,6 +6453,8

[PATCH 1/2] compositor: fix a memory leak of struct process_info

Cleanup functions of weston clients are never called after wl_display_run(), so that some of process_info of clients will not be freed. Signed-off-by: Ryo Munakata --- src/compositor.c | 24 +--- src/compositor.h | 1 + 2 files changed, 22 insertions(+), 3 deletions

Re: [PATCH 2/2] Fix trivial memory leaks

Something went wrong. Resent. Thanks. -- Ryo Munakata ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH 1/2] compositor: fix a memory leak of struct process_info

Cleanup functions of weston clients are never called after wl_display_run(), so that some of process_info of clients will not be freed. Signed-off-by: Ryo Munakata --- src/compositor.c | 24 +--- src/compositor.h | 1 + 2 files changed, 22 insertions(+), 3 deletions

Re: [PATCH weston] xwayland: fix fullscreening

er; > > - if (window->decorate) { > + if (window->decorate && !window->fullscreen) { > hborder = 2 * t->width; > vborder = t->titlebar_height + t->width; > } else { > -- > 1.9.3 Hi, Marek. Thi

Re: Failing to add socket to wayland display.

d_socket() returns 0 on success. Otherwise reuturns -1. See: http://cgit.freedesktop.org/wayland/wayland/tree/src/wayland-server.c#n1185 So your call to wl_display_add_socket() seems to succeed. Thanks. -- Ryo Munakata ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston v2 1/2] Add font entry to shell section for title fonts

to set fonts=sans. That doesn't suddenly switch completely to a fullwidth font. I want to know what you need. Please tell me the way you want to solve the problem which is why I wrote this series. Thanks. -- Ryo Munakata ___ wayland-devel mailing

Re: [PATCH weston v2 1/2] Add font entry to shell section for title fonts

Hi, Jasper. Thank you for reviewing! On Sat, 4 Oct 2014 07:09:54 -0700 "Jasper St. Pierre" wrote: > On Oct 4, 2014 4:37 AM, "Ryo Munakata" wrote: > > > > cairo-util has used sans font family for title fonts so far. > > But sans doesn't support g

Re: [PATCH weston v2 1/2] Add font entry to shell section for title fonts

On Sat, 04 Oct 2014 15:08:12 -0700 Bill Spitzak wrote: > On 10/04/2014 04:37 AM, Ryo Munakata wrote: > > cairo-util has used sans font family for title fonts so far. > > But sans doesn't support glyphs of some non-ascii characters. > > So now let users choose a font fam

[PATCH weston v2 2/2] Avoid 'g_type_init() is deprecated' warnings

Because of g_type_init we see the following: clients/editor.c:1350:2: warning: ‘g_type_init’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:679) [-Wdeprecated-declarations] g_type_init() has been deprecated and does nothing since version GLib 2.36. Signed-off-by: Ryo Munakata

[PATCH weston v2 1/2] Add font entry to shell section for title fonts

se this entry too. Signed-off-by: Ryo Munakata --- Makefile.am | 4 ++ clients/window.c | 18 +++-- configure.ac | 5 +- man/weston.ini.man| 3 + shared/cairo-util.c | 180 -- shared/cairo-util.h

[PATCH weston v2 0/2] Add font entry to shell section for title fonts

nt in the specifie fonts list don't contain all the needed glyphs. We can expect much better text rendering compared with the plain cairo one. Ryo Munakata (2): Add font entry to shell section for title fonts Avoid 'g_type_init() is deprecated' warnings Makefile.am

[PATCH wayland v3] abort if a listener function is NULL

Signed-off-by: Ryo Munakata --- src/connection.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/connection.c b/src/connection.c index f292853..f516c85 100644 --- a/src/connection.c +++ b/src/connection.c @@ -931,6 +931,11 @@ wl_closure_invoke(struct wl_closure *closure, uint32_t

Re: [PATCH wayland v2] assert if a listener function is NULL

On Wed, 1 Oct 2014 14:49:33 +0300 Giulio Camuffo wrote: > 2014-10-01 14:36 GMT+03:00 Ryo Munakata : > > Signed-off-by: Ryo Munakata > > --- > > src/connection.c | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/src/connection.c b/src/

[PATCH wayland v2] assert if a listener function is NULL

Signed-off-by: Ryo Munakata --- src/connection.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/connection.c b/src/connection.c index f292853..424edd4 100644 --- a/src/connection.c +++ b/src/connection.c @@ -931,6 +931,11 @@ wl_closure_invoke(struct wl_closure *closure, uint32_t

[PATCH wayland] assert if a listener function is NULL

Signed-off-by: Ryo Munakata --- src/connection.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/connection.c b/src/connection.c index f292853..c61275d 100644 --- a/src/connection.c +++ b/src/connection.c @@ -931,6 +931,11 @@ wl_closure_invoke(struct wl_closure *closure, uint32_t

Re: [PATCH] compositor: Don't free an uninitialised pointer.

> + char *option_modules = NULL; > char *log = NULL; > char *server_socket = NULL, *end; > int32_t idle_time = 300; This is right. I forgot to condider that case when I moved free()s to the end of main(). Reviewed-by: Ryo Munakata Thanks. -- Ryo Munakata _

Re: [PATCH weston 2/2] main: don't leak option strings

On Mon, 8 Sep 2014 09:28:17 +0300 Pekka Paalanen wrote: > On Sun, 07 Sep 2014 21:30:52 -0700 > Bill Spitzak wrote: > > > On 09/05/2014 10:47 PM, Ryo Munakata wrote: > > > > > > Hi, Bill. > > > > > > Thank you for reviewing. > > >

Re: [PATCH weston 2/2] main: don't leak option strings

t of argv, so if handle_option() doesn't copy it and someone overwrites it, we can't get correct option strings later. argv is not immutable and this is why handle_options() copies the content of argv, I think. What do you think about that?

Re: [PATCH weston] compositor.c: do not leak option strings

tion_modules); > > > > weston_compositor_wake(ec); > > > > You could just have one free(option_modules) somewhere after out: label. > > We could collect all free()s for the WESTON_OPTION_STRING variables at > the end of main(). > > > Thanks, > pq Hi, Pekka. I sent a series of the version 2 of this patch, which fixes the issues you mentioned. I worried about the usage of not-free'd memory caused by collecting free()s at the end of main(). But it will be very small and now I think it doesn't matter. Thanks. -- Ryo Munakata ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston 2/2] main: don't leak option strings

Signed-off-by: Ryo Munakata --- src/compositor.c | 45 +++-- 1 file changed, 19 insertions(+), 26 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 0ecae23..de58c59 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4328,15

[PATCH weston 1/2] main: usual patterns can be extracted to functions

Signed-off-by: Ryo Munakata --- src/compositor.c | 66 +++- 1 file changed, 41 insertions(+), 25 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 20ff6b2..0ecae23 100644 --- a/src/compositor.c +++ b/src/compositor.c

[PATCH weston v2] compositor.c: do not leak option strings

Hi. This patch series is a version 2 of 'compositor.c: do not leak option strings' 1/2 extracts new functions from usual patterns in main. 2/2 fixes leaks of option strings Thanks. -- Ryo Munakata ___ wayland-devel mailing list way

[PATCH weston] pixman-renderer: copy_to_hw_buffer: don't leak output_region

This was reported by Valgrind. Signed-off-by: Ryo Munakata --- src/pixman-renderer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index 351f00e..2c26c3a 100644 --- a/src/pixman-renderer.c +++ b/src/pixman-renderer.c @@ -457,6 +457,7

Re: [PATCH weston] Add font entry to shell section for title fonts

or something on Google Japan using firefox, the title of firefox will be garbled because of sans which is a default font. (I mean mojibake: http://en.wikipedia.org/wiki/Mojibake) I know Weston is just a reference implementation, not to use for real. What do you think about it considering the policy

Re: [PATCH] pixman-renderer: fail to zoom more gracefully

pixman_composite_trapezoids() */ > -- You might want to use bool instead of int in this case like: #include static bool zoom_logged = false; Thanks. -- Ryo Munakata ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston] compositor.c: do not leak option strings

Also some refactoring to achieve this. Signed-off-by: Ryo Munakata --- src/compositor.c | 52 +++- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 8705950..6adef94 100644 --- a/src

Re: [PATCH weston] xwm: Do not activate override redirect windows

On Sat, 30 Aug 2014 10:33:23 +0800 Hi, Boyan. I tested this patch with chromium and firefox running on each drm-backend and x11-backend of weston. And seems that both chromium and firefox work well. This patch actually fixes bug 81273 in my environment. So now: Tested-by: Ryo Munakata Thanks

[PATCH weston] Add font entry to shell section for title fonts

cairo-util has used sans font family for title fonts so far. But sans doesn't support non-ascii characters. So now let users choose a font family for titles. The entry name is generic, 'font' so that other places where draw texts can use this entry too. Signed-off-by: Ryo Mun

Re: [PATCH weston] simple-shm: remove an unnecessary call of wl_display_get_fd()

; > useless. > > > > Reviewed-by: Nils Chr. Brause > > > > > > > > On Tue, Aug 26, 2014 at 2:59 PM, Ryo Munakata wrote: > > > > > --- > > > clients/simple-shm.c | 2 -- > > > 1 file changed, 2 deletions(-) > > &

[PATCH weston] multi-resource: remove an unnecessary call of wl_display_get_fd()

Signed-off-by: Ryo Munakata --- clients/multi-resource.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/clients/multi-resource.c b/clients/multi-resource.c index c4a0c18..0dc2c74 100644 --- a/clients/multi-resource.c +++ b/clients/multi-resource.c @@ -258,8 +258,6 @@ create_display(void

[PATCH weston] simple-shm: remove an unnecessary call of wl_display_get_fd()

--- clients/simple-shm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/clients/simple-shm.c b/clients/simple-shm.c index b1c311f..c1cb386 100644 --- a/clients/simple-shm.c +++ b/clients/simple-shm.c @@ -393,8 +393,6 @@ create_display(void) exit(1); } - wl_dis

[PATCH] wl_surface: clarify the base of time passed in the callback of frame

Signed-off-by: Ryo Munakata --- protocol/wayland.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 2d57f69..bb457bc 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -1100,7 +1100,7 @@ attempt to use it

Re: [PATCH v2 weston] gears: fix invalid calculation of the first FPS

From: Ryo Munakata To: "Nils Chr. Brause" Subject: Re: [PATCH v2 weston] gears: fix invalid calculation of the first FPS Date: Sun, 10 Aug 2014 23:51:40 +0900 X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.24; x86_64-unknown-linux-gnu) On Sun, 10 Aug 2014 16:02:35 +0200 "Nils Chr. Brause

[PATCH v3 weston] gears: fix invalid calculation of the first FPS

At the calculation of the first FPS, gears has initialized last FPS time with gettimeofday(). But the callback_data passed in the callback of wl_surface_frame() is the current time, in milliseconds, with an undefined base. Because of this subtracting last FPS time from callback_data makes no sense.

[PATCH v2 weston] gears: fix invalid calculation of the first FPS

At the calculation of the first FPS, gears has initialized last FPS time with gettimeofday(). But the callback_data passed in the callback of wl_surface_frame() is the current time, in milliseconds, with an undefined base. Because of this subtracting last FPS time from callback_data makes no sense.

[PATCH weston] gears: fix invalid calculation of the first FPS

At the calculation of the first FPS, gears has initialized last FPS time with gettimeofday(). But the callback_data passed in the callback of wl_surface_frame() is the current time, in milliseconds, with an undefined base. Because of this subtracting last FPS time from callback_data makes no sense.