Re: [PATCH 0/6] RDP compositor needs love v2

2016-05-27 Thread Sam Spilsbury
and lock surface on output >> resize >> I checked my mails and it seems like these two have been reviewed with comments by Pekka. -- Sam Spilsbury ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland] wayland-shm: Include wayland-util.h

2016-05-20 Thread Sam Spilsbury
___ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel Technically makes sense to me, always better to have a flat include tree than one where the dependencies are hidden. Reviewed-by: Sam Spil

Re: [PATCH wayland] event-loop: Include wayland-util.h

2016-05-20 Thread Sam Spilsbury
- > 2.7.2 > > ___ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel Technically makes sense to me, always better to have a flat include tree than one where the dependenc

Re: [PATCH] rdp: don't release the seat until it is safe v2

2016-05-20 Thread Sam Spilsbury
t;seat); Any reason to make this dynamically allocated memory? It seems to me like it is adding an additional point of failure for little added benefit. If it needs to be dynamically allocated, I think such a change should come in a separate patch, since it seems unrelated to this one. Reviewed-by: Sam Spilsbury <smspil...@gmail.com> ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Unit testing a wayland client

2016-04-01 Thread Sam Spilsbury
and support was dropped from Kodi due to my (admitted) failure to maintain it. But I'm glad others are looking into getting it back into shape). > > You could also look for inspiration in the Wayland test suite, even > though it is quite ad hoc. > > > Thanks, > pq > >

Re: Vertex clipping and primitive types

2013-09-19 Thread Sam Spilsbury
On 20/09/2013 5:09 AM, Bill Spitzak spit...@gmail.com wrote: Sam Spilsbury wrote: The point is to any arbitrary geometry against a rectangle. This is used to ensure that redraw areas only stick to damage areas. I suspect the most efficient thing to do is to clip against the bounding box

Vertex clipping and primitive types

2013-09-18 Thread Sam Spilsbury
about the various primitive types, have a look at http://www.opengl.org/wiki/Primitive -- Sam Spilsbury ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Vertex clipping and primitive types

2013-09-18 Thread Sam Spilsbury
Hi Bill, On Sep 19, 2013 11:49 AM, Bill Spitzak spit...@gmail.com wrote: Sam Spilsbury wrote: Hey all, I've started playing around with trying to get weston surfaces (or views as they will later be called) to use arbitrary vertex meshes. Do you have an explanation for views? I thought

Re: [PATCH 4/4] Added tests for the vertex clipping code.

2013-09-17 Thread Sam Spilsbury
that for a few weeks though. Sam. On 17/09/2013 12:41 PM, Kristian Høgsberg hoegsb...@gmail.com wrote: On Fri, Sep 13, 2013 at 10:01:22AM +0800, Sam Spilsbury wrote: This tests (via the table-driven testing method) that the correct number of vertices and also the correct vertices themselves

Re: [PATCH 3/4] Split vertex clipping code out into vertex-clipping.c

2013-09-13 Thread Sam Spilsbury
Hi Kristian, On Sat, Sep 14, 2013 at 6:35 AM, Kristian Høgsberg hoegsb...@gmail.com wrote: On Fri, Sep 13, 2013 at 10:01:21AM +0800, Sam Spilsbury wrote: --- src/Makefile.am | 4 +- src/gl-renderer.c | 292 +- src/vertex-clipping.c

[PATCH 0/4] Table driven tests for the vertex clipping code

2013-09-12 Thread Sam Spilsbury
This is the third series of patches for adding table driven tests for the vertex clipping code. From the last series I fixed some a stray use of .a when it should have been .la and also rebased on some recent work that happened in git master. Sam Spilsbury (4): Remove AM_LDFLAGS usage Add

[PATCH 1/4] Remove AM_LDFLAGS usage

2013-09-12 Thread Sam Spilsbury
We are not building everything here as a module, only the test modules. --- tests/Makefile.am | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 398a275..3a36619 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -7,6

[PATCH 2/4] Add support for table-driven testing.

2013-09-12 Thread Sam Spilsbury
/weston-test-runner.h b/tests/weston-test-runner.h index 41df386..457cf31 100644 --- a/tests/weston-test-runner.h +++ b/tests/weston-test-runner.h @@ -1,5 +1,6 @@ /* * Copyright © 2012 Intel Corporation + * Copyright © 2013 Sam Spilsbury smspil...@gmail.com * * Permission to use, copy, modify

[PATCH 3/4] Split vertex clipping code out into vertex-clipping.c in shared/

2013-09-12 Thread Sam Spilsbury
--- shared/Makefile.am | 4 +- shared/vertex-clipping.c | 317 +++ shared/vertex-clipping.h | 65 ++ src/gl-renderer.c| 292 +-- 4 files changed, 389 insertions(+), 289 deletions(-)

[PATCH 4/4] Added tests for the vertex clipping code.

2013-09-12 Thread Sam Spilsbury
= keyboard-test.c $(weston_test_client_src) keyboard_weston_LDADD = $(weston_test_client_libs) diff --git a/tests/vertex-clip-test.c b/tests/vertex-clip-test.c new file mode 100644 index 000..51188b2 --- /dev/null +++ b/tests/vertex-clip-test.c @@ -0,0 +1,219 @@ +/* + * Copyright © 2013 Sam

[PATCH 0/4] Table driven tests for the vertex clipping code

2013-09-12 Thread Sam Spilsbury
into libraries for testing purposes later. Also renamed libshared_test to libshared-test Sam Spilsbury (4): Remove AM_LDFLAGS usage Add support for table-driven testing. Split vertex clipping code out into vertex-clipping.c Added tests for the vertex clipping code. src/Makefile.am

[PATCH 1/4] Remove AM_LDFLAGS usage

2013-09-12 Thread Sam Spilsbury
We are not building everything here as a module, only the test modules. --- tests/Makefile.am | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 398a275..3a36619 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -7,6

[PATCH 2/4] Add support for table-driven testing.

2013-09-12 Thread Sam Spilsbury
/weston-test-runner.h b/tests/weston-test-runner.h index 41df386..457cf31 100644 --- a/tests/weston-test-runner.h +++ b/tests/weston-test-runner.h @@ -1,5 +1,6 @@ /* * Copyright © 2012 Intel Corporation + * Copyright © 2013 Sam Spilsbury smspil...@gmail.com * * Permission to use, copy, modify

[PATCH 3/4] Split vertex clipping code out into vertex-clipping.c

2013-09-12 Thread Sam Spilsbury
--- src/Makefile.am | 4 +- src/gl-renderer.c | 292 +- src/vertex-clipping.c | 317 ++ src/vertex-clipping.h | 65 +++ 4 files changed, 389 insertions(+), 289 deletions(-) create

[PATCH 4/4] Added tests for the vertex clipping code.

2013-09-12 Thread Sam Spilsbury
-clip-test.c @@ -0,0 +1,219 @@ +/* + * Copyright © 2013 Sam Spilsbury smspil...@gmail.com + * + * Permission to use, copy, modify, distribute, and sell this software and + * its documentation for any purpose is hereby granted without fee, provided + * that the above copyright notice appear in all

Re: [PATCH weston 1/5] tests: always build tests

2013-09-11 Thread Sam Spilsbury
) +$(weston_tests)\ +matrix-test AM_CFLAGS = $(GCC_CFLAGS) AM_CPPFLAGS =\ ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel -- Sam

Re: [PATCH weston 1/5] tests: always build tests

2013-09-11 Thread Sam Spilsbury
On Wed, Sep 11, 2013 at 8:38 PM, sardemff7+wayl...@sardemff7.net wrote: On 11/09/2013 11:12, Sam Spilsbury wrote: Quick thought: there's also an important psychological effect to building the tests on a standard make because it promotes them to the same importance as the rest of your code

[PATCH 0/4] Table driven tests for the vertex clipping code

2013-09-11 Thread Sam Spilsbury
. Sam Spilsbury (4): Remove AM_LDFLAGS usage Add support for table-driven testing. Split vertex clipping code out into vertex-clipping.c in shared/ Added tests for the vertex clipping code. shared/Makefile.am | 4 +- shared/vertex-clipping.c | 317

[PATCH 1/4] Remove AM_LDFLAGS usage

2013-09-11 Thread Sam Spilsbury
We are not building everything here as a module, only the test modules. --- tests/Makefile.am | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 82bf630..6234aa2 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -49,7 +49,7

[PATCH 2/4] Add support for table-driven testing.

2013-09-11 Thread Sam Spilsbury
-runner.h +++ b/tests/weston-test-runner.h @@ -1,5 +1,6 @@ /* * Copyright © 2012 Intel Corporation + * Copyright © 2013 Sam Spilsbury smspil...@gmail.com * * Permission to use, copy, modify, distribute, and sell this software and * its documentation for any purpose is hereby granted without

[PATCH 4/4] Added tests for the vertex clipping code.

2013-09-11 Thread Sam Spilsbury
) keyboard_weston_LDADD = $(weston_test_client_libs) diff --git a/tests/vertex-clip-test.c b/tests/vertex-clip-test.c new file mode 100644 index 000..51188b2 --- /dev/null +++ b/tests/vertex-clip-test.c @@ -0,0 +1,219 @@ +/* + * Copyright © 2013 Sam Spilsbury smspil...@gmail.com + * + * Permission to use, copy

Re: [PATCH 1/3] Add support for table-driven testing.

2013-09-10 Thread Sam Spilsbury
Spilsbury Sent: Tuesday, September 10, 2013 9:15 AM To: wayland-devel@lists.freedesktop.org Cc: Sam Spilsbury Subject: [PATCH 1/3] Add support for table-driven testing. The new TEST_P macro takes a function name and a data argument to point to an arbitrary array of known size

Re: [PATCH 3/3] Added tests for the vertex clipping code.

2013-09-10 Thread Sam Spilsbury
Spilsbury Sent: Tuesday, September 10, 2013 9:15 AM To: wayland-devel@lists.freedesktop.org Cc: Sam Spilsbury Subject: [PATCH 3/3] Added tests for the vertex clipping code. This tests (via the table-driven testing method) that the correct number of vertices and also the correct vertices

[PATCH 0/3] Tests for vertex clipping (v2)

2013-09-10 Thread Sam Spilsbury
into libshared_test.a so that we don't need to recompile it all the time Sam Spilsbury (3): Add support for table-driven testing. Split vertex clipping code out into vertex-clipping.c in shared/ Added tests for the vertex clipping code. shared/Makefile.am | 4 +- shared/vertex

[PATCH 1/3] Add support for table-driven testing.

2013-09-10 Thread Sam Spilsbury
-test-runner.h +++ b/tests/weston-test-runner.h @@ -1,5 +1,6 @@ /* * Copyright © 2012 Intel Corporation + * Copyright © 2013 Sam Spilsbury smspil...@gmail.com * * Permission to use, copy, modify, distribute, and sell this software and * its documentation for any purpose is hereby granted

[PATCH 3/3] Added tests for the vertex clipping code.

2013-09-10 Thread Sam Spilsbury
= $(weston_test_client_libs) diff --git a/tests/vertex-clip-test.c b/tests/vertex-clip-test.c new file mode 100644 index 000..51188b2 --- /dev/null +++ b/tests/vertex-clip-test.c @@ -0,0 +1,219 @@ +/* + * Copyright © 2013 Sam Spilsbury smspil...@gmail.com + * + * Permission to use, copy, modify, distribute

[PATCH 2/3] Split vertex clipping code out into vertex-clipping.c in shared/

2013-09-10 Thread Sam Spilsbury
--- shared/Makefile.am | 4 +- shared/vertex-clipping.c | 317 +++ shared/vertex-clipping.h | 65 ++ src/gl-renderer.c| 292 +-- 4 files changed, 389 insertions(+), 289 deletions(-)

[PATCH 1/3] Add support for table-driven testing.

2013-09-10 Thread Sam Spilsbury
-runner.h +++ b/tests/weston-test-runner.h @@ -1,5 +1,6 @@ /* * Copyright © 2012 Intel Corporation + * Copyright © 2013 Sam Spilsbury smspil...@gmail.com * * Permission to use, copy, modify, distribute, and sell this software and * its documentation for any purpose is hereby granted without

Re: Clarifying scope and goals for weston

2013-05-01 Thread Sam Spilsbury
On Wed, May 1, 2013 at 2:01 PM, Kristian Høgsberg hoegsb...@gmail.com wrote: On Fri, Apr 19, 2013 at 11:03:16PM -0700, Kenneth Graunke wrote: On 04/18/2013 12:04 AM, Sam Spilsbury wrote: On Wed, Apr 17, 2013 at 1:34 PM, Kristian Høgsberg hoegsb...@gmail.com wrote: [snip] Toolkit type

Re: [RFC] [tests] Running the wayland tests against compositor-headless

2013-04-23 Thread Sam Spilsbury
On Mon, Apr 22, 2013 at 11:02 PM, Eoff, Ullysses A ullysses.a.e...@intel.com wrote: -Original Message- From: Sam Spilsbury [mailto:smspil...@gmail.com] snip snip Yes, it would be trivial to enable the input-based tests to run on the headless backend... however, it's unclear to me

Re: [RFC] [tests] Running the wayland tests against compositor-headless

2013-04-22 Thread Sam Spilsbury
A Sent: Monday, April 22, 2013 1:24 PM To: Sam Spilsbury; wayland Subject: RE: [RFC] [tests] Running the wayland tests against compositor-headless Changing the tests to run headless is probably not necessary... To clarify... I only meant this in the context of the weston-tests-env script

Re: [RFC] [tests] Running the wayland tests against compositor-headless

2013-04-22 Thread Sam Spilsbury
@lists.freedesktop.org [mailto:wayland-devel- bounces+ullysses.a.eoff=intel@lists.freedesktop.org] On Behalf Of Sam Spilsbury Sent: Monday, April 22, 2013 11:50 AM To: wayland Subject: [RFC] [tests] Running the wayland tests against compositor-headless Hi, I'm not sure

Re: Compiz is Dead - Beryl Lives Again? Enter - Northfield/Norwood

2013-03-25 Thread Sam Spilsbury
by an aspiring college student, Sam Spilsbury. Eventually, Canonical realized that they wanted to do Unity but didn't really have the manpower required to do something entirely original. instead, the ployed to use compiz as a base platform for their Unity implementation. To this day, I still do support

Expected behaviour of eglSwapBuffers and the event queue

2013-02-28 Thread Sam Spilsbury
there was. Best Regards, Sam -- Sam Spilsbury ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Expected behaviour of eglSwapBuffers and the event queue

2013-02-28 Thread Sam Spilsbury
of the fd until you got your reply. If there were no more events delivered after that then surely we have to do something to ensure that clients don't block forever in poll (). Best, Sam Cheers, Daniel -- Sam Spilsbury ___ wayland-devel mailing

Re: Window stacking

2011-09-17 Thread Sam Spilsbury
On Wed, Sep 14, 2011 at 11:35 PM, Giovanni Campagna scampa.giova...@gmail.com wrote: Il giorno mer, 14/09/2011 alle 21.56 +0800, Sam Spilsbury ha scritto: On Wed, Sep 14, 2011 at 12:13 PM, Bill Spitzak spit...@gmail.com wrote: Along with all the discussion about client-side decorations

Re: seprate window management component

2011-09-15 Thread Sam Spilsbury
the window manager must process requests after the fact in some cases) Regards, Thanks Michal ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel -- Sam Spilsbury

Re: Window stacking

2011-09-14 Thread Sam Spilsbury
/mailman/listinfo/wayland-devel -- Sam Spilsbury ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: client side decorations

2011-05-06 Thread Sam Spilsbury
manager level, so that the applications on the system actually obey what the user wants them to do, not some crazy idea that the application developer had. Kind Regards, Sam -- Sam Spilsbury ___ wayland-devel mailing list wayland-devel

Re: What's wrong with wayland?

2011-02-20 Thread Sam Spilsbury
-- ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel -- Sam Spilsbury ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http

Re: What's wrong with wayland?

2011-02-19 Thread Sam Spilsbury
/listinfo/wayland-devel -- Sam Spilsbury ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Checklist: Programmer viewpoint

2011-01-27 Thread Sam Spilsbury
___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel -- Sam Spilsbury ___ wayland-devel mailing list wayland-devel

Re: Client side input processing

2010-12-10 Thread Sam Spilsbury
-- Sam Spilsbury ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel