Re: [PATCH] compositor: add dpms and backlight support

2012-02-29 Thread Kristian Hoegsberg
On Wed, Feb 29, 2012 at 10:45:35AM -0800, Jesse Barnes wrote: > Looks pretty good, thanks. For future patches can you include a > version and short changelog of what's changed from the last patch? > Just makes things easier to track (even for the patch author, in my > experience). > > Few notes o

Re: [PATCH] compositor: add dpms and backlight support

2012-02-29 Thread Jesse Barnes
Looks pretty good, thanks. For future patches can you include a version and short changelog of what's changed from the last patch? Just makes things easier to track (even for the patch author, in my experience). Few notes on this: - do we need all the dpms values? on and off seem to be all tha

[PATCH] compositor: add dpms and backlight support

2012-02-29 Thread Tiago Vignatti
DPMS kicks in only when wscreensaver is launched, in the moment that shell call lock() for the second time. Backlight control internals are managed by libbacklight: http://cgit.freedesktop.org/~vignatti/libbacklight/ Signed-off-by: Tiago Vignatti --- Thanks Jesse and Kristian for the co