Re: [PATCH] configure.ac: Do not make missing colord or libunwind a hard failure

2013-06-03 Thread Othman, Ossama
Hi Daniel, On Mon, Jun 3, 2013 at 11:45 AM, Daniel Stone wrote: > > The usual pattern here is to set the default to 'auto', which will > check whether or not the dependency is installed and select yes or no > accordingly. If someone explicitly passes --enable-colord and it's > not installed, we

Re: [PATCH] configure.ac: Do not make missing colord or libunwind a hard failure

2013-06-03 Thread Daniel Stone
Hi, On 3 June 2013 19:41, Ossama Othman wrote: > -AM_CONDITIONAL(ENABLE_COLORD, > - test "x$enable_colord" = "xyes") > if test x$enable_colord = xyes; then > - PKG_CHECK_MODULES(COLORD, colord >= 0.1.27) > + PKG_CHECK_MODULES([COLORD], > +[colord >= 0.1.27], >

[PATCH] configure.ac: Do not make missing colord or libunwind a hard failure

2013-06-03 Thread Ossama Othman
Both colord and libunwind are optional dependencies. As such, the configure script should not exit with a failure if they are missing. Issue warnings instead if either colord or libunwind is missing and wasn't found. This also allows "make distcheck" to succeed on platforms that don't have colord