Re: [PATCH] linux-dmabuf: un-deprecate format events

2019-04-12 Thread Chia-I Wu
I agree using DRM_FORMAT_MOD_INVALID for implicit modifier is simplest. Let's move the discussion to the other patch which does that. On Fri, Apr 12, 2019 at 2:17 AM Pekka Paalanen wrote: > On Thu, 11 Apr 2019 15:33:06 -0700 > Chia-I Wu wrote: > > > On Thu, Apr 11, 2019 at 7:12 AM Simon Ser

Re: [PATCH] linux-dmabuf: un-deprecate format events

2019-04-12 Thread Pekka Paalanen
On Thu, 11 Apr 2019 15:33:06 -0700 Chia-I Wu wrote: > On Thu, Apr 11, 2019 at 7:12 AM Simon Ser wrote: > > > On Thursday, April 11, 2019 11:48 AM, Pekka Paalanen > > wrote: > > > At first read of your commit message, I got the feeling you want > > > formats to be advertised by both events:

Re: [PATCH] linux-dmabuf: un-deprecate format events

2019-04-11 Thread Chia-I Wu
On Thu, Apr 11, 2019 at 7:12 AM Simon Ser wrote: > On Thursday, April 11, 2019 11:48 AM, Pekka Paalanen > wrote: > > Hi, > > > > at first hand, I would keep Weston's behaviour, because that is what > > the current protocol specification says exactly. The specification text > > is very clear on

Re: [PATCH] linux-dmabuf: un-deprecate format events

2019-04-11 Thread Simon Ser
On Thursday, April 11, 2019 11:48 AM, Pekka Paalanen wrote: > Hi, > > at first hand, I would keep Weston's behaviour, because that is what > the current protocol specification says exactly. The specification text > is very clear on the intent: the old format event is not to be used, if > both

Re: [PATCH] linux-dmabuf: un-deprecate format events

2019-04-11 Thread Pekka Paalanen
On Wed, 10 Apr 2019 14:00:12 -0700 Chia-I Wu wrote: > On Wed, Apr 10, 2019 at 12:40 PM Simon Ser wrote: > > > On Wednesday, April 10, 2019 9:25 PM, Chia-I Wu wrote: > > > Both implementations support formats that have no explicit modifiers. > > > But when it comes to buffer creation,

Re: [PATCH] linux-dmabuf: un-deprecate format events

2019-04-10 Thread Chia-I Wu
On Wed, Apr 10, 2019 at 12:40 PM Simon Ser wrote: > On Wednesday, April 10, 2019 9:25 PM, Chia-I Wu wrote: > > Both implementations support formats that have no explicit modifiers. > > But when it comes to buffer creation, modifier_hi/lo is required > > again. It is unclear how to create a

Re: [PATCH] linux-dmabuf: un-deprecate format events

2019-04-10 Thread Simon Ser
On Wednesday, April 10, 2019 9:25 PM, Chia-I Wu wrote: > Both implementations support formats that have no explicit modifiers. > But when it comes to buffer creation, modifier_hi/lo is required > again.  It is unclear how to create a buffer for such formats. > > This patch tries to clarify these

Re: [PATCH] linux-dmabuf: un-deprecate format events

2019-04-10 Thread Chia-I Wu
In the prior version, "modifier" events could be used to advertise either formats or modifiers. For example, they could be used to advertise formats that have no modifiers, by setting the modifier_hi/lo to DRM_FORMAT_MOD_INVALID. In this version, "format" events are used to advertise formats and

Re: [PATCH] linux-dmabuf: un-deprecate format events

2019-04-10 Thread Pekka Paalanen
On Tue, 9 Apr 2019 15:22:13 -0700 Chia-I Wu wrote: > Format events are used to return supported formats while modifier > evetns are used to return supported modifiers for each supported > format. > > For example, if an implementation is based on EGL, it may send one > format event for each

Re: [PATCH] linux-dmabuf: un-deprecate format events

2019-04-09 Thread Simon Ser
Hi, Thanks for your patch. On Wednesday, April 10, 2019 1:22 AM, Chia-I Wu wrote: > Format events are used to return supported formats while modifier > evetns are used to return supported modifiers for each supported Typo: events > format. > > For example, if an implementation is based on

[PATCH] linux-dmabuf: un-deprecate format events

2019-04-09 Thread Chia-I Wu
Format events are used to return supported formats while modifier evetns are used to return supported modifiers for each supported format. For example, if an implementation is based on EGL, it may send one format event for each format returned by eglQueryDmaBufFormatsEXT, and one modifier event