Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-23 Thread Pekka Paalanen
On Tue, 23 Sep 2014 15:34:07 +0200 Hardening wrote: > Le 23/09/2014 09:37, Pekka Paalanen a écrit : > > I believe some of the details here are only to cater for RDP, like > > non-enumerable modes. > > > I may be wrong but I remember a conversation where someone was telling > that DRM also have a

Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-23 Thread Derek Foreman
On 23/09/14 08:34 AM, Hardening wrote: > Le 23/09/2014 09:37, Pekka Paalanen a écrit : >> On Mon, 22 Sep 2014 11:01:10 -0500 >> Derek Foreman wrote: >> >>> On 22/09/14 06:41 AM, Pekka Paalanen wrote: On Fri, 19 Sep 2014 14:43:23 -0500 Derek Foreman wrote: > Calling weston_outpu

Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-23 Thread Hardening
Le 23/09/2014 09:37, Pekka Paalanen a écrit : > On Mon, 22 Sep 2014 11:01:10 -0500 > Derek Foreman wrote: > >> On 22/09/14 06:41 AM, Pekka Paalanen wrote: >>> On Fri, 19 Sep 2014 14:43:23 -0500 >>> Derek Foreman wrote: >>> Calling weston_output_mode_switch() with WESTON_MODE_SWITCH_RESTORE_

Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-23 Thread Pekka Paalanen
On Mon, 22 Sep 2014 11:01:10 -0500 Derek Foreman wrote: > On 22/09/14 06:41 AM, Pekka Paalanen wrote: > > On Fri, 19 Sep 2014 14:43:23 -0500 > > Derek Foreman wrote: > > > >> Calling weston_output_mode_switch() with WESTON_MODE_SWITCH_RESTORE_NATIVE > >> will result in the mode being set "back"

Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-22 Thread Derek Foreman
On 22/09/14 06:41 AM, Pekka Paalanen wrote: > On Fri, 19 Sep 2014 14:43:23 -0500 > Derek Foreman wrote: > >> Calling weston_output_mode_switch() with WESTON_MODE_SWITCH_RESTORE_NATIVE >> will result in the mode being set "back" to the passed in mode - so the >> passed mode should be the native mo

Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-22 Thread Pekka Paalanen
On Fri, 19 Sep 2014 14:43:23 -0500 Derek Foreman wrote: > Calling weston_output_mode_switch() with WESTON_MODE_SWITCH_RESTORE_NATIVE > will result in the mode being set "back" to the passed in mode - so the > passed mode should be the native mode. That's kind of silly, don't you think? :-) If it

[PATCH] shell: fix weston_output_mode_switch() usage

2014-09-19 Thread Derek Foreman
Calling weston_output_mode_switch() with WESTON_MODE_SWITCH_RESTORE_NATIVE will result in the mode being set "back" to the passed in mode - so the passed mode should be the native mode. Additionally, weston_output_mode_switch() should be called when output->original_mode is non-NULL (which indicat