Re: [PATCH] src/shell.c: set black_surface->width and height

2013-11-29 Thread Kristian Høgsberg
On Fri, Nov 29, 2013 at 11:18:14AM +0800, Xiong Zhang wrote: > From: XiongZhang Btw, it looks like you have your email name set up in .gitconfig as "XiongZhang" not "Xiong Zhang". Is that intentional? I've edited it to "Xiong Zhang" as I commit seeing how your sign-off below has the space in it.

Re: [PATCH] src/shell.c: set black_surface->width and height

2013-11-29 Thread Kristian Høgsberg
On Fri, Nov 29, 2013 at 10:10:00AM +0200, Pekka Paalanen wrote: > On Fri, 29 Nov 2013 11:18:14 +0800 > Xiong Zhang wrote: > > > From: XiongZhang > > > > full screen black_surface doesn't have associated wl_buffer, so > > black_surface->width and height can't get value through > > weston_surface

Re: [PATCH] src/shell.c: set black_surface->width and height

2013-11-29 Thread Pekka Paalanen
On Fri, 29 Nov 2013 11:18:14 +0800 Xiong Zhang wrote: > From: XiongZhang > > full screen black_surface doesn't have associated wl_buffer, so > black_surface->width and height can't get value through > weston_surface_commit(). then weston_surface_damage(black_surface) > will be wrong in shell_st

[PATCH] src/shell.c: set black_surface->width and height

2013-11-28 Thread Xiong Zhang
From: XiongZhang full screen black_surface doesn't have associated wl_buffer, so black_surface->width and height can't get value through weston_surface_commit(). then weston_surface_damage(black_surface) will be wrong in shell_stack_fullscreen(), the result is that we can't see a full screen vie