[PATCH] xwayland: Handle the wl_keyboard modifiers event

2013-10-22 Thread Rui Matos
This allows us to keep track of latched and locked modifiers as well as the XKB group while the keyboard focus is on another wayland client. Note that we don't need to track depressed modifiers since wayland guarantees that we'll get them as key press events whenever we get the keyboard focus. ---

Re: [PATCH] xwayland: Handle the wl_keyboard modifiers event

2014-01-08 Thread Rui Tiago Cação Matos
Hi, this patch still applies after the xwayland branch rebase. Pinging for review. Thanks, Rui On 22 October 2013 16:52, Rui Matos wrote: > This allows us to keep track of latched and locked modifiers as well > as the XKB group while the keyboard focus is on another wayland > client. Note that

Re: [PATCH] xwayland: Handle the wl_keyboard modifiers event

2014-01-08 Thread Kristian Høgsberg
On Tue, Oct 22, 2013 at 04:52:06PM +0200, Rui Matos wrote: > This allows us to keep track of latched and locked modifiers as well > as the XKB group while the keyboard focus is on another wayland > client. Note that we don't need to track depressed modifiers since > wayland guarantees that we'll ge

Re: [PATCH] xwayland: Handle the wl_keyboard modifiers event

2013-10-22 Thread Bill Spitzak
Are "latched modifiers" things like the Compose Key and dead-key accent prefixes? I think this is usually dropped when the focus changes. It also seems like these should be handled by the input method. I don't like the fact that clients can figure out European composed characters without corr

Re: [PATCH] xwayland: Handle the wl_keyboard modifiers event

2013-10-22 Thread Daniel Stone
On 22 October 2013 21:05, Bill Spitzak wrote: > Are "latched modifiers" things like the Compose Key and dead-key accent > prefixes? No, they're more akin to StickyKeys. > I think this is usually dropped when the focus changes. > > It also seems like these should be handled by the input method. I