Re: [PATCH 01/12] Fixes to parse_options

2014-08-20 Thread Pekka Paalanen
On Tue, 19 Aug 2014 12:12:28 -0700 Bill Spitzak spit...@gmail.com wrote: On 08/19/2014 02:18 AM, Pekka Paalanen wrote: Multiple single-letter booleans in one switch allowed, ie -xyz is the same as -x -y -z. For wayland modules they all have to belong to the same module. This was

Re: [PATCH 01/12] Fixes to parse_options

2014-08-20 Thread Bill Spitzak
On 08/20/2014 05:27 AM, Pekka Paalanen wrote: The old code basically did *(string+strlen(string)+1) if the string did not have an = sign in it, passing that pointer to the argument parser. Probably this always fails parsing without a segfault but technically it is wrong, it could segfault, or

Re: [PATCH 01/12] Fixes to parse_options

2014-08-19 Thread Pekka Paalanen
On Fri, 8 Aug 2014 12:59:50 -0700 Bill Spitzak spit...@gmail.com wrote: Fail on malformed numbers, such as --width=100mm Good. Fail on = after booleans, such as --flag=false Okay. Multiple single-letter booleans in one switch allowed, ie -xyz is the same as -x -y -z. For wayland modules

[PATCH 01/12] Fixes to parse_options

2014-08-08 Thread Bill Spitzak
Fail on malformed numbers, such as --width=100mm Fail on = after booleans, such as --flag=false Multiple single-letter booleans in one switch allowed, ie -xyz is the same as -x -y -z. For wayland modules they all have to belong to the same module. Previous version could use text after the null