Re: [PATCH 1/2] Clarify the enum argument type

Hi, I would recommend to also include the name of the interface, where the enum is defined, in the enum attribute, e.g: Also, I think you forgot some enum attributes, e.g. wl_shm_pool:: create_buffer::format is the wl_shm::format enum, but I can't find it in your patch (I can't seem to find the

Re: [PATCH 1/2] Clarify the enum argument type

On Thu, Oct 1, 2015 at 8:09 AM, Nils Chr. Brause wrote: > Hi, > > I would recommend to also include the name of the interface, where the > enum is defined, in the enum attribute, e.g: > > I believe popular opinion was that a "local" enum, belonging to the same object

Re: [PATCH 1/2] Clarify the enum argument type

On Thu, Oct 1, 2015 at 9:00 PM, Bill Spitzak wrote: > > > On Thu, Oct 1, 2015 at 8:09 AM, Nils Chr. Brause > wrote: >> >> Hi, >> >> I would recommend to also include the name of the interface, where the >> enum is defined, in the enum attribute, e.g:

Re: [PATCH 1/2] Clarify the enum argument type

On Thu, Oct 1, 2015 at 12:09 PM, Nils Chr. Brause wrote: > On Thu, Oct 1, 2015 at 9:00 PM, Bill Spitzak wrote: > > > > > > On Thu, Oct 1, 2015 at 8:09 AM, Nils Chr. Brause < > nilschrbra...@gmail.com> > > wrote: > >> > >> Hi, > >> > >> I would

[PATCH 1/2] Clarify the enum argument type

This improvement to the protocol allows you to refer to the kind of enum you are expecting. It also introduces a distinction between enums that are bitfields, ie that can be OR'ed together. --- protocol/wayland.dtd |2 ++ protocol/wayland.xml | 32 2 files