[PATCH 1/2 v2] version: Fix WESTON_VERSION_AT_LEAST macro

2014-01-24 Thread U. Artie Eoff
From: "U. Artie Eoff" Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=74023 Signed-off-by: U. Artie Eoff --- src/version.h.in | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/version.h.in b/src/version.h.in index 79dba45..e72fea8 100644 --- a/src/version.h.i

Re: [PATCH 1/2 v2] version: Fix WESTON_VERSION_AT_LEAST macro

2014-01-24 Thread Daniel Stone
Hi, The macro should really be called WESTON_VERSION_COMPATIBLE_WITH() - it's done that way specifically to allow breaking API/ABI at least every minor release. Cheers, Daniel On 24 January 2014 19:11, U. Artie Eoff wrote: > From: "U. Artie Eoff" > > Fixes: https://bugs.freedesktop.org/show_bug

RE: [PATCH 1/2 v2] version: Fix WESTON_VERSION_AT_LEAST macro

2014-01-24 Thread Eoff, Ullysses A
patible with another major or minor release", regardless of API/ABI changes. > -Original Message- > From: Daniel Stone [mailto:dan...@fooishbar.org] > Sent: Friday, January 24, 2014 12:37 PM > To: Eoff, Ullysses A > Cc: wayland-devel@lists.freedesktop.org &g

RE: [PATCH 1/2 v2] version: Fix WESTON_VERSION_AT_LEAST macro

2014-01-24 Thread Eoff, Ullysses A
; Ullysses A > Sent: Friday, January 24, 2014 1:05 PM > To: Daniel Stone > Cc: wayland-devel@lists.freedesktop.org > Subject: RE: [PATCH 1/2 v2] version: Fix WESTON_VERSION_AT_LEAST macro > > Even with just a rename, if the API/ABI doesn't change from 1.

Re: [PATCH 1/2 v2] version: Fix WESTON_VERSION_AT_LEAST macro

2014-01-24 Thread Bill Spitzak
If a feature remains in N minor versions the programmer would have to put in N compatable-with macros to enable it. They would also have to update the code every time a new minor version comes out (or just predict a number of minor versions into the future and put in a bunch of calls to this).

Re: [PATCH 1/2 v2] version: Fix WESTON_VERSION_AT_LEAST macro

2014-01-25 Thread Pier Luigi
he macro name. > >> -Original Message- >> From: wayland-devel-boun...@lists.freedesktop.org >> [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Eoff, >> Ullysses A >> Sent: Friday, January 24, 2014 1:05 PM >> To: Daniel Stone >> Cc: w

Re: [PATCH 1/2 v2] version: Fix WESTON_VERSION_AT_LEAST macro

2014-01-27 Thread Kristian Høgsberg
> appropriately reflects the macro name. >> >>> -Original Message- >>> From: wayland-devel-boun...@lists.freedesktop.org >>> [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Eoff, >>> Ullysses A >>> Sent: Friday, January 24, 2014 1:05 PM