Re: [PATCH 1/3] tests: Demarshalling of very long array/string lengths.

2018-08-17 Thread Michal Srb
On pátek 17. srpna 2018 15:15:55 CEST Pekka Paalanen wrote: > Hi Michal, Hi, Thank you for the reviews. I will work on the changes. Some answers below. > > + 0x, 0xfffe, 0xfffd, 0xfffc, > > + 0xf000, 0xd000, 0xc000, 0xb000 > > What is the

Re: [PATCH 1/3] tests: Demarshalling of very long array/string lengths.

2018-08-17 Thread Pekka Paalanen
On Tue, 14 Aug 2018 13:07:51 +0200 Michal Srb wrote: > Attempting to demarshal message with array or string longer than its > body should return failure. Handling the length correctly is tricky when > it gets to near-UINT32_MAX values. Unexpected overflows can cause > crashes and other security i

[PATCH 1/3] tests: Demarshalling of very long array/string lengths.

2018-08-14 Thread Michal Srb
Attempting to demarshal message with array or string longer than its body should return failure. Handling the length correctly is tricky when it gets to near-UINT32_MAX values. Unexpected overflows can cause crashes and other security issues. These tests verify that demarshalling such message give