On Wed, 13 Apr 2016 11:38:37 -0700
Bryce Harrington wrote:
> On Wed, Apr 13, 2016 at 02:47:06PM +0300, Pekka Paalanen wrote:
> > On Tue, 12 Apr 2016 21:44:10 -0700
> > Bryce Harrington wrote:
> >
> > > On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote:
> > > > On Mon, 21 Mar 20
On Wed, Apr 13, 2016 at 02:47:06PM +0300, Pekka Paalanen wrote:
> On Tue, 12 Apr 2016 21:44:10 -0700
> Bryce Harrington wrote:
>
> > On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote:
> > > On Mon, 21 Mar 2016 23:11:29 +0100
> > > Benoit Gschwind wrote:
> > >
> > > > Hello,
> > >
On Tue, 12 Apr 2016 21:44:10 -0700
Bryce Harrington wrote:
> On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote:
> > On Mon, 21 Mar 2016 23:11:29 +0100
> > Benoit Gschwind wrote:
> >
> > > Hello,
> > >
> > > I think that struct_version and struct_size should not be belong
> > > c
On Tue, Apr 12, 2016 at 09:44:10PM -0700, Bryce Harrington wrote:
> On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote:
> > On Mon, 21 Mar 2016 23:11:29 +0100
> > Benoit Gschwind wrote:
> >
> > > Hello,
> > >
> > > I think that struct_version and struct_size should not be belong
> >
On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote:
> On Mon, 21 Mar 2016 23:11:29 +0100
> Benoit Gschwind wrote:
>
> > Hello,
> >
> > I think that struct_version and struct_size should not be belong
> > compositor.h. I think those versioning should be back-end detail, and
> > each b
On Mon, 21 Mar 2016 23:11:29 +0100
Benoit Gschwind wrote:
> Hello,
>
> I think that struct_version and struct_size should not be belong
> compositor.h. I think those versioning should be back-end detail, and
> each back-end should provide a major version number through #define in
> the backend h
Hello,
I think that struct_version and struct_size should not be belong
compositor.h. I think those versioning should be back-end detail, and
each back-end should provide a major version number through #define in
the backend header.
Otherwise the patch look good
Best regards.
Reviewed-by: Benoi
With this struct versioning, it is possible to add new options without
breaking the ABI, as long as all additions are made to the end of a
struct and nothing existing is modified or removed. When things are
added, the structure's size will increase, and we'll use this size as
our minor version num
