Re: [PATCH 4/6] text: start support for keyboard events

2012-07-22 Thread Kristian Høgsberg
On Sun, Jul 22, 2012 at 07:58:34PM +0200, Philipp Brüschweiler wrote: > Hi Kristian, > > Thank you for including my patches. I'll try to follow the style > guidelines from now on :) Heh, sounds good. It was mostly all good though, just a few nit-picks. > On Sun, Jul 22, 2012 at 6:24 PM, Kristia

Re: [PATCH 4/6] text: start support for keyboard events

2012-07-22 Thread Philipp Brüschweiler
Hi Kristian, Thank you for including my patches. I'll try to follow the style guidelines from now on :) On Sun, Jul 22, 2012 at 6:24 PM, Kristian Høgsberg wrote: > On Wed, Jul 11, 2012 at 10:25:32PM +0200, Philipp Brüschweiler wrote: >> * add the request_keyboard_input request to signal that the

Re: [PATCH 4/6] text: start support for keyboard events

2012-07-22 Thread Kristian Høgsberg
On Wed, Jul 11, 2012 at 10:25:32PM +0200, Philipp Brüschweiler wrote: > * add the request_keyboard_input request to signal that the > input method wants to receive keyboard events > * add key and modifier events > * keyboard events are grabbed with wl_keyboard_grab and relayed > to the input me

[PATCH 4/6] text: start support for keyboard events

2012-07-11 Thread Philipp Brüschweiler
* add the request_keyboard_input request to signal that the input method wants to receive keyboard events * add key and modifier events * keyboard events are grabbed with wl_keyboard_grab and relayed to the input method --- protocol/text.xml | 28 +++ src/compositor.c | 15 +++---