Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Ran Benita
On Mon, Oct 27, 2014 at 09:26:39AM -0500, Derek Foreman wrote: Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. --- src/evdev.c | 10 ++ 1 file changed, 10

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Derek Foreman
On 27/10/14 07:11 PM, Peter Hutterer wrote: On Mon, Oct 27, 2014 at 09:33:45AM -0500, Derek Foreman wrote: A couple of questions on this one: Is it ok to limit logging to 10 messages like this? IMO yes. Should I be doing that on a per device basis instead of globally? you are doing it

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Derek Foreman
On 28/10/14 03:20 AM, Ran Benita wrote: On Mon, Oct 27, 2014 at 09:26:39AM -0500, Derek Foreman wrote: Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. --- src/evdev.c | 10

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Bill Spitzak
I can't imagine any way this static variable will mess up with multiple threads. At worst not exactly 10 messages will be printed but that seems really harmless. Every processor writes to memory a number larger than it read, so eventually every processor will see a number = 10 even if there

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Peter Hutterer
On Tue, Oct 28, 2014 at 02:18:25PM -0500, Derek Foreman wrote: On 28/10/14 03:20 AM, Ran Benita wrote: On Mon, Oct 27, 2014 at 09:26:39AM -0500, Derek Foreman wrote: Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Peter Hutterer
On Tue, Oct 28, 2014 at 09:32:20AM -0500, Derek Foreman wrote: On 27/10/14 07:11 PM, Peter Hutterer wrote: On Mon, Oct 27, 2014 at 09:33:45AM -0500, Derek Foreman wrote: A couple of questions on this one: Is it ok to limit logging to 10 messages like this? IMO yes. Should I be

[PATCH libinput] evdev: Log evdev event queue overflows

2014-10-27 Thread Derek Foreman
Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. --- src/evdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 1b4ce10..c786537

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-27 Thread Derek Foreman
A couple of questions on this one: Is it ok to limit logging to 10 messages like this? Should I be doing that on a per device basis instead of globally? (I'm totally unattached to the specifics of the log text, I believe X says something clever about how it's not the X server's fault to avoid

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-27 Thread Peter Hutterer
On Mon, Oct 27, 2014 at 09:33:45AM -0500, Derek Foreman wrote: A couple of questions on this one: Is it ok to limit logging to 10 messages like this? IMO yes. Should I be doing that on a per device basis instead of globally? you are doing it per-device here, I'm not sure what you mean with

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-27 Thread Peter Hutterer
On Mon, Oct 27, 2014 at 09:26:39AM -0500, Derek Foreman wrote: Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. --- src/evdev.c | 10 ++ 1 file changed, 10