Re: [PATCH libinput 2/6] Change a few functions that only ever returned 0 to voids

2016-07-19 Thread Peter Hutterer
On Tue, Jul 19, 2016 at 12:49:21PM -0700, Yong Bakos wrote: > Hi Peter, > I'm curious about the explicit return at the end of tp_process_button, > inline below... > > > > On Jul 18, 2016, at 5:49 PM, Peter Hutterer > > wrote: > > > > These are internal functions, if we need them to return an e

Re: [PATCH libinput 2/6] Change a few functions that only ever returned 0 to voids

2016-07-19 Thread Yong Bakos
Hi Peter, I'm curious about the explicit return at the end of tp_process_button, inline below... > On Jul 18, 2016, at 5:49 PM, Peter Hutterer wrote: > > These are internal functions, if we need them to return an error code we can > change that at any time. Meanwhile, if we only ever return 0 a

[PATCH libinput 2/6] Change a few functions that only ever returned 0 to voids

2016-07-18 Thread Peter Hutterer
These are internal functions, if we need them to return an error code we can change that at any time. Meanwhile, if we only ever return 0 anyway we might as well just make them voids to save on error paths. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 14 +++ src/e