Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-11-01 Thread Tomeu Vizoso
On 1 November 2013 02:35, Jason Ekstrand ja...@jlekstrand.net wrote: On Thu, Oct 31, 2013 at 4:59 AM, Tomeu Vizoso to...@tomeuvizoso.net wrote: On 31 October 2013 02:54, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Oct 30, 2013 at 3:59 AM, Tomeu Vizoso to...@tomeuvizoso.net wrote:

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-31 Thread Tomeu Vizoso
On 31 October 2013 02:54, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Oct 30, 2013 at 3:59 AM, Tomeu Vizoso to...@tomeuvizoso.net wrote: On 30 October 2013 09:44, Neil Roberts n...@linux.intel.com wrote: Tomeu Vizoso to...@tomeuvizoso.net writes: What I fail to see is why a single

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-31 Thread Jason Ekstrand
On Thu, Oct 31, 2013 at 4:59 AM, Tomeu Vizoso to...@tomeuvizoso.net wrote: On 31 October 2013 02:54, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Oct 30, 2013 at 3:59 AM, Tomeu Vizoso to...@tomeuvizoso.net wrote: On 30 October 2013 09:44, Neil Roberts n...@linux.intel.com wrote:

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-30 Thread Tomeu Vizoso
On 28 October 2013 11:19, Tomeu Vizoso to...@tomeuvizoso.net wrote: I'm still concerned about platforms with high resolution displays but relatively little memory. I'm thinking of the RPi, but my understanding is that Android goes to great lengths to reduce the number of buffers that

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-30 Thread Neil Roberts
Tomeu Vizoso to...@tomeuvizoso.net writes: What I fail to see is why a single sync should be enough, as we don't know when the GPU will signal that it's done with the buffer that we are waiting to be released. You are right that we don't know when the GPU will release the buffer. However we

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-30 Thread Tomeu Vizoso
On 30 October 2013 09:44, Neil Roberts n...@linux.intel.com wrote: Tomeu Vizoso to...@tomeuvizoso.net writes: What I fail to see is why a single sync should be enough, as we don't know when the GPU will signal that it's done with the buffer that we are waiting to be released. You are right

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-30 Thread Jason Ekstrand
On Oct 30, 2013 3:59 AM, Tomeu Vizoso to...@tomeuvizoso.net wrote: On 30 October 2013 09:44, Neil Roberts n...@linux.intel.com wrote: Tomeu Vizoso to...@tomeuvizoso.net writes: What I fail to see is why a single sync should be enough, as we don't know when the GPU will signal that it's

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-30 Thread Jason Ekstrand
On Wed, Oct 30, 2013 at 3:59 AM, Tomeu Vizoso to...@tomeuvizoso.net wrote: On 30 October 2013 09:44, Neil Roberts n...@linux.intel.com wrote: Tomeu Vizoso to...@tomeuvizoso.net writes: What I fail to see is why a single sync should be enough, as we don't know when the GPU will signal

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-29 Thread Neil Roberts
Jason Ekstrand ja...@jlekstrand.net writes: You don't have to continuously sync, just sync after every attach/commit. While it may be somewhat non-obvious, I don't see how calling sync once per frame is any worse than setting some flag somewhere. Hrmm thinking about it, I suppose sending the

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-28 Thread Tomeu Vizoso
On 25 October 2013 16:50, Neil Roberts n...@linux.intel.com wrote: Ok, here is version 4 of the patch taking into account the discussion with Jason Ekstrand. The assumption is that if we have enough buffer slots then we should always get a release event immediately after one of the attaches.

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-28 Thread Daniel Stone
Hi, On 28 October 2013 11:19, Tomeu Vizoso to...@tomeuvizoso.net wrote: I'm still concerned about platforms with high resolution displays but relatively little memory. I'm thinking of the RPi, but my understanding is that Android goes to great lengths to reduce the number of buffers that

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-28 Thread Neil Roberts
Just to be clear, I think the discussion about whether to queue release events is no longer related to implementing eglSwapInterval(0) so it shouldn't hold up the patch. As far as I understand if you want to render at the maximum rate you need four buffer slots and being able to disable the

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-28 Thread Jason Ekstrand
On Mon, Oct 28, 2013 at 9:10 AM, Neil Roberts n...@linux.intel.com wrote: Just to be clear, I think the discussion about whether to queue release events is no longer related to implementing eglSwapInterval(0) so it shouldn't hold up the patch. As far as I understand if you want to render at

[PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-25 Thread Neil Roberts
Ok, here is version 4 of the patch taking into account the discussion with Jason Ekstrand. The assumption is that if we have enough buffer slots then we should always get a release event immediately after one of the attaches. That means we can just rely on sending a sync request after the commit

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-25 Thread Jason Ekstrand
My knowledge of mesa and of the wl_display_prepare_read stuff is a bit lacking. From what I can see, it looks good. On Fri, Oct 25, 2013 at 9:50 AM, Neil Roberts n...@linux.intel.com wrote: Ok, here is version 4 of the patch taking into account the discussion with Jason Ekstrand. The