Re: [PATCH v2 wayland] protocol: add support for cross-interface enum attributes

2015-12-04 Thread Bill Spitzak
On Wed, Dec 2, 2015 at 7:19 AM, Nils Chr. Brause wrote: > On Wed, Dec 2, 2015 at 11:48 AM, Auke Booij wrote: > > I'd be happy to rebase against that, but since that hasn't been merged > > yet, I thought I'd take the current tree as a a basis. > > > > If

Re: [PATCH v2 wayland] protocol: add support for cross-interface enum attributes

2015-12-04 Thread Bryce Harrington
On Sun, Nov 29, 2015 at 01:54:46PM +, Auke Booij wrote: > The enum attribute, for which scanner support was introduced in > 1771299, can be used to link message arguments to s. However, > some arguments refer to s in a different . > > This adds scanner support for referring to an in a

Re: [PATCH v2 wayland] protocol: add support for cross-interface enum attributes

2015-12-02 Thread Bill Spitzak
Looks correct to me. I had a slightly different patch in patchwork which changes protocol-to-docbook. It puts the enumeration into it's own statement, rather than a nested if statement, and it adds the object:: prefix to the documentation for all enumerations, not just the cross-object ones. On

Re: [PATCH v2 wayland] protocol: add support for cross-interface enum attributes

2015-12-02 Thread Nils Chr. Brause
On Wed, Dec 2, 2015 at 11:48 AM, Auke Booij wrote: > I'd be happy to rebase against that, but since that hasn't been merged > yet, I thought I'd take the current tree as a a basis. > > If you think having the interface:: prefix everywhere makes sense, I > can change that if you

Re: [PATCH v2 wayland] protocol: add support for cross-interface enum attributes

2015-12-02 Thread Auke Booij
I'd be happy to rebase against that, but since that hasn't been merged yet, I thought I'd take the current tree as a a basis. If you think having the interface:: prefix everywhere makes sense, I can change that if you want. On 2 December 2015 at 03:09, Bill Spitzak wrote: >

[PATCH v2 wayland] protocol: add support for cross-interface enum attributes

2015-11-29 Thread Auke Booij
The enum attribute, for which scanner support was introduced in 1771299, can be used to link message arguments to s. However, some arguments refer to s in a different . This adds scanner support for referring to an in a different using dot notation. It also sets the attributes in this style in