Re: [PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

2016-06-23 Thread Daniel Stone
Hi, On 7 June 2016 at 03:29, Bryce Harrington wrote: > On Sun, Jun 05, 2016 at 07:01:11PM +0200, Benoit Gschwind wrote: >> sprintf can overflow the fixed length title which is char[32]. This >> patch change title to dynamically allocated char array using asprintf or >>

Re: [PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

2016-06-06 Thread Bryce Harrington
On Sun, Jun 05, 2016 at 07:01:11PM +0200, Benoit Gschwind wrote: > sprintf can overflow the fixed length title which is char[32]. This > patch change title to dynamically allocated char array using asprintf or > strdup. If one of them fail we leave returning NULL to indicate the > failure. > >

Re: [PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

2016-06-05 Thread Yong Bakos
On Jun 5, 2016, at 12:01 PM, Benoit Gschwind wrote: > > sprintf can overflow the fixed length title which is char[32]. This > patch change title to dynamically allocated char array using asprintf or > strdup. If one of them fail we leave returning NULL to indicate the >

[PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

2016-06-05 Thread Benoit Gschwind
sprintf can overflow the fixed length title which is char[32]. This patch change title to dynamically allocated char array using asprintf or strdup. If one of them fail we leave returning NULL to indicate the failure. Signed-of-by: Benoit Gschwind --- v3: - fix