Re: [PATCH v4 1/6] Added simple unit/integration test framework and corresponding test program.

2015-06-25 Thread Pekka Paalanen
On Tue, 23 Jun 2015 21:55:41 -0700 "Jon A. Cruz" wrote: > > On 06/22/2015 07:19 AM, Pekka Paalanen wrote: > > Hi Jon, > > > > this is just a quick casual look, so I'm only mentioning what cought my > > eye but mostly ignoring minor issues like style. > > > > I know you sent a v5 series, but it

Re: [PATCH v4 1/6] Added simple unit/integration test framework and corresponding test program.

2015-06-24 Thread Jon A. Cruz
On 06/24/2015 09:32 AM, Bill Spitzak wrote: > On Tue, Jun 23, 2015 at 9:55 PM, Jon A. Cruz wrote: > >> >> Looking into it more, I think I've figured out much of that on my part >> comes from C++ and other OO languages I've worked in. Especially with >> C++ one should start a class declaration wit

Re: [PATCH v4 1/6] Added simple unit/integration test framework and corresponding test program.

2015-06-24 Thread Bill Spitzak
On Tue, Jun 23, 2015 at 9:55 PM, Jon A. Cruz wrote: > > Looking into it more, I think I've figured out much of that on my part > comes from C++ and other OO languages I've worked in. Especially with > C++ one should start a class declaration with a single 'public' section > followed optionally by

Re: [PATCH v4 1/6] Added simple unit/integration test framework and corresponding test program.

2015-06-23 Thread Jon A. Cruz
On 06/22/2015 07:19 AM, Pekka Paalanen wrote: > Hi Jon, > > this is just a quick casual look, so I'm only mentioning what cought my > eye but mostly ignoring minor issues like style. > > I know you sent a v5 series, but it sounded like my comments here are > still applicable. > > I do get kind

Re: [PATCH v4 1/6] Added simple unit/integration test framework and corresponding test program.

2015-06-22 Thread Pekka Paalanen
Hi Jon, this is just a quick casual look, so I'm only mentioning what cought my eye but mostly ignoring minor issues like style. I know you sent a v5 series, but it sounded like my comments here are still applicable. I do get kind of confused every time a function is used earlier in the file tha