Re: [PATCH wayland] shm: add a note about shm pool base address changing

2016-02-09 Thread Pekka Paalanen
On Mon, 08 Feb 2016 12:23:58 -0600 Derek Foreman wrote: > On 05/02/16 08:50 AM, Derek Foreman wrote: > > On 05/02/16 07:25 AM, Pekka Paalanen wrote: > >> From: Pekka Paalanen > >> > >> Since shm_pool_resize() uses mremap(MREMAP_MAYMOVE),

Re: [PATCH wayland] shm: add a note about shm pool base address changing

2016-02-09 Thread Derek Foreman
On 09/02/16 05:56 AM, Pekka Paalanen wrote: > On Mon, 08 Feb 2016 12:23:58 -0600 > Derek Foreman wrote: > >> On 05/02/16 08:50 AM, Derek Foreman wrote: >>> On 05/02/16 07:25 AM, Pekka Paalanen wrote: From: Pekka Paalanen

Re: [PATCH wayland] shm: add a note about shm pool base address changing

2016-02-08 Thread Derek Foreman
On 05/02/16 08:50 AM, Derek Foreman wrote: > On 05/02/16 07:25 AM, Pekka Paalanen wrote: >> From: Pekka Paalanen >> >> Since shm_pool_resize() uses mremap(MREMAP_MAYMOVE), the pool's base >> address may change at that point. >> >> If a compositor stores the pointer

Re: [PATCH wayland] shm: add a note about shm pool base address changing

2016-02-05 Thread Derek Foreman
On 05/02/16 07:25 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Since shm_pool_resize() uses mremap(MREMAP_MAYMOVE), the pool's base > address may change at that point. > > If a compositor stores the pointer and a client enlarges the pool, the > compositor

[PATCH wayland] shm: add a note about shm pool base address changing

2016-02-05 Thread Pekka Paalanen
From: Pekka Paalanen Since shm_pool_resize() uses mremap(MREMAP_MAYMOVE), the pool's base address may change at that point. If a compositor stores the pointer and a client enlarges the pool, the compositor will have a stale pointer. Signed-off-by: Pekka Paalanen