Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-04 Thread Bill Spitzak
On Tue, Feb 2, 2016 at 4:58 AM, Jan Arne Petersen wrote: > > > On 29/01/16 00:33, Bill Spitzak wrote: > > > > > > On Wed, Jan 27, 2016 at 11:52 PM, Jan Arne Petersen > > wrote: > > > > > > + Text is generally UTF-8 encoded, indices and lengths are in > > by

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-04 Thread Bill Spitzak
On Tue, Feb 2, 2016 at 5:02 AM, Jan Arne Petersen wrote: > > > Besides allowing the user to return to a misspelled word, it may make > > sense to return to a preedit. I'm not sure as I have no experience with > > Asian input methods. But it does seem possible. > > Sorry no toolkit supports that.

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
On 29/01/16 21:43, Bill Spitzak wrote: > > > On Wed, Jan 27, 2016 at 11:52 PM, Jan Arne Petersen > wrote: > > > + > + > + Notify when a new composing text (pre-edit) should be set > around the > + current cursor position. An

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
On 29/01/16 00:33, Bill Spitzak wrote: > > > On Wed, Jan 27, 2016 at 11:52 PM, Jan Arne Petersen > wrote: > > > + Text is generally UTF-8 encoded, indices and lengths are in > bytes. > > > Remove the word "generally". *All* text in your api's are UTF-

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
Hi Rui, On 28/01/16 21:16, Rui Tiago Cação Matos wrote: > Hi, > > thanks for sending this. I was actually going to start a discussion > about the existing protocol but let's go from here instead. Comments > inline: > > First a question of scope: a client would only ever need to instance > one te

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
Hi, On 28/01/16 13:05, Daiki Ueno wrote: > Hello, > > Jan Arne Petersen writes: > >> Fixes some shortcomings of the first version: >> >> * Use only one wp_text_input per wl_seat (client side should be >> handled by client toolkit) >> * Allow focus tracking without wl_keyboard present > > The

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Jan Arne Petersen
On 28/01/16 11:05, Jonas Ådahl wrote: > On Thu, Jan 28, 2016 at 08:52:40AM +0100, Jan Arne Petersen wrote: >> There were some shortcomings in the first version of the protocol which >> makes it not really useful in real world applications. It is not really >> possible to fix them in a compatible

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-01-28 Thread Rui Tiago Cação Matos
Hi, thanks for sending this. I was actually going to start a discussion about the existing protocol but let's go from here instead. Comments inline: First a question of scope: a client would only ever need to instance one text_input object per wl_seat and then "associate" it with a particular wl_

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-01-28 Thread Daiki Ueno
Hello, Jan Arne Petersen writes: > Fixes some shortcomings of the first version: > > * Use only one wp_text_input per wl_seat (client side should be > handled by client toolkit) > * Allow focus tracking without wl_keyboard present These sound nice. > * Improve update state handling > * Allow

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-01-28 Thread Jan Arne Petersen
Hi, On 28/01/16 10:46, Giulio Camuffo wrote: >> + >> + >> + Sets the plain surrounding text around the input position. Text is >> + UTF-8 encoded. Cursor is the byte offset within the >> + surrounding text. Anchor is the byte offset of the >> + selection anchor wi

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-01-28 Thread Jonas Ådahl
On Thu, Jan 28, 2016 at 08:52:40AM +0100, Jan Arne Petersen wrote: > There were some shortcomings in the first version of the protocol which > makes it not really useful in real world applications. It is not really > possible to fix them in a compatible way so introduce a new v2 of the > protocol.

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

2016-01-28 Thread Giulio Camuffo
2016-01-28 9:52 GMT+02:00 Jan Arne Petersen : > There were some shortcomings in the first version of the protocol which > makes it not really useful in real world applications. It is not really > possible to fix them in a compatible way so introduce a new v2 of the > protocol. > > Fixes some shortc

[PATCH wayland-protocols] text: Create second version of text input protocol

2016-01-27 Thread Jan Arne Petersen
There were some shortcomings in the first version of the protocol which makes it not really useful in real world applications. It is not really possible to fix them in a compatible way so introduce a new v2 of the protocol. Fixes some shortcomings of the first version: * Use only one wp_text_inpu