Re: [PATCH wayland-protocols 0/3] xdg_surface base interface and xdg_tooltip

2016-01-14 Thread Bill Spitzak
Okay it makes sense. I think the term "toplevel" is rather confusing, since the word "level" is often used when talking about window stacking. Perhaps "normal" or "default"? Other thing is that the argument called "parent" to the set-role methods has got to be renamed. Perhaps to "surface"? I'm

Re: [PATCH wayland-protocols 0/3] xdg_surface base interface and xdg_tooltip

2016-01-13 Thread Jasper St. Pierre
It would help if you actually read the spec that was there before commenting. The difference between toplevels and popups is not whether they have a parent (toplevels indeed have a set_parent method), but that popups take an implicit pointer and keyboard grab, e.g. menus and comboboxes. They have w

[PATCH wayland-protocols 0/3] xdg_surface base interface and xdg_tooltip

2016-01-12 Thread Jonas Ã…dahl
Hi, These patches turns xdg_surface into a generic base interface that other xdg_* roles would then extend. The point of this is to unify some concepts common to all surfaces related to xdg_shell. The parts related to toplevel window management was moved out to a new "xdg_toplevel" interface. xdg_