Re: [PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-30 Thread Daniel Stone
Hi, On Wed, 29 Aug 2018 at 17:37, Emil Velikov wrote: > On 29 August 2018 at 07:17, Daniel Stone wrote: > > There are far better ways to detect memory leaks, such as either > > valgrind or ASan. Having Meson makes it really easy to use these tools > > in our tests, and we can do that in CI as

Re: [PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 07:17, Daniel Stone wrote: > There are far better ways to detect memory leaks, such as either > valgrind or ASan. Having Meson makes it really easy to use these tools > in our tests, and we can do that in CI as well. > > Having these local wrappers actually completely broke

Re: [PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-29 Thread Peter Hutterer
On Wed, Aug 29, 2018 at 07:17:15AM +0100, Daniel Stone wrote: > There are far better ways to detect memory leaks, such as either > valgrind or ASan. Having Meson makes it really easy to use these tools > in our tests, and we can do that in CI as well. > > Having these local wrappers actually

Re: EXT: [PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-29 Thread Daniel Stone
Hi Ian, On Wed, 29 Aug 2018 at 07:45, Ray, Ian (GE Healthcare) wrote: > > On 29 Aug 2018, at 9.17, Daniel Stone wrote: > > @@ -200,7 +147,7 @@ run_test(const struct test *t) > > assert(sigaction(SIGALRM, , NULL) == 0); > > } > > > > - cur_alloc = get_current_alloc_num();

Re: EXT: [PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-29 Thread Ray, Ian (GE Healthcare)
> On 29 Aug 2018, at 9.17, Daniel Stone wrote: > > There are far better ways to detect memory leaks, such as either > valgrind or ASan. Having Meson makes it really easy to use these tools > in our tests, and we can do that in CI as well. > > Having these local wrappers actually completely

[PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-29 Thread Daniel Stone
There are far better ways to detect memory leaks, such as either valgrind or ASan. Having Meson makes it really easy to use these tools in our tests, and we can do that in CI as well. Having these local wrappers actually completely broke ASan usage, so remove them in favour of using the more