Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-09 Thread Auke Booij
On 9 November 2015 at 11:41, Pekka Paalanen wrote: > I believe comments are enough. I suppose the DTD error message from > wayland-scanner could refer to built-in DTD, that would be a small > change and make it obvious. Just add one word in the warning message. Okay, your

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-09 Thread Peter Hutterer
On 9/11/2015 20:39 , Auke Booij wrote: On 6 November 2015 at 11:26, Pekka Paalanen wrote: On Fri, 6 Nov 2015 09:47:03 +1000 Peter Hutterer wrote: On Thu, Nov 05, 2015 at 04:58:09PM +0200, Pekka Paalanen wrote: On Mon, 19 Oct 2015 11:30:47

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-09 Thread Auke Booij
On 9 November 2015 at 10:54, Peter Hutterer wrote: > On 9/11/2015 20:39 , Auke Booij wrote: >> >> On 6 November 2015 at 11:26, Pekka Paalanen wrote: >>> >>> On Fri, 6 Nov 2015 09:47:03 +1000 >>> Peter Hutterer wrote: >>>

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-09 Thread Auke Booij
On 6 November 2015 at 11:26, Pekka Paalanen wrote: > On Fri, 6 Nov 2015 09:47:03 +1000 > Peter Hutterer wrote: > >> On Thu, Nov 05, 2015 at 04:58:09PM +0200, Pekka Paalanen wrote: >> > On Mon, 19 Oct 2015 11:30:47 +1000 >> > Peter Hutterer

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-09 Thread Pekka Paalanen
On Mon, 9 Nov 2015 11:16:09 + Auke Booij wrote: > On 9 November 2015 at 10:54, Peter Hutterer wrote: > > On 9/11/2015 20:39 , Auke Booij wrote: > >> > >> On 6 November 2015 at 11:26, Pekka Paalanen wrote: > >>> Would it be

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-06 Thread Pekka Paalanen
On Fri, 6 Nov 2015 09:47:03 +1000 Peter Hutterer wrote: > On Thu, Nov 05, 2015 at 04:58:09PM +0200, Pekka Paalanen wrote: > > On Mon, 19 Oct 2015 11:30:47 +1000 > > Peter Hutterer wrote: > > > > > On Fri, Oct 16, 2015 at 11:42:21AM +0300,

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-05 Thread Peter Hutterer
On Thu, Nov 05, 2015 at 03:40:27PM +, Auke Booij wrote: > On 5 November 2015 at 14:58, Pekka Paalanen wrote: > > On Mon, 19 Oct 2015 11:30:47 +1000 > > Peter Hutterer wrote: > > > >> On Fri, Oct 16, 2015 at 11:42:21AM +0300, Pekka Paalanen

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-05 Thread Peter Hutterer
On Thu, Nov 05, 2015 at 04:58:09PM +0200, Pekka Paalanen wrote: > On Mon, 19 Oct 2015 11:30:47 +1000 > Peter Hutterer wrote: > > > On Fri, Oct 16, 2015 at 11:42:21AM +0300, Pekka Paalanen wrote: > > > On Fri, 16 Oct 2015 12:29:11 +1000 > > > Peter Hutterer

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-05 Thread Auke Booij
On 5 November 2015 at 14:58, Pekka Paalanen wrote: > On Mon, 19 Oct 2015 11:30:47 +1000 > Peter Hutterer wrote: > >> On Fri, Oct 16, 2015 at 11:42:21AM +0300, Pekka Paalanen wrote: >> > On Fri, 16 Oct 2015 12:29:11 +1000 >> > Peter Hutterer

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-05 Thread Pekka Paalanen
On Mon, 19 Oct 2015 11:30:47 +1000 Peter Hutterer wrote: > On Fri, Oct 16, 2015 at 11:42:21AM +0300, Pekka Paalanen wrote: > > On Fri, 16 Oct 2015 12:29:11 +1000 > > Peter Hutterer wrote: > > > > > On Fri, Oct 09, 2015 at 01:16:49PM +0200,

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-18 Thread Peter Hutterer
On Fri, Oct 16, 2015 at 11:42:21AM +0300, Pekka Paalanen wrote: > On Fri, 16 Oct 2015 12:29:11 +1000 > Peter Hutterer wrote: > > > On Fri, Oct 09, 2015 at 01:16:49PM +0200, Nils Chr. Brause wrote: > > > Hi, > > > > > > Reviewed-by: Nils Christopher Brause

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-16 Thread Pekka Paalanen
On Fri, 16 Oct 2015 12:29:11 +1000 Peter Hutterer wrote: > On Fri, Oct 09, 2015 at 01:16:49PM +0200, Nils Chr. Brause wrote: > > Hi, > > > > Reviewed-by: Nils Christopher Brause > > > > I ran distcheck and it worked. :) > > a bit late,

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-15 Thread Peter Hutterer
On Fri, Oct 09, 2015 at 01:16:49PM +0200, Nils Chr. Brause wrote: > Hi, > > Reviewed-by: Nils Christopher Brause > > I ran distcheck and it worked. :) a bit late, but I would like to register my disagreement with this patch :) Having the DTD is a much simpler and

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-09 Thread Auke Booij
Yeah, that was a pretty embarrassing mistake by me, for such a simple patch. Thanks to Bryce for catching it. On 8 October 2015 at 15:05, Pekka Paalanen wrote: > On Thu, 8 Oct 2015 14:35:34 +0100 > Auke Booij wrote: > >> The wayland scanner defines the

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-09 Thread Nils Chr. Brause
Hi, Reviewed-by: Nils Christopher Brause I ran distcheck and it worked. :) Cheers, Nils On Fri, Oct 9, 2015 at 10:01 AM, Auke Booij wrote: > Yeah, that was a pretty embarrassing mistake by me, for such a simple > patch. Thanks to Bryce for

[PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-08 Thread Auke Booij
The wayland scanner defines the protocol. The DTD specification is not used. --- Makefile.am | 4 ++-- protocol/wayland.dtd | 29 - 2 files changed, 2 insertions(+), 31 deletions(-) delete mode 100644 protocol/wayland.dtd diff --git a/Makefile.am

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-08 Thread Pekka Paalanen
On Thu, 8 Oct 2015 14:35:34 +0100 Auke Booij wrote: > The wayland scanner defines the protocol. The DTD specification is not used. > --- > Makefile.am | 4 ++-- > protocol/wayland.dtd | 29 - > 2 files changed, 2 insertions(+), 31