Re: [PATCH weston] compositor: change rounding in weston_surface_to_buffer_rect()

2015-12-01 Thread Pekka Paalanen
On Mon, 30 Nov 2015 13:33:16 -0600 Derek Foreman wrote: > Rounding both corners of the rectangle down can result in a 0 > width/height rectangle before passing to weston_transformed_rect. > > This showed up as missing damage in weston-simple-damage (the > bouncing ball

Re: [PATCH weston] compositor: change rounding in weston_surface_to_buffer_rect()

2015-12-01 Thread Derek Foreman
On 01/12/15 03:48 AM, Pekka Paalanen wrote: > On Mon, 30 Nov 2015 13:33:16 -0600 > Derek Foreman wrote: > >> Rounding both corners of the rectangle down can result in a 0 >> width/height rectangle before passing to weston_transformed_rect. >> >> This showed up as missing

Re: [PATCH weston] compositor: change rounding in weston_surface_to_buffer_rect()

2015-11-30 Thread Derek Foreman
On 30/11/15 03:21 PM, Daniel Stone wrote: > Hi, > > On 30 November 2015 at 19:33, Derek Foreman wrote: >> Rounding both corners of the rectangle down can result in a 0 >> width/height rectangle before passing to weston_transformed_rect. >> >> This showed up as missing

Re: [PATCH weston] compositor: change rounding in weston_surface_to_buffer_rect()

2015-11-30 Thread Daniel Stone
Hi, On 30 November 2015 at 19:33, Derek Foreman wrote: > Rounding both corners of the rectangle down can result in a 0 > width/height rectangle before passing to weston_transformed_rect. > > This showed up as missing damage in weston-simple-damage (the > bouncing ball

[PATCH weston] compositor: change rounding in weston_surface_to_buffer_rect()

2015-11-30 Thread Derek Foreman
Rounding both corners of the rectangle down can result in a 0 width/height rectangle before passing to weston_transformed_rect. This showed up as missing damage in weston-simple-damage (the bouncing ball would leave green trails when --use-viewport was used) Also, add a big fat warning for users