Re: [PATCH weston] compositor: fix crash when destroying incompletely created output

2015-08-06 Thread Derek Foreman
On 06/08/15 07:12 PM, Dawid Gajownik wrote: > On Wed, Aug 5, 2015 at 6:20 PM, Derek Foreman wrote: >> Good catch! >> >> However, can we get the same result by making weston_output_init() call >> wl_list_init(&output->link)? >> >> I think that'd be simple enough not to require a comment to explain

Re: [PATCH weston] compositor: fix crash when destroying incompletely created output

2015-08-06 Thread Dawid Gajownik
On Wed, Aug 5, 2015 at 6:20 PM, Derek Foreman wrote: > Good catch! > > However, can we get the same result by making weston_output_init() call > wl_list_init(&output->link)? > > I think that'd be simple enough not to require a comment to explain > what's going on... Indeed, you're right. I tested

Re: [PATCH weston] compositor: fix crash when destroying incompletely created output

2015-08-05 Thread Derek Foreman
On 30/07/15 08:23 PM, Dawid Gajownik wrote: > When output can't be created in foo_backend_create_output(), > weston_output_destroy() is called without executing > weston_compositor_add_output(). In such a case output->link is not initialized > and causes application crash on wl_list_remove(&output-

[PATCH weston] compositor: fix crash when destroying incompletely created output

2015-07-30 Thread Dawid Gajownik
When output can't be created in foo_backend_create_output(), weston_output_destroy() is called without executing weston_compositor_add_output(). In such a case output->link is not initialized and causes application crash on wl_list_remove(&output->link). This problem happens when drm, fbdev, rdp,